Skip to content

Commit

Permalink
Continue to support EOL'd Ruby versions (sigh)
Browse files Browse the repository at this point in the history
  • Loading branch information
@bkeepers
bkeepers committed Jul 27, 2022
1 parent 36c117c commit d7c9135
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ['2.7', '3.0', '3.1', '3.2']
ruby: ['2.5', '2.6', '2.7', '3.0', '3.1', '3.2']
steps:
- name: Check out repository code
uses: actions/checkout@v3
Expand Down

1 comment on commit d7c9135

@natematykiewicz
Copy link

@natematykiewicz natematykiewicz commented on d7c9135 Jul 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkeepers Per #457's point, you don't need to restore support for 2.5 and 2.6 if you don't want to. But you do need to add a required_ruby_version into your gemspec. It's fine if people just can't install dotenv 2.9 on Ruby 2.5 or 2.6. CI won't attempt that if you've configured your required_ruby_version to say the gem only supports '>= 2.7.0'. But right now your gemspec says you support all ruby versions, and that's not true, which causes huge problems for Ruby 2.5 & 2.6 users. Regardless of what versions you support, you should specify the requirements in the gemspec.

I'd propose you drop support for EOL ruby versions but also update your gemspec files.
Here's Rails' for an example. Rails supports Ruby 2.7+.
https://github.com/rails/rails/blob/main/rails.gemspec#L12

Please sign in to comment.