Reorder to make the load method available #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are getting the following error when trying to use `require "dotenv/rails-now"` > /Users/mikaelhenriksson/.rvm/gems/ruby-2.1.8/gems/activesupport-3.2.22.6/lib/active_support/dependencies.rb:243:in `load': wrong number of arguments (0 for 1..2) (ArgumentError) > from /Users/mikaelhenriksson/.rvm/gems/ruby-2.1.8/gems/dotenv-rails-2.0.1/lib/dotenv/rails.rb:20:in `block in <class:Railtie>' Reordering the file so that the methods are defined before using them fixes this problem. Our codebase is from 2005 so I am sure it could be fixed in other ways but this is verified to fix our problem.
|
+1 this resolved an issue for me as well. |
koic
reviewed
Jan 14, 2017
| @@ -43,5 +41,7 @@ def root | |||
| def self.load | |||
| instance.load | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
RuboCop has been failed below.
lib/dotenv/rails.rb:44:1: C: Trailing whitespace detected.
I think that this warning will disappear with following diff.
+
-cf. https://travis-ci.org/bkeepers/dotenv/jobs/172001102
Thanks.
* origin/master: Nokogiri 1.7 requires Ruby version >= 2.1.0 Travis 'Ruby rbx-2' failing on master Use the latest rubies on Travis Rack 2 requires Ruby version >= 2.2.2 CI against Ruby 2.4.0
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are getting the following error when trying to use
require "dotenv/rails-now"Reordering the file so that the methods are defined before using them fixes this problem. Our codebase is from 2005 so I am sure it could be fixed in other ways but this is verified to fix our problem.
Note 1: The errors on CI doesn't seem to be related to my changes.
Note 2: This works for us on a rails 3.2 project