Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds specs and fix for \s after separator #399

Merged

Conversation

l-schirrmeister
Copy link

We have in our .env-file an entry with = as separator followed by a \s and a quoted value including # in this way:

SECRET_PASSWORD              = 'foo#bar234#'

Parsing it leads to the unfortunate cutting after the #:

env("SECRET_PASSWORD              = 'foo#bar234#'")
=> {"SECRET_PASSWORD"=>"'foo"}

This fix will let it parse correctly:

env("SECRET_PASSWORD              = 'foo#bar234#'")
=> {"SECRET_PASSWORD"=>"foo#bar234#"}

@vermaxik
Copy link

Thank for MR @l-schirrmeister !
We have the same issue since 2.5 and fixated an app with 2.4 version.

@cadwallion cadwallion self-assigned this Jul 31, 2019
Copy link
Collaborator

@cadwallion cadwallion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! I'll be cutting a patch-level release shortly with this.

@cadwallion cadwallion merged commit 93f2ca9 into bkeepers:master Jul 31, 2019
@promisedlandt
Copy link

Good job @l-schirrmeister :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants