-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long render times for large datasets #41
Comments
Hey @tudorbertiean, Thanks for reminding me of this and apologies for the bottleneck. I'm currently working on a few performance improvements for large graphs to avoid blocking the main render thread for long periods of time. Seen some significant speed ups with the JSON example you mentioned, would be great to have your tree to test with if it's not private/confidential info :) |
Thanks for the response, I will attach the json file but modified the data for testing purposes. Keep up the good work! |
Awesome, thank you for this! It's super useful to have a large dataset that approximates a real world use case for someone. I'll be pushing a release tomorrow or Sunday at the latest that should improve performance a lot for large graphs 👍 |
+1 I'm trying to render 10+ trees at once with different data sets and it crashes the browser thanks for actively maintaining this project!! |
@RohanDamani Damn sorry about that, this should get a lot more stable this weekend. |
* Adds `shouldNodeTransform` check + test * Turns `setTransformOrientation` into pure func * Turns `applyTransform` into pure func * Avoids unnecessary d3 .transition() calls
Released this as v1.5.1 just now so closing the issue. Please check the release notes, update and let me know in a new issue if something is wrong :) The major bottleneck seems to lie with D3's I'll see what can be done to throttle/debounce the calls to still be able to use transitions on very large graphs while keeping responsiveness. Suggestions/contributions always welcome! |
@bkrem much better thanks! |
Has this been implemented? |
Is there any work around for the long rendering time for large datasets? I have approximately 500 nodes and the rendering freezes the page for about 1 minute until finally displayed.
Also occurs when using your data from 'json-example.json'.
The text was updated successfully, but these errors were encountered: