fix urls getting duplicated

bl-sdk · Apr 1, 2024 · d30147d · d30147d
1 parent a8509ed
commit d30147d
Showing 1 changed file with 15 additions and 8 deletions.
diff --git a/assets/js/pyproject-loader.js b/assets/js/pyproject-loader.js
@@ -149,17 +149,24 @@ async function load_from_pyproject(url, fields) {
 
         const urls = pyproject?.project?.urls;
         if (urls) {
-            if (!url_box) {
-                url_box = document.createElement("div");
-                url_box.classList.add("url-box");
-                document.querySelector("dl.mod-desc").after(url_box);
-            }
+            const new_children = Object.entries(urls).map(([name, url]) => make_link(name, url));
+
+            if (new_children.length > 0){
+                if (!url_box) {
+                    url_box = document.createElement("div");
+                    url_box.classList.add("url-box");
+                    document.querySelector("dl.mod-desc").after(url_box);
+                }
 
-            for (const [name, url] of Object.entries(urls)) {
-                url_box.appendChild(make_link(name, url));
+                url_box.replaceChildren(...new_children);
+
+            // If `pyproject.project.urls` exists, but is empty
+            } else {
+                url_box?.remove();
             }
 
-        // If `pyproject.project` exists, but `pyproject.project.urls` does not/is empty
+
+        // If `pyproject.project` exists, but `pyproject.project.urls` does not
         } else if (pyproject?.project) {
             url_box?.remove();
         }