Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This fixes #428 #433

Merged
merged 17 commits into from
Feb 5, 2018
Merged

This fixes #428 #433

merged 17 commits into from
Feb 5, 2018

Conversation

martinmarsicano
Copy link
Collaborator

I put the /sprint/results/sprintID request in the finally sentence of observable of comment/new (thanks @RiieCco )

With this changes the user can input international characters like á, ì and ç.
Correction of the Checklist Order on a Sprint.
Before: 1.1, 1.10, 1.2
Now: 1.1, 1.2, 1.10
Correction of unused variable and "Redefining built-in 'list'" Codacy issues.
Order requirements in checklist page
Now on the Failed requirements page, there is a button to export that requirements to Defect Dojo.
Buttons hidding or not acordint to checklist status in Project-Summary.
Fixed Codacy issues of #430
Fix of error introduced by Codacy issue.
Fix of issue in which only admin can create projects and sprints.
Using observable in Angular (thanks RiieCco) with finally making the call for the new list.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.601% when pulling d88b680 on martinmarsicano:master into 369eeb8 on blabla1337:master.

@codecov
Copy link

codecov bot commented Feb 5, 2018

Codecov Report

Merging #433 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
- Coverage   67.15%   67.06%   -0.09%     
==========================================
  Files          33       33              
  Lines         749      750       +1     
  Branches       76       77       +1     
==========================================
  Hits          503      503              
- Misses        175      176       +1     
  Partials       71       71
Impacted Files Coverage Δ
...c/app/project-summary/project-summary.component.ts 39.02% <0%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 369eeb8...d88b680. Read the comment docs.

@blabla1337
Copy link
Owner

Again thanks Martin for the help ^^

@blabla1337 blabla1337 merged commit 895fc61 into blabla1337:master Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants