Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Replace CurrencyPipe and DecimalPipe with custom utility #74

Merged
merged 2 commits into from
May 2, 2019

Conversation

Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush commented May 1, 2019

@codecov
Copy link

codecov bot commented May 1, 2019

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #74   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          18     19    +1     
  Lines         269    304   +35     
  Branches       44     52    +8     
=====================================
+ Hits          269    304   +35
Impacted Files Coverage Δ
src/app/public/modules/format/format.ts 100% <ø> (ø) ⬆️
src/app/public/modules/numeric/numeric.module.ts 100% <ø> (ø) ⬆️
src/app/public/modules/numeric/numeric.service.ts 100% <100%> (ø) ⬆️
...pp/public/modules/numeric/number-format-utility.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3d5077...ee701f5. Read the comment docs.

Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Just one last question - this won't work in skyux2 unless we get your other updates from i18n, correct?

Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 6a0ffd7 into master May 2, 2019
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the number-intl branch May 2, 2019 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants