Added sky adapter service #81
Conversation
Blackbaud-AlexKingman
requested a review
from Blackbaud-SteveBrush
as a code owner
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 19 19
Lines 304 304
Branches 52 52
=====================================
Hits 304 304Continue to review full report at Codecov.
|
| /* tslint:enable */ | ||
|
|
||
| @Injectable() | ||
| export class SkyAdapterService { |
There was a problem hiding this comment.
I think we might need a better name. I totally get that this is an adapter but I'm wondering if we will get confused down the road with what this is vs the other adapters we have. Thoughts?
There was a problem hiding this comment.
SkyCoreAdapterService?
There was a problem hiding this comment.
Maybe? Lol. I think that is better than what is currently here.
There was a problem hiding this comment.
Done.
| SkyCoreAdapterService | ||
| ] | ||
| }) | ||
| export class SkyAdapterModule { } |
There was a problem hiding this comment.
I think we should rename the module here too.
There was a problem hiding this comment.
Ah, good catch. Done.
No description provided.