Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Moved min-width to table cell (instead of sky-grid-cell) #38

Merged
merged 3 commits into from
Feb 1, 2019

Conversation

Blackbaud-AlexKingman
Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman commented Jan 31, 2019

Addresses #27

This should clear up issues where inner text in grid cell was getting truncated. This scenario only happens when:

  1. all column widths are defined
  2. column widths add up to be less that the total width of table
  3. truncated item must be wider than the width given to column

@codecov
Copy link

codecov bot commented Jan 31, 2019

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          10       10           
  Lines         542      542           
  Branches       82       82           
=======================================
  Hits          541      541           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8e8c41...6a32533. Read the comment docs.

@Blackbaud-AlexKingman Blackbaud-AlexKingman merged commit 1f97d35 into master Feb 1, 2019
@Blackbaud-AlexKingman Blackbaud-AlexKingman deleted the min-width-fix branch February 1, 2019 16:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants