Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Replace current toolbar with list-builder's multiselect toolbar #25

Merged
merged 14 commits into from
Mar 21, 2019

Conversation

Blackbaud-AlexKingman
Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman commented Mar 12, 2019

Addresses #13

@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #25 into master will decrease coverage by 0.46%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage     100%   99.53%   -0.47%     
==========================================
  Files          12       12              
  Lines         226      213      -13     
  Branches       42       39       -3     
==========================================
- Hits          226      212      -14     
- Misses          0        1       +1
Impacted Files Coverage Δ
.../list-view-checklist/list-view-checklist.module.ts 100% <ø> (ø) ⬆️
...st-view-checklist/list-view-checklist.component.ts 100% <100%> (ø) ⬆️
...esources/list-view-checklist-resources-provider.ts 87.5% <0%> (-12.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c2d798...62389b9. Read the comment docs.

Copy link
Member

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to think about :)

Copy link
Member

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Blackbaud-AlexKingman Blackbaud-AlexKingman merged commit c1a827c into master Mar 21, 2019
@Blackbaud-AlexKingman Blackbaud-AlexKingman deleted the multiselect-toolbar branch March 21, 2019 21:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants