-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you have a visual test failing, but otherwise looks good!
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
==========================================
+ Coverage 99.75% 99.76% +<.01%
==========================================
Files 19 19
Lines 416 420 +4
Branches 64 65 +1
==========================================
+ Hits 415 419 +4
Misses 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blackbaud-conorwright Do you mind adding a visual test that demonstrates an input with autofocus
working? I know we have one for the unit tests, but it'd be nice to get a screenshot with the focus blur on an <input type="text" autofocus>
.
Added an autofocus visual test. I also added names for all the screenshots, because adding a new visual test pushed them each down a number and would have caused me to regenerate baselines that weren't directly affected (because they now matched screenshot 18 rather than 17) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more issue.
Also: If you add z-index: 1;
to the .sky-modal-content
style, it will make the blue focus blur appear on top of the modal footer.
src/app/public/modules/modal/modal-component-adapter.service.ts
Outdated
Show resolved
Hide resolved
Steve's comment (z-index) has been seen to. Dismissing to add final approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it.
Resolves: blackbaud/skyux2#2044