Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Media mixins #58

Merged
merged 13 commits into from
May 3, 2019
Merged

Media mixins #58

merged 13 commits into from
May 3, 2019

Conversation

Blackbaud-TrevorBurch
Copy link
Member

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch commented Apr 19, 2019

@codecov
Copy link

codecov bot commented Apr 19, 2019

Codecov Report

Merging #58 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #58   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          23     23           
  Branches        1      1           
=====================================
  Hits           23     23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65ffb2a...064c809. Read the comment docs.

Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks great and worked well with integration tests on flyout & layout repos. Some minor suggestions. Take 'em or leave 'em.

Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌭

package.json Outdated Show resolved Hide resolved
@Blackbaud-TrevorBurch Blackbaud-TrevorBurch merged commit db93dfb into master May 3, 2019
@Blackbaud-TrevorBurch Blackbaud-TrevorBurch deleted the media-mixin branch May 3, 2019 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants