This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Upgrade intl-tel-input #1107
Merged
Upgrade intl-tel-input #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1107 +/- ##
======================================
Coverage 100% 100%
======================================
Files 174 174
Lines 6518 6518
Branches 1149 1149
======================================
Hits 6518 6518
Continue to review full report at Codecov.
|
| @@ -7,7 +7,7 @@ describe('Phone Field directive', function () { | |||
| selectors = { | |||
| flagContainer: '.flag-container', | |||
| countryList: '.country-list', | |||
| localCountryTextbox: 'input[placeholder="(201) 555-5555"]', | |||
| localCountryTextbox: 'input[placeholder="(201) 555-0123"]', | |||
There was a problem hiding this comment.
intl-tel-input changed the default placeholder in its recent versions.
| @@ -34,7 +34,7 @@ | |||
| // So, its dial code should just be 1 because the area code includes the dial code. | |||
| // Example countries: Bahamas, Cayman Islands, Barbados. | |||
| if (selectedCountryData.dialCode.toString()[0] === '1') { | |||
| selectedCountryData.dialCode = 1; | |||
| selectedCountryData.dialCode = '1'; | |||
There was a problem hiding this comment.
There was a logical error in the directive where it was setting the phone number dial code to an integer instead of a string. This had to be remedied to use the newer version of the library.
Blackbaud-AlexKingman
approved these changes
Jan 3, 2019
This was referenced Jan 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original contribution: blackbaud/skyux#1105
Issue: blackbaud/skyux#1104
Docs: N/A