Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Added showHelp and showSettings inputs to tiles #1110

Merged
merged 4 commits into from
Jan 14, 2019

Conversation

blackbaud-conorwright
Copy link
Contributor

Issue: #1109
Docs: Included in PR

@codecov-io
Copy link

codecov-io commented Jan 9, 2019

Codecov Report

Merging #1110 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1110   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         174     174           
  Lines        6518    6528   +10     
  Branches     1149    1153    +4     
======================================
+ Hits         6518    6528   +10
Impacted Files Coverage Δ
js/sky/src/tiles/tiles.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10a9266...b0bf156. Read the comment docs.

Copy link
Contributor

@blackbaud-johnly blackbaud-johnly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't speak to the code, but doc changes look good to me.

@Blackbaud-SteveBrush Blackbaud-SteveBrush self-assigned this Jan 10, 2019
Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blackbaud-conorwright blackbaud-conorwright merged commit 08c06bb into master Jan 14, 2019
@blackbaud-conorwright blackbaud-conorwright deleted the add-tile-show-help-and-settings branch January 14, 2019 15:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants