Skip to content
This repository has been archived by the owner on Jun 22, 2023. It is now read-only.

Updated docs for dropdown a11y adjustments #19

Merged
merged 13 commits into from
Jan 29, 2018

Conversation

Blackbaud-SteveBrush
Copy link
Member

Depends on: blackbaud/skyux2#1386

Copy link
Contributor

@blackbaud-johnly blackbaud-johnly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a bunch of changes to the branch. As long as the changes work for you, this LGTM.

Copy link
Contributor

@blackbaud-johnly blackbaud-johnly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made two minor changes. Otherwise, LGTM.

@Blackbaud-SteveBrush
Copy link
Member Author

@blackbaud-johnly I forgot that we need to document the Popover's new dismissOnBlur input. I'll get you the details on Monday!

Copy link
Contributor

@blackbaud-johnly blackbaud-johnly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit b02d34b into master Jan 29, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the docs-dropdown-a11y branch January 29, 2018 15:12
blackbaud-johnly added a commit that referenced this pull request Feb 6, 2018
* Upgraded Stache in order to enable edit button. (#21)

* Updated docs for dropdown a11y adjustments (#19)

* Port over a11y changes (#22)

* Copy over a11y doc changes.

* a11y docs from skyux2 repo.

* Delete duplicate line.

* Update links.

* More a11y doc tweaks.

* Fix linting error.

* add link to github issue (#24)

* add link to github issue

* added note that component doesn't exist yet

* Clean up tab spacing (#23)

* Clean up tab spacing.

* Clean up tab spacing and other inconsistencies.

* Document how to serve multiple SPAs. (#25)

* Document how to serve multiple SPAs.

* Doc tweaks to address feedback.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants