This repository has been archived by the owner on Jun 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 32
Updated docs for dropdown a11y adjustments #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackbaud-johnly
approved these changes
Jan 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed a bunch of changes to the branch. As long as the changes work for you, this LGTM.
blackbaud-johnly
approved these changes
Jan 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made two minor changes. Otherwise, LGTM.
@blackbaud-johnly I forgot that we need to document the Popover's new |
blackbaud-johnly
approved these changes
Jan 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
blackbaud-johnly
added a commit
that referenced
this pull request
Feb 6, 2018
* Upgraded Stache in order to enable edit button. (#21) * Updated docs for dropdown a11y adjustments (#19) * Port over a11y changes (#22) * Copy over a11y doc changes. * a11y docs from skyux2 repo. * Delete duplicate line. * Update links. * More a11y doc tweaks. * Fix linting error. * add link to github issue (#24) * add link to github issue * added note that component doesn't exist yet * Clean up tab spacing (#23) * Clean up tab spacing. * Clean up tab spacing and other inconsistencies. * Document how to serve multiple SPAs. (#25) * Document how to serve multiple SPAs. * Doc tweaks to address feedback.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: blackbaud/skyux2#1386