Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Definition list component 'None found' strangeness #967

Closed
Blackbaud-PatrickOFriel opened this issue Aug 1, 2017 · 8 comments
Closed

Definition list component 'None found' strangeness #967

Blackbaud-PatrickOFriel opened this issue Aug 1, 2017 · 8 comments
Assignees
@Blackbaud-TrevorBurch
Labels
Type: Bug

Comments

@Blackbaud-PatrickOFriel
Copy link
Contributor

There seems to be a race condition in the definition list component which causes the 'None found' text to be shown even when content exists. We might want to look into using something like our MutationObserverService (used in text-highlight) so we can watch for changes in child DOM elements more effectively
@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the title Definition list component None found strangeness Definition list component 'None found' strangeness Sep 6, 2017
@Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-PaulCrowder @Blackbaud-BobbyEarl I'm unable to reproduce this issue?

@Blackbaud-BobbyEarl
Copy link

Navigate directly to https://developer.blackbaud.com/skyux2/components/definition-list and you should be able to see it.

@Blackbaud-SteveBrush
Copy link
Member

You can also navigate directly to: https://developer.blackbaud.com/skyux2/components/numeric

@Blackbaud-SteveBrush Blackbaud-SteveBrush self-assigned this Nov 27, 2017
Blackbaud-PaulCrowder added a commit that referenced this issue Jan 17, 2018
@Blackbaud-PaulCrowder
Removed OnPush change detection from definition list value component
e880105 
This is so the template will re-evaluate the length of the value’s
`innerText` element when changes occur to the parent component.

Fixes #967
Merged
Blackbaud-SteveBrush pushed a commit that referenced this issue Jan 23, 2018
@Blackbaud-PaulCrowder @Blackbaud-SteveBrush
Removed OnPush change detection from definition list value component (#…
d0c771f 
…1424)

* Removed OnPush change detection from definition list value component

This is so the template will re-evaluate the length of the value’s
`innerText` element when changes occur to the parent component.

Fixes #967

* Fixed typos in test name

* Fixed indentation
@Blackbaud-BobbyEarl
Copy link

I've done no investigation into this, but still seeing this behavior on the toolbar documentation. Perhaps related to being in an *ngIf? Going to reopen this in order to track it.

https://developer.blackbaud.com/skyux/components/toolbar

@Blackbaud-TrevorBurch
Copy link
Member

@Blackbaud-BobbyEarl I just happened to glance at this issue and am not seeing any weirdness on that component's documentation page? Can you elaborate on where you saw the issue/if it is still there and I'm missing it.

@Blackbaud-BobbyEarl
Copy link

I am no longer able to reproduce this behavior in any of the previously found implementations. I'm going to close. Thanks @Blackbaud-TrevorBurch

@Blackbaud-JasonBoulware
Copy link

I am still seeing this issue in conjunction with the repeater.

@Blackbaud-BobbyEarl
Copy link

Thanks for the heads up @Blackbaud-JasonBoulware. Below is a concise plunker demoing the problem.

https://plnkr.co/edit/3sZjyoSfnuTo5Wz0sCE8?p=preview

Merged
Blackbaud-TrevorBurch added a commit that referenced this issue Aug 18, 2018
@Blackbaud-TrevorBurch
Fix for issues with definition list in repeaters (#1919)
b7fd445 
Resolves #967
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@Blackbaud-BobbyEarl @Blackbaud-PatrickOFriel @Blackbaud-PaulCrowder @Blackbaud-SteveBrush @blackbaud-danbowman @Blackbaud-TrevorBurch @Blackbaud-JasonBoulware