This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
edits to design docs to match UX1 #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blackbaud-johnly making same edits to UX2 docs |
Codecov Report
@@ Coverage Diff @@
## master #1066 +/- ##
======================================
Coverage 100% 100%
======================================
Files 317 317
Lines 5976 5976
Branches 759 759
======================================
Hits 5976 5976Continue to review full report at Codecov.
|
src/app/design/color/index.html
Outdated
| @@ -343,7 +343,7 @@ <h2 class="sky-section-heading">Highlights</h2> | |||
| <div class="definition-props"> | |||
| <div class="definition-usage"> | |||
| <div class="sky-field-label">Usage</div> | |||
| <div>Highlight for elements conveying an "success" status, such as alerts and toasts</div> | |||
| <div>Highlight for elements that convey a "success" status, such as alerts, labels and toasts</div> | |||
There was a problem hiding this comment.
Add a comma after "labels."
src/app/design/typography/index.html
Outdated
| @@ -4,7 +4,7 @@ | |||
| pageTitle="Typography" | |||
| windowTitle="Typography"> | |||
|
|
|||
| <stache-page-summary>SKY UX supports a set of semantically defined classes for text to ensure consistent usage and to maintain visual hierarchy of type. Components will generally incorporate text classes as necessary, although you may find cases where you need to apply these classes directly.</stache-page-summary> | |||
| <stache-page-summary>SKY UX supports a set of semantically defined classes for text to ensure consistent usage and to maintain visual hierarchy of type. Components generally incorporate text classes as necessary but you may find cases where you need to apply classes directly.</stache-page-summary> | |||
There was a problem hiding this comment.
Add a comma before "but"
blackbaud-johnly
approved these changes
Sep 15, 2017
Blackbaud-ToddRoberts
requested review from
Blackbaud-BobbyEarl and
Blackbaud-SteveBrush
|
@Blackbaud-SteveBrush or @Blackbaud-BobbyEarl any ideas why this started failing after i updated from master? there weren't any conflicts. I can't access the VSTS page to check. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.