-
Notifications
You must be signed in to change notification settings - Fork 65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On mobile view, the right chevron should be $sky-text-color-icon-borderless and darken 20% on hover. Other than that I think it looks ok.
@Blackbaud-ToddRoberts The mobile view is implemented as well as the right arrow styling. |
Adding section service to communicate if a section is invalid or required.
src/scss/_mixins.scss
Outdated
content: "\f071"; | ||
font-family: FontAwesome; | ||
margin-right: 5px; | ||
color: $sky-highlight-color-danger; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind fixing the tabs, here?
Also, is it possible to show a demo of the sectioned form outside of a modal? |
@Blackbaud-SteveBrush Since there are a bunch of files the tab turns into a dropdown of all the demo files. It's there. Should I change the order of those and put the most relevant file first? It's possible to show a demo of the form outside of a modal if we think it is a use case people will want. |
@Blackbaud-AdamHickey: Sorry for the question regarding the code samples; I didn't think to click on the tab's dropdown menu. I'd prefer to promote the Sectioned Form as a separate, static component, and the demonstration of the modal would be secondary (but still effectively documented). What's the work effort to display the sectioned form on the page statically, and use the same markup to also open it in a modal? If it's too much, we can talk about alternatives... |
@Blackbaud-SteveBrush The section component can load outside of the modal. I have updated the demo with a new example of the sectioned form outside of a modal. |
Sectioned modal component #518