Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Sectioned modal #1068

Merged
merged 180 commits into from
Sep 27, 2017
Merged

Sectioned modal #1068

merged 180 commits into from
Sep 27, 2017

Conversation

Blackbaud-AdamHickey
Copy link
Contributor

Sectioned modal component #518

Copy link
Contributor

@Blackbaud-ToddRoberts Blackbaud-ToddRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On mobile view, the right chevron should be $sky-text-color-icon-borderless and darken 20% on hover. Other than that I think it looks ok.

@Blackbaud-AdamHickey
Copy link
Contributor Author

@Blackbaud-ToddRoberts The mobile view is implemented as well as the right arrow styling.

content: "\f071";
font-family: FontAwesome;
margin-right: 5px;
color: $sky-highlight-color-danger;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind fixing the tabs, here?

@Blackbaud-SteveBrush
Copy link
Member

Is there an example of the HTML required to create a sectioned modal? All I see is the button markup.

screen shot 2017-09-22 at 1 22 23 pm

@Blackbaud-SteveBrush
Copy link
Member

Also, is it possible to show a demo of the sectioned form outside of a modal?

@Blackbaud-AdamHickey
Copy link
Contributor Author

@Blackbaud-SteveBrush Since there are a bunch of files the tab turns into a dropdown of all the demo files. It's there. Should I change the order of those and put the most relevant file first?

It's possible to show a demo of the form outside of a modal if we think it is a use case people will want.

@Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-AdamHickey: Sorry for the question regarding the code samples; I didn't think to click on the tab's dropdown menu.

I'd prefer to promote the Sectioned Form as a separate, static component, and the demonstration of the modal would be secondary (but still effectively documented). What's the work effort to display the sectioned form on the page statically, and use the same markup to also open it in a modal? If it's too much, we can talk about alternatives...

@Blackbaud-AdamHickey
Copy link
Contributor Author

@Blackbaud-SteveBrush The section component can load outside of the modal. I have updated the demo with a new example of the sectioned form outside of a modal.

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit ed60298 into master Sep 27, 2017
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the sectioned-modal branch September 27, 2017 13:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants