-
Notifications
You must be signed in to change notification settings - Fork 65
Added shadow and border-radius CSS classes #1571
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1571 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 391 391
Lines 7885 7885
Branches 1152 1152
=======================================
Hits 7884 7884
Misses 1 1 Continue to review full report at Codecov.
|
I assume the classes are baked into the components, and won't require devs to specify those classes each time they use the component? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my inline comment.
src/scss/_theme.scss
Outdated
@@ -155,3 +156,11 @@ input:-moz-placeholder { /* Firefox 18- */ | |||
opacity: 1; | |||
} | |||
/* End Placeholder Text */ | |||
|
|||
.sky-border-radius { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the CSS class name might need to be something more descriptive of the purpose of the class rather than a particular CSS property it affects. Is there a common use case for rounded borders which we could use for a name? If not, maybe we should go with something like sky-rounded-corners
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory we use them for active elements (buttons, input fields, etc), in practice that is not consistent.
This will allow external libraries to add SKY-approved drop-shadow and border-radius styles to their elements.