Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Added shadow and border-radius CSS classes #1571

Merged
merged 10 commits into from
Apr 5, 2018
Merged

Conversation

Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush commented Mar 20, 2018

This will allow external libraries to add SKY-approved drop-shadow and border-radius styles to their elements.

@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the title Added margin, padding, and shadow CSS classes [HOLD] Added margin, padding, and shadow CSS classes Mar 21, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the title [HOLD] Added margin, padding, and shadow CSS classes Added shadow and border radius CSS classes; refactored list secondary actions to not use dropdown styles Mar 28, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the title Added shadow and border radius CSS classes; refactored list secondary actions to not use dropdown styles Added shadow and border-radius CSS classes Mar 28, 2018
@codecov-io
Copy link

codecov-io commented Mar 28, 2018

Codecov Report

Merging #1571 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1571   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         391      391           
  Lines        7885     7885           
  Branches     1152     1152           
=======================================
  Hits         7884     7884           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1320736...4d5cd45. Read the comment docs.

@Blackbaud-ToddRoberts
Copy link
Contributor

I assume the classes are baked into the components, and won't require devs to specify those classes each time they use the component?

Copy link
Member

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my inline comment.

@@ -155,3 +156,11 @@ input:-moz-placeholder { /* Firefox 18- */
opacity: 1;
}
/* End Placeholder Text */

.sky-border-radius {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the CSS class name might need to be something more descriptive of the purpose of the class rather than a particular CSS property it affects. Is there a common use case for rounded borders which we could use for a name? If not, maybe we should go with something like sky-rounded-corners.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory we use them for active elements (buttons, input fields, etc), in practice that is not consistent.

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 1c8cc93 into master Apr 5, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the css-classes branch April 5, 2018 03:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants