IE 11 drop down key up and down events issue #1535 #1652
Conversation
|
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 54f0bde (Please note that this is a fully automated comment.) |
Codecov Report
@@ Coverage Diff @@
## master #1652 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 395 395
Lines 8108 8110 +2
Branches 1194 1196 +2
=======================================
+ Hits 8107 8109 +2
Misses 1 1
Continue to review full report at Codecov.
|
|
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 7979252 (Please note that this is a fully automated comment.) |
| @@ -338,6 +356,71 @@ describe('Dropdown component', () => { | |||
| verifyFocusedMenuItemByIndex(3); | |||
| })); | |||
|
|
|||
| it('should navigate menu items with internet explorer arrow keys', fakeAsync(() => { | |||
There was a problem hiding this comment.
Since this is a near duplicate of the non-IE unit test, perhaps we could wrap the duplicate code in a verifyArrowKeyNavigation(upKey: string, downKey: string) method and pass in the unique key values. That way, if we can be sure that both sets are being tested the same. e.g:
it('should...', () => {
verifyArrowKeyNavigation('ArrowUp', 'ArrowDown');
});
it('should...', () => {
verifyArrowKeyNavigation('Up', 'Down');
});
|
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 7882962 (Please note that this is a fully automated comment.) |
|
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 40903c7 (Please note that this is a fully automated comment.) |
…aud#1535 (blackbaud#1652)" This reverts commit 349a5d4.
This allows the 'up' and 'down' key events to trigger dropdown actions like the 'arrowup' and 'arrowdown' already do. Fixes issue #1535