Fix tabset index out of order #1738
Conversation
src/modules/tabs/tab.component.ts
Outdated
| @@ -41,7 +40,7 @@ export class SkyTabComponent implements OnDestroy, AfterViewInit, OnChanges { | |||
|
|
|||
| constructor(private tabsetService: SkyTabsetService, private ref: ChangeDetectorRef) {} | |||
|
|
|||
| public ngAfterViewInit() { | |||
| public skyAfterContentInit() { | |||
There was a problem hiding this comment.
If we're going to rename this method, can we rename it to something more meaningful, to describe what it's doing? Below, there's a comment that says, "initialize each tab's index"...Maybe something to that effect?
There was a problem hiding this comment.
That would be good. I honestly wasn't sure what to name it and figured I would leave it up to review 😛 sorry, I probably should have just messaged you at the time
Codecov Report
@@ Coverage Diff @@
## master #1738 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 410 410
Lines 8530 8531 +1
Branches 1252 1252
=======================================
+ Hits 8529 8530 +1
Misses 1 1
Continue to review full report at Codecov.
|
|
@blackbaud-conorwright We need a unit test to confirm this behavior is now working. Thank you! |
|
test added |
Things like *ngIf cause certain tabs to be loaded before others messing up the automatic tabIndexes.
I changed the init function to be triggered by the parent instead so that they are only executed in display order.
Resolves: #1357