added labels and ids to section form tabs

[blackbaud-conorwright]

Added missing aria labels and ids to section form tablist, tabs, and tabpanels

Resolves: #1375

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@e6b7e54). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master   #1798   +/-   ##
========================================
  Coverage          ?    100%           
========================================
  Files             ?     425           
  Lines             ?    9122           
  Branches          ?    1349           
========================================
  Hits              ?    9122           
  Misses            ?       0           
  Partials          ?       0

Impacted Files	Coverage Δ
...sectioned-form/sectioned-form-section.component.ts	100% <100%> (ø)
...modules/sectioned-form/sectioned-form.component.ts	100% <100%> (ø)
.../modules/vertical-tabset/vertical-tab.component.ts	100% <100%> (ø)
...dules/vertical-tabset/vertical-tabset.component.ts	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b7e54...c81f6ca. Read the comment docs.

[Blackbaud-SteveBrush]

Should we rethink how we're adding these attributes? In the sectioned form template, this works, but what if a consumer implements the vertical tab by itself? I'm assuming we'd want the same roles, etc. applied automatically?

[blackbaud-conorwright]

I'm not sure. I definitely see role="tab" being there, but then we would probably want them to set their own controls. Hmm, I'll switch these to being on the content of a verticaly tab and take them as input on it

[blackbaud-conorwright]

@Blackbaud-SteveBrush I've moved the attributes to be inputs on the vertical tab, including ID. Let me know what you think when you get the chance

[blackbaud-conorwright]

Actually, hold off. This is failing for a lying accessibility issue 😕
I'm currently trying to fix it

[blackbaud-johnly]

Created #1840 to document the new properties.

[blackbaud-conorwright]

@Blackbaud-SteveBrush Alright, I think I finally got this one. I also have the roles and labelled by gets/sets set up to be inputs if we want that on section-forms, but I'm not so sure we want that since we control those elements and will always ensure their association (contained within the component template)

[Blackbaud-TrevorBurch]

LGTM