This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 65
Added arrowkey navigation to modals #1809
Merged
blackbaud-conorwright
merged 13 commits into
master
from
fix-modals-allow-arrowkey-scrolling
Sep 14, 2018
Merged
Added arrowkey navigation to modals #1809
blackbaud-conorwright
merged 13 commits into
master
from
fix-modals-allow-arrowkey-scrolling
Sep 14, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1809 +/- ##
=======================================
Coverage 100% 100%
=======================================
Files 424 416 -8
Lines 8980 8765 -215
Branches 1328 1294 -34
=======================================
- Hits 8980 8765 -215
Continue to review full report at Codecov.
|
@blackbaud-conorwright I honestly don't know how screen readers would react to this. This seems like something to set up and test via keyboard and then with screen readers (JAWS in particular as that is the one we seem to be getting customer complaints and questions about). |
Blackbaud-SteveBrush
changed the title
[HOLD] added arrowkey navigation to modals
Added arrowkey navigation to modals
Aug 10, 2018
blackbaud-conorwright
added
Status: Ready for review
and removed
Status: On hold
labels
Aug 27, 2018
blackbaud-conorwright
added
Status: In progress
and removed
Status: Ready for review
labels
Aug 27, 2018
blackbaud-conorwright
added
Status: Ready for review
Status: In progress
and removed
Status: In progress
Status: Ready for review
labels
Sep 6, 2018
Blackbaud-TrevorBurch
approved these changes
Sep 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
blackbaud-conorwright
deleted the
fix-modals-allow-arrowkey-scrolling
branch
September 14, 2018 15:05
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowed and defaulted focus to the modal-content region for arrow key scrolling. Also added the role=region and aria-labelledby for proper aria labeling.
Resolves: #1479