Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Added arrowkey navigation to modals #1809

Merged
merged 13 commits into from
Sep 14, 2018

Conversation

blackbaud-conorwright
Copy link
Contributor

@blackbaud-conorwright blackbaud-conorwright commented Jul 6, 2018

Allowed and defaulted focus to the modal-content region for arrow key scrolling. Also added the role=region and aria-labelledby for proper aria labeling.

Resolves: #1479

@codecov-io
Copy link

codecov-io commented Jul 6, 2018

Codecov Report

Merging #1809 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #1809    +/-   ##
=======================================
  Coverage     100%    100%            
=======================================
  Files         424     416     -8     
  Lines        8980    8765   -215     
  Branches     1328    1294    -34     
=======================================
- Hits         8980    8765   -215
Impacted Files Coverage Δ
src/modules/modal/modal.component.ts 100% <100%> (ø) ⬆️
src/modules/radio/radio.component.ts 100% <0%> (ø) ⬆️
src/modules/text-expand/text-expand.component.ts 100% <0%> (ø) ⬆️
src/modules/checkbox/checkbox.component.ts 100% <0%> (ø) ⬆️
src/modules/flyout/flyout.component.ts 100% <0%> (ø) ⬆️
src/modules/wait/wait.module.ts 100% <0%> (ø) ⬆️
...modules/list-view-grid/list-view-grid.component.ts 100% <0%> (ø) ⬆️
src/modules/grid/grid.module.ts 100% <0%> (ø) ⬆️
src/modules/radio/radio.module.ts 100% <0%> (ø) ⬆️
...-expand-repeater/text-expand-repeater.component.ts 100% <0%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf6b03...2ec059b. Read the comment docs.

@Blackbaud-MattGregg
Copy link
Contributor

@blackbaud-conorwright I honestly don't know how screen readers would react to this. This seems like something to set up and test via keyboard and then with screen readers (JAWS in particular as that is the one we seem to be getting customer complaints and questions about).

@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the title [HOLD] added arrowkey navigation to modals Added arrowkey navigation to modals Aug 10, 2018
Copy link
Member

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blackbaud-conorwright blackbaud-conorwright merged commit 8b26e2a into master Sep 14, 2018
@blackbaud-conorwright blackbaud-conorwright deleted the fix-modals-allow-arrowkey-scrolling branch September 14, 2018 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants