This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Tab demo clarity, tabIndex bugfix #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1878 +/- ##
======================================
Coverage 100% 100%
======================================
Files 414 414
Lines 8640 8642 +2
Branches 1278 1279 +1
======================================
+ Hits 8640 8642 +2
Continue to review full report at Codecov.
|
|
Also addresses #1631 |
blackbaud-conorwright
suggested changes
Aug 6, 2018
| (newTab)="addTabClick()" | ||
| (openTab)="openTabClick()" | ||
| [active]="activeTabIndex2" | ||
| (activeChange)="tabChanged($event)"> |
There was a problem hiding this comment.
Can you reorder these so that [active] is first?
[active]
(activeChange)
(newTab)
(openTab)
2nd comment: #1647
blackbaud-conorwright
approved these changes
Aug 8, 2018
This was referenced Aug 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1705
Based on consumer feedback, we have determined the tabs demo could be expanded a bit more to provide better examples of how to utilize the component. @blackbaud-johnly is working on the documentation for this in a separate issue #1868 .
This changes the following: