This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Popover z-index set to 1001 #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-TrevorBurch
approved these changes
Aug 21, 2018
|
LGTM |
Blackbaud-TrevorBurch
added
Status: Ready to merge
and removed
Status: Ready for review
labels
Codecov Report
@@ Coverage Diff @@
## master #1926 +/- ##
======================================
Coverage 100% 100%
======================================
Files 416 416
Lines 8757 8757
Branches 1292 1292
======================================
Hits 8757 8757Continue to review full report at Codecov.
|
|
Resolves #1910 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A z-index of 1001 will always make it appear on top of the omnibar (z-index 1000). This is the same approach we take with the flyout.