This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Non-visible paging component padding #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1935 +/- ##
======================================
Coverage 100% 100%
======================================
Files 422 422
Lines 8993 8993
Branches 1332 1332
======================================
Hits 8993 8993Continue to review full report at Codecov.
|
| </a> | ||
| </li> | ||
| </ul> | ||
| <div *ngIf="pageCount > 1"> |
There was a problem hiding this comment.
This certainly fixes the problem, but I don't think we need the extra div. Have you tried applying the styles to the <ul> instead of adding this extra div?
Blackbaud-TrevorBurch
assigned Blackbaud-AlexKingman and unassigned Blackbaud-TrevorBurch
Blackbaud-AlexKingman
assigned Blackbaud-TrevorBurch and unassigned Blackbaud-AlexKingman
Blackbaud-TrevorBurch
added
Status: Ready to merge
and removed
Status: Ready for review
labels
Blackbaud-TrevorBurch
added
Status: On hold
Status: In progress
and removed
Status: Ready to merge
Status: On hold
labels
Blackbaud-TrevorBurch
added
Status: Ready to merge
and removed
Status: In progress
labels
…3-extra-paging-padding-when-empty
Blackbaud-TrevorBurch
deleted the
1923-extra-paging-padding-when-empty
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1923