Make connectUrl lazy and once initialized #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Might it be possible to add some tests for that? Specifically that is always returns the same URL while conntected and that it regenerates the session_id/url on each connect? Just to prevent regressions in the future. Thanks! |
I've add the test and before update the dart SDK constraints because I was using |
|
I would rather not tighten the constraints just for unit tests. Is it possible to rewrite them so that the old constraints can be kept? Sorry for the additional effort. |
MacDeveloper1
force-pushed
the
bug/connect-url
branch
from
d778aa9
to
586c48b
Compare
|
Hi. I've removed the commit with dart constraints modifiation. |
KammererTob
approved these changes
Feb 15, 2024
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #95