-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Restructure project for single import #97
refactor: Restructure project for single import #97
Conversation
Thanks for the PR, i will have a look in the next few days. |
@Peetee06 I tried to run the tests locally, but i ran into some issues. Maybe you have guidance for this: This currently throws the following error:
If i try to use relative path for imports VSC complains (probably rightly so), that the path is not supposed to be relative.
Do you happen to know what to do with unit-tests? |
@KammererTob, thanks for reporting this. It seems like dart couldn't see, that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a comment to one file, but this affects all files with hybrid tests. Can you please adjust those? For me they threw an error while testing.
Overall this is a breaking change, right? So i guess this would land in 2.0 then.
Thanks!
@KammererTob true, this is a breaking change. Thank you for reviewing! |
Thank you. Looks good now. I will wait a few weeks if anything else comes up for a new release. I will release this as 2.0.0 then. |
Very nice! Thank you for creating this project! Happy that I got to contribute! |
This PR restructures the project to align with official Flutter recommendations.
Using the package now requires only a single import:
This makes working with
stomp_dart_client.dart
a little bit easier, because one can use things like VSCode code actions to automatically add an import to the package.One note:
I couldn't run the tests in
stomp_test.dart
locally, because thespawnHybridCode
method doesn't use the project's.dart_tool
folder but rather a global one. The global one does not have the necessary packages installed, which is why the hybrid code can't be run. I couldn't find a way to fix this other than installing the necessary packages globally, which I don't want to do.Please let me know if any further adjustments are desired. I'll be happy to fine-tune this PR further.