Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baddns enhance #1762

Merged
merged 42 commits into from
Oct 2, 2024
Merged

Baddns enhance #1762

merged 42 commits into from
Oct 2, 2024

Conversation

liquidsec
Copy link
Collaborator

@liquidsec liquidsec commented Sep 10, 2024

  • Changing Default module / module selection system
  • Implement direct-detection on storage buckets domains
  • Implement direct-detection on cloudflare protected domains

@liquidsec liquidsec marked this pull request as draft September 10, 2024 20:58
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 88.28125% with 15 lines in your changes missing coverage. Please review.

Project coverage is 93%. Comparing base (41920b7) to head (de4809e).
Report is 43 commits behind head on dev.

Files with missing lines Patch % Lines
bbot/modules/baddns_direct.py 83% 10 Missing ⚠️
bbot/modules/baddns.py 83% 5 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev   #1762    +/-   ##
======================================
- Coverage     93%     93%    -0%     
======================================
  Files        346     348     +2     
  Lines      27058   27166   +108     
======================================
+ Hits       24990   25071    +81     
- Misses      2068    2095    +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liquidsec liquidsec marked this pull request as ready for review September 29, 2024 22:30
@liquidsec
Copy link
Collaborator Author

@TheTechromancer wafw00f tests currently failing on this branch, makes no sense at all.

2024-09-29T23:04:20.8217137Z ERROR    bbot.scanner:scanner.py:1290 Error in wafw00f.handle_event(URL("http://127.0.0.1:8888/", module=httpx, tags={'in-scope', 'dir', 'status-200', 'ip-127-0-0-1'})): /opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/abc.py:123:__subclasscheck__(): maximum recursion depth exceeded
2024-09-29T23:04:20.8217389Z TRACE    bbot.scanner:scanner.py:1291 Traceback (most recent call last):
2024-09-29T23:04:20.8217763Z   File "/home/runner/work/bbot/bbot/bbot/scanner/scanner.py", line 1267, in _acatch
2024-09-29T23:04:20.8217927Z     yield
2024-09-29T23:04:20.8218243Z   File "/home/runner/work/bbot/bbot/bbot/modules/base.py", line 637, in _worker
2024-09-29T23:04:20.8218370Z     await self.handle_event(event)
2024-09-29T23:04:20.8218714Z   File "/home/runner/work/bbot/bbot/bbot/modules/wafw00f.py", line 44, in handle_event
2024-09-29T23:04:20.8219048Z     WW = await self.helpers.run_in_executor(wafw00f_main.WAFW00F, url, followredirect=False)
2024-09-29T23:04:20.8219489Z   File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/concurrent/futures/thread.py", line 58, in run
2024-09-29T23:04:20.8219646Z     result = self.fn(*self.args, **self.kwargs)
2024-09-29T23:04:20.8220313Z   File "/home/runner/.cache/pypoetry/virtualenvs/bbot-pd-UZ8Fz-py3.10/lib/python3.10/site-packages/wafw00f/main.py", line 42, in __init__
2024-09-29T23:04:20.8220444Z     self.rq = self.normalRequest()
2024-09-29T23:04:20.8221124Z   File "/home/runner/.cache/pypoetry/virtualenvs/bbot-pd-UZ8Fz-py3.10/lib/python3.10/site-packages/wafw00f/main.py", line 45, in normalRequest
2024-09-29T23:04:20.8221242Z     return self.Request()
2024-09-29T23:04:20.8221924Z   File "/home/runner/.cache/pypoetry/virtualenvs/bbot-pd-UZ8Fz-py3.10/lib/python3.10/site-packages/wafw00f/lib/evillib.py", line 77, in Request
2024-09-29T23:04:20.8222227Z     req = requests.get(self.target, proxies=self.proxies, headers=h, timeout=timeout,
2024-09-29T23:04:20.8222845Z   File "/home/runner/.cache/pypoetry/virtualenvs/bbot-pd-UZ8Fz-py3.10/lib/python3.10/site-packages/requests/api.py", line 73, in get
2024-09-29T23:04:20.8223022Z     return request("get", url, params=params, **kwargs)
2024-09-29T23:04:20.8223677Z   File "/home/runner/.cache/pypoetry/virtualenvs/bbot-pd-UZ8Fz-py3.10/lib/python3.10/site-packages/requests/api.py", line 59, in request
2024-09-29T23:04:20.8223935Z     return session.request(method=method, url=url, **kwargs)
2024-09-29T23:04:20.8224322Z   File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/functools.py", line 388, in _method
2024-09-29T23:04:20.8224588Z     return self.func(cls_or_self, *self.args, *args, **keywords)
2024-09-29T23:04:20.8224970Z   File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/functools.py", line 388, in _method
2024-09-29T23:04:20.8225165Z     return self.func(cls_or_self, *self.args, *args, **keywords)
2024-09-29T23:04:20.8225542Z   File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/functools.py", line 388, in _method
2024-09-29T23:04:20.8225741Z     return self.func(cls_or_self, *self.args, *args, **keywords)
2024-09-29T23:04:20.8225880Z   [Previous line repeated 481 more times]
2024-09-29T23:04:20.8226554Z   File "/home/runner/.cache/pypoetry/virtualenvs/bbot-pd-UZ8Fz-py3.10/lib/python3.10/site-packages/requests/sessions.py", line 589, in request
2024-09-29T23:04:20.8226687Z     resp = self.send(prep, **send_kwargs)
2024-09-29T23:04:20.8227450Z   File "/home/runner/.cache/pypoetry/virtualenvs/bbot-pd-UZ8Fz-py3.10/lib/python3.10/site-packages/requests/sessions.py", line 703, in send
2024-09-29T23:04:20.8227586Z     r = adapter.send(request, **kwargs)
2024-09-29T23:04:20.8227966Z   File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/functools.py", line 388, in _method
2024-09-29T23:04:20.8228167Z     return self.func(cls_or_self, *self.args, *args, **keywords)
2024-09-29T23:04:20.8228556Z   File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/functools.py", line 388, in _method
2024-09-29T23:04:20.8228816Z     return self.func(cls_or_self, *self.args, *args, **keywords)
2024-09-29T23:04:20.8229199Z   File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/functools.py", line 388, in _method
2024-09-29T23:04:20.8229397Z     return self.func(cls_or_self, *self.args, *args, **keywords)
2024-09-29T23:04:20.8229533Z   [Previous line repeated 481 more times]
2024-09-29T23:04:20.8230194Z   File "/home/runner/.cache/pypoetry/virtualenvs/bbot-pd-UZ8Fz-py3.10/lib/python3.10/site-packages/requests/adapters.py", line 667, in send
2024-09-29T23:04:20.8230317Z     resp = conn.urlopen(
2024-09-29T23:04:20.8231085Z   File "/home/runner/.cache/pypoetry/virtualenvs/bbot-pd-UZ8Fz-py3.10/lib/python3.10/site-packages/urllib3/connectionpool.py", line 750, in urlopen
2024-09-29T23:04:20.8231327Z     headers = headers.copy()  # type: ignore[attr-defined]
2024-09-29T23:04:20.8231983Z   File "/home/runner/.cache/pypoetry/virtualenvs/bbot-pd-UZ8Fz-py3.10/lib/python3.10/site-packages/requests/structures.py", line 77, in copy
2024-09-29T23:04:20.8232152Z     return CaseInsensitiveDict(self._store.values())
2024-09-29T23:04:20.8232840Z   File "/home/runner/.cache/pypoetry/virtualenvs/bbot-pd-UZ8Fz-py3.10/lib/python3.10/site-packages/requests/structures.py", line 44, in __init__
2024-09-29T23:04:20.8232944Z     self.update(data, **kwargs)
2024-09-29T23:04:20.8233349Z   File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/_collections_abc.py", line 997, in update
2024-09-29T23:04:20.8233464Z     if isinstance(other, Mapping):
2024-09-29T23:04:20.8233869Z   File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/abc.py", line 119, in __instancecheck__
2024-09-29T23:04:20.8234007Z     return _abc_instancecheck(cls, instance)
2024-09-29T23:04:20.8234400Z   File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/abc.py", line 123, in __subclasscheck__
2024-09-29T23:04:20.8234527Z     return _abc_subclasscheck(cls, subclass)
2024-09-29T23:04:20.8234919Z   File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/abc.py", line 123, in __subclasscheck__
2024-09-29T23:04:20.8235048Z     return _abc_subclasscheck(cls, subclass)
2024-09-29T23:04:20.8235201Z RecursionError: maximum recursion depth exceeded

@TheTechromancer TheTechromancer merged commit f1a18ee into dev Oct 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants