Live player fixes #13143
Merged
Live player fixes #13143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on dashboard only
✅ Deploy Preview for frigate-docs canceled.
|
NickM-27
approved these changes
Aug 17, 2024
NickM-27
pushed a commit
that referenced
this pull request
Aug 30, 2024
* Jump to live when exceeding buffer time threshold in MSE player * clean up * Try adjusting playback rate instead of jumping to live * clean up * fallback to webrtc if enabled before jsmpeg * baseline * clean up * remove comments * adaptive playback rate and intelligent switching improvements * increase logging and reset live mode after camera is no longer active on dashboard only * jump to live on safari/iOS * clean up * clean up * refactor camera live mode hook * remove key listener * resolve conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
playbackRatecauses Safari/iOS to re-buffer), all other browsers will dynamically increase playback rate based on a rolling average of buffer time.candidatesdefined in their go2rtc config for fallback to occur. If WebRTC is configured but fails, fallback to jsmpeg occurs. This particular behavior is for single camera live views only. Dashboard cameras streaming MSE will always fall back to jsmpeg to preserve bandwidth.useCameraLiveModehook to reset intelligently selected live mode back to default when camera goes inactive if the mode was changed because of an error during playbackThis code has been tested by users and found to work well. It resolves the issues in #13064, #13126, and #13047