Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention that AMD CPUs work just fine with OpenVINO #9740

Merged
merged 2 commits into from
Feb 10, 2024

Conversation

svenstaro
Copy link
Contributor

Also fixed some inconsistencies.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit 0c49a01
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/65c4d4e4be72630008cbf7bd
😎 Deploy Preview https://deploy-preview-9740--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@svenstaro svenstaro force-pushed the patch-1 branch 2 times, most recently from 466951e to 577669c Compare February 8, 2024 02:24
Copy link
Collaborator

@NickM-27 NickM-27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some adjustments that should go in but in any case I am not sure if this makes sense to merge. We don't have a full understanding of what AMD CPUs are supported by openvino and it is not officially supported so I am not sure if that will be good to recommend.

docs/docs/configuration/object_detectors.md Outdated Show resolved Hide resolved
docs/docs/configuration/object_detectors.md Outdated Show resolved Hide resolved
docs/docs/frigate/hardware.md Outdated Show resolved Hide resolved
docs/docs/frigate/hardware.md Outdated Show resolved Hide resolved
@svenstaro
Copy link
Contributor Author

Everything fixed and rebased all nicely!

@svenstaro
Copy link
Contributor Author

Are we good to merge this or are you skeptical that this shouldn't be documented at all? I believe it's still worth pointing out because I was using the CPU detector before as I didn't think my AMD CPU would work with OpenVINO and now I'm enjoying way higher detection FPS. Maybe some other users are in my situation. I realize the situation will be somewhat improved by #9762 but I think it's nice to have options.

@NickM-27
Copy link
Collaborator

NickM-27 commented Feb 9, 2024

It still needs to be reviewed by Blake, then he will merge it

@blakeblackshear blakeblackshear merged commit 54bbad1 into blakeblackshear:master Feb 10, 2024
10 checks passed
@svenstaro svenstaro deleted the patch-1 branch February 10, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants