Bugfix not passing options recursively #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the catch! Would you be interested in adding a small test case? |
|
@blakeembrey there you go 😁 test successfully fails without the patch |
|
@blakeembrey I reworked a tiny bit how options per-test are stored, I think it's easier to add and maintain future tests this way. |
|
Awesome, thanks! |
renovate bot
referenced
this pull request
in simonknittel/sinister-incorporated
Feb 21, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [change-case](https://togithub.com/blakeembrey/change-case/tree/master/packages/change-case#readme) ([source](https://togithub.com/blakeembrey/change-case)) | [`5.4.2` -> `5.4.3`](https://renovatebot.com/diffs/npm/change-case/5.4.2/5.4.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>blakeembrey/change-case (change-case)</summary> ### [`v5.4.3`](https://togithub.com/blakeembrey/change-case/releases/tag/change-case%405.4.3): Fix recursive options in keys change case [Compare Source](https://togithub.com/blakeembrey/change-case/compare/[email protected]) **Fixed** - Fixes options used recursively in `change-case/keys` - previously options were ignored after the first level [https://github.com/blakeembrey/change-case/pull/334](https://togithub.com/blakeembrey/change-case/pull/334) by [@​Quicksaver](https://togithub.com/Quicksaver) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/simonknittel/sinister-incorporated). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in runtime-env/import-meta-env
Jul 6, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [change-case](https://togithub.com/blakeembrey/change-case/tree/master/packages/change-case#readme) ([source](https://togithub.com/blakeembrey/change-case)) | [`5.1.2` -> `5.4.4`](https://renovatebot.com/diffs/npm/change-case/5.1.2/5.4.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>blakeembrey/change-case (change-case)</summary> ### [`v5.4.4`](https://togithub.com/blakeembrey/change-case/compare/[email protected]) [Compare Source](https://togithub.com/blakeembrey/change-case/compare/[email protected]@5.4.4) ### [`v5.4.3`](https://togithub.com/blakeembrey/change-case/releases/tag/change-case%405.4.3): Fix recursive options in keys change case [Compare Source](https://togithub.com/blakeembrey/change-case/compare/[email protected]) **Fixed** - Fixes options used recursively in `change-case/keys` - previously options were ignored after the first level [https://github.com/blakeembrey/change-case/pull/334](https://togithub.com/blakeembrey/change-case/pull/334) by [@​Quicksaver](https://togithub.com/Quicksaver) ### [`v5.4.2`](https://togithub.com/blakeembrey/change-case/compare/[email protected]) [Compare Source](https://togithub.com/blakeembrey/change-case/compare/[email protected]) ### [`v5.4.1`](https://togithub.com/blakeembrey/change-case/releases/tag/change-case%405.4.1): Remove regex lookbehind [Compare Source](https://togithub.com/blakeembrey/change-case/compare/[email protected]@5.4.1) **Fixed** - Remove lookbehind from regex for older browser support (blakeembrey/change-case@6512635) ### [`v5.4.0`](https://togithub.com/blakeembrey/change-case/releases/tag/change-case%405.4.0): Add `split` option to `change-case` [Compare Source](https://togithub.com/blakeembrey/change-case/compare/[email protected]@5.4.0) **Added** - Added a `split` option to the `change-case` transform functions to allow for customization on how words are extracted from input **Changed** - The package exports are now `default` instead of `import` to fix some tooling that doesn't work properly with `import` - The exported `split` utility no longer accepts a second options argument ### [`v5.3.0`](https://togithub.com/blakeembrey/change-case/releases/tag/change-case%405.3.0): Add `suffixCharacters` option [Compare Source](https://togithub.com/blakeembrey/change-case/compare/[email protected]@5.3.0) **Added** - New `suffixCharacters` option to retain characters during case conversion. Useful for retaining something like the `_` in `type_`. Closes [https://github.com/blakeembrey/change-case/issues/322](https://togithub.com/blakeembrey/change-case/issues/322). ### [`v5.2.0`](https://togithub.com/blakeembrey/change-case/releases/tag/change-case%405.2.0): New `delimiter` and `mergeAmbiguousCharacters` options [Compare Source](https://togithub.com/blakeembrey/change-case/compare/[email protected]) **Added** - Add `delimiter` option for customizing join character in any change case method - Add `mergeAmbiguousCharacters` for camel and pascal case to avoid prefixing `_` before numbers </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/runtime-env/import-meta-env). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title says, options were not being passed recursively in
changeKeys.