Skip to content

Commit

Permalink
Remove unused variables in faiss/impl/HNSW.cpp
Browse files Browse the repository at this point in the history
Summary:
LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: algoriddle

Differential Revision: D52981042

fbshipit-source-id: 6748dc957a26a6b5dec3922505c18a1996e3a002
  • Loading branch information
r-barnes authored and facebook-github-bot committed Jan 23, 2024
1 parent b274cb4 commit a70a8a5
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions faiss/impl/HNSW.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -851,13 +851,11 @@ HNSWStats HNSW::search(
top_candidates.pop();
}

int nres = 0;
while (!top_candidates.empty()) {
float d;
storage_idx_t label;
std::tie(d, label) = top_candidates.top();
res.add_result(d, label);
nres++;
top_candidates.pop();
}
}
Expand Down

0 comments on commit a70a8a5

Please sign in to comment.