MB-60202 - IDMap2 Selector #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metonymic-smokey
force-pushed
the
idmap-sel
branch
from
d9a1212
to
50990d8
Compare
metonymic-smokey
requested review from
abhinavdangeti,
Thejas-bhat,
CascadingRadium,
Likith101 and
moshaad7
abhinavdangeti
requested changes
Jan 11, 2024
Summary: Pull Request resolved: facebookresearch#2848 Add selector support for IDMap wrapped indices. Caveat: this requires to wrap the IDSelector with another selector. Since the params are const, the const is casted away. This is a problem if the same params are used from multiple execution threads with different selectors. However, this seems rare enough to take the risk. Reviewed By: alexanderguzhva Differential Revision: D45598823 fbshipit-source-id: ec23465c13f1f8273a6a46f9aa869ccae2cdb79c
metonymic-smokey
force-pushed
the
idmap-sel
branch
from
50990d8
to
2a5c889
Compare
abhinavdangeti
approved these changes
Jan 12, 2024
CascadingRadium
pushed a commit
that referenced
this pull request
Aug 16, 2024
* Support Selector for IDMap (facebookresearch#2848) Summary: Pull Request resolved: facebookresearch#2848 Add selector support for IDMap wrapped indices. Caveat: this requires to wrap the IDSelector with another selector. Since the params are const, the const is casted away. This is a problem if the same params are used from multiple execution threads with different selectors. However, this seems rare enough to take the risk. Reviewed By: alexanderguzhva Differential Revision: D45598823 fbshipit-source-id: ec23465c13f1f8273a6a46f9aa869ccae2cdb79c * added C API helper func --------- Co-authored-by: Matthijs Douze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR