MB-61719: Windows requires index variable in an OpenMP for to be signed #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavdangeti
requested review from
metonymic-smokey,
CascadingRadium,
Likith101,
Thejas-bhat and
moshaad7
abhinavdangeti
force-pushed
the
win_size_t
branch
2 times, most recently
from
3897b73
to
12719c3
Compare
|
It seems we can get around this issue by using clang instead of msvc. |
abhinavdangeti
force-pushed
the
win_size_t
branch
from
12719c3
to
145ed8c
Compare
| for (size_t i = 0; i < nx_p; i += NX_POINTS_PER_LOOP) { | ||
| // use signed instead of size_t because of C3016 error on windows: | ||
| // https://learn.microsoft.com/en-us/cpp/error-messages/compiler-errors-2/compiler-error-c3016 | ||
| for (ssize_t i = 0; i < nx_p; i += (ssize_t)NX_POINTS_PER_LOOP) { |
There was a problem hiding this comment.
this works if ssize_t is defined and available (it is non standard)
pls refer to facebook/faiss commit facebookresearch#2889
that fixed the same issue in another file
| } | ||
|
|
||
| for (size_t i = nx_p; i < nx; i++) { | ||
| for (ssize_t i = nx_p; i < (ssize_t)nx; i++) { |
There was a problem hiding this comment.
it is not required to add any changes to this line as
pragma omp for only applies to the immediate next for loop (which is the one above)
this for loop is not under openmp
|
We won't be needing this anymore, as we're pivoting to using clang to compile windows builds - which fixes the compilation error called out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://learn.microsoft.com/en-us/cpp/error-messages/compiler-errors-2/compiler-error-c3016?view=msvc-170