Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checksum mismatch in go sumdb #13

Closed
chrisdoherty4 opened this issue Mar 25, 2022 · 11 comments
Closed

Checksum mismatch in go sumdb #13

chrisdoherty4 opened this issue Mar 25, 2022 · 11 comments

Comments

@chrisdoherty4
Copy link

chrisdoherty4 commented Mar 25, 2022

I haven't quite worked out the issue but there seems to be a checksum mismatch in the Google sumdb. Raising some initial awareness with this ticket.

Relates to golangci/golangci-lint#2683

$ GOPROXY=direct go get github.com/blizzy78/[email protected]
go: downloading github.com/blizzy78/varnamelen v0.6.1
go: github.com/blizzy78/[email protected]: verifying module: checksum mismatch
        downloaded: h1:iYAU/3A6cpfRm2ZI0P/lece4jsc7GEbzsxTu+vBCChQ=
        sum.golang.org: h1:kttPCLzXFa+0nt++Cw9fb7GrSSM4KkyIAoX/vXsbuqA=

SECURITY ERROR
This download does NOT match the one reported by the checksum server.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

For more information, see 'go help module-auth'.
@blizzy78
Copy link
Owner

This is totally my fault. I had initially tagged varnamelen v0.6.1, then realized I forgot some things, removed the tag and put it on a later commit. All while hoping that I would be quick enough, which it seems I wasn't :-(

@chrisdoherty4
Copy link
Author

@blizzy78 I suspected as much, no worries. I don't know that it would've helped you, but you might consider leveraging -beta additions to the version string to test things out etc.

@chrisdoherty4
Copy link
Author

chrisdoherty4 commented Mar 25, 2022

@blizzy78 FWIW this is a really neat little package! Great problem to bring attention to/solve.

@chrisdoherty4
Copy link
Author

Also https://go.dev/ref/mod#go-mod-file-retract would be useful to configure.

@blizzy78
Copy link
Owner

Thanks for the suggestions, I'll look into those.

As for the initial idea to varnamelen, praise probably needs to go to my co-worker @Baret. I've implemented it in code and expanded upon it.

slimsag added a commit to sourcegraph/doctree that referenced this issue Apr 20, 2022
Workaround for an issue in golangci-lint:

```
go: warning: github.com/blizzy78/[email protected]: retracted by module author: see blizzy78/varnamelen#13, use 0.6.2 or later instead
go: to switch to the latest unretracted version, run:
	go get github.com/blizzy78/varnamelen@latest
```

Signed-off-by: Stephen Gutekanst <[email protected]>
madrisan added a commit to madrisan/go-mattermost-notify that referenced this issue May 9, 2022
Manually fix the hash of the package github.com/blizzy78/varnamelen v0.6.1
See: blizzy78/varnamelen#13

The problem was fixed in v0.6.2 but golangci-lint requires v0.6.1.
madrisan added a commit to madrisan/go-mattermost-notify that referenced this issue May 9, 2022
Manually fix the hash of the package github.com/blizzy78/varnamelen v0.6.1
See: blizzy78/varnamelen#13

The problem was fixed in v0.6.2 but golangci-lint requires v0.6.1.

Signed-off-by: Davide Madrisan <[email protected]>
@baryluk
Copy link

baryluk commented May 10, 2022

Was hit by this today on a new machine, with go.sum created on other machine just about 2 weeks ago:

verifying github.com/blizzy78/[email protected]/go.mod: checksum mismatch
	downloaded: h1:mGBHm+Uo4e8JnZEKHRoZgVEOQdSBdQfY/x+k4NAXBWA=
	go.sum:     h1:zy2Eic4qWqjrxa60jG34cfL0VXcSwzUrIx68eJPb4Q8=

@chrisdoherty4
Copy link
Author

chrisdoherty4 commented May 10, 2022

@baryluk Upgrade to 0.6.2. If you're receiving this due to a transitive dependency on varnamelen then the root project needs to upgrade varnamelen to 0.6.2 or later.

There are no behavioral differences between 0.6.1 and 0.6.2.

@blizzy78
Copy link
Owner

Just to note, the latest version is 0.8.0, so you might want to upgrade to that instead.

@baryluk
Copy link

baryluk commented May 11, 2022

It is a transitive dependency. Not sure through of what (I do not understand Go modules too well).

I think via github.com/golangci/[email protected], but I have no idea why it is being installed by anything that I depend on. Maybe I installed it, and it become the dependency of the project, while it isn't.

But I noticed that my go.mod already references only 0.8.0 // indirect, so I just removed the 0.6.1 from the go.sum. I guess go.sum had some old info from previous state of that indirect dependency, and go get -u updated it to 0.8.0, but kept the old 0.6.1 still there. I also removed the [email protected] , re updated dependencies, and it started working.

@blizzy78
Copy link
Owner

blizzy78 commented May 11, 2022

You may want to run go mod tidy in your project.

@baryluk
Copy link

baryluk commented May 11, 2022

You may want to run go mod tidy in your project.

Cool. Thanks!

Before

$ wc -l go.mod go.sum 
    77 go.mod
  1947 go.sum

After go mod tidy:

$ wc -l go.mod go.sum 
   39 go.mod
  947 go.sum

cippaciong added a commit to DataHow/argo-cd that referenced this issue May 18, 2022
Because:

* Installation of golangci-lint v1.45.2 is currently broken and fails
  silently due to a redacted dependency
  (blizzy78/varnamelen#13)

This commit:

* Upgrades golangci-lint to v1.46.2

Signed-off-by: Tommaso Sardelli <[email protected]>
crenshaw-dev added a commit to argoproj/argo-cd that referenced this issue May 19, 2022
* chore: upgrade golangci-lint to v1.46.2

Because:

* Installation of golangci-lint v1.45.2 is currently broken and fails
  silently due to a redacted dependency
  (blizzy78/varnamelen#13)

This commit:

* Upgrades golangci-lint to v1.46.2

Signed-off-by: Tommaso Sardelli <[email protected]>

* fix: lint

Signed-off-by: Michael Crenshaw <[email protected]>

* fix: lint

Signed-off-by: Tommaso Sardelli <[email protected]>

Co-authored-by: Michael Crenshaw <[email protected]>
crenshaw-dev added a commit to argoproj/argo-cd that referenced this issue Jun 13, 2022
* chore: upgrade golangci-lint to v1.46.2

Because:

* Installation of golangci-lint v1.45.2 is currently broken and fails
  silently due to a redacted dependency
  (blizzy78/varnamelen#13)

This commit:

* Upgrades golangci-lint to v1.46.2

Signed-off-by: Tommaso Sardelli <[email protected]>

* fix: lint

Signed-off-by: Michael Crenshaw <[email protected]>

* fix: lint

Signed-off-by: Tommaso Sardelli <[email protected]>

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
crenshaw-dev added a commit to argoproj/argo-cd that referenced this issue Jun 13, 2022
* chore: upgrade golangci-lint to v1.46.2

Because:

* Installation of golangci-lint v1.45.2 is currently broken and fails
  silently due to a redacted dependency
  (blizzy78/varnamelen#13)

This commit:

* Upgrades golangci-lint to v1.46.2

Signed-off-by: Tommaso Sardelli <[email protected]>

* fix: lint

Signed-off-by: Michael Crenshaw <[email protected]>

* fix: lint

Signed-off-by: Tommaso Sardelli <[email protected]>

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
crenshaw-dev added a commit to argoproj/argo-cd that referenced this issue Jun 14, 2022
* chore: upgrade golangci-lint to v1.46.2

Because:

* Installation of golangci-lint v1.45.2 is currently broken and fails
  silently due to a redacted dependency
  (blizzy78/varnamelen#13)

This commit:

* Upgrades golangci-lint to v1.46.2

Signed-off-by: Tommaso Sardelli <[email protected]>

* fix: lint

Signed-off-by: Michael Crenshaw <[email protected]>

* fix: lint

Signed-off-by: Tommaso Sardelli <[email protected]>

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
sujeilyfonseca added a commit to sujeilyfonseca/argo-cd that referenced this issue Jul 7, 2022
* fix(ui): Applications page incorrectly resets to tiles view. Fixes argoproj#8702 (argoproj#8718)

Signed-off-by: Yuan Tang <[email protected]>

* fix: correct jsonnet paths resolution (argoproj#8721)

Signed-off-by: Alexander Matyushentsev <[email protected]>

* chore: Bump stable version of application set addon (argoproj#8744)

Signed-off-by: Alexander Matyushentsev <[email protected]>

* fix: Retry checkbox unchecked unexpectedly; Sync up with YAML (argoproj#8682) (argoproj#8720)

Signed-off-by: Keith Chong <[email protected]>

* Bump version to 2.3.1

* Bump version to 2.3.1

* Merge pull request from GHSA-2f5v-8r3f-8pww

* fix: application resource APIs must enforce project restrictions

Signed-off-by: Alexander Matyushentsev <[email protected]>

* Fix unit tests

Signed-off-by: jannfis <[email protected]>

Co-authored-by: jannfis <[email protected]>

* chore: remove lint-docs CI task (argoproj#8722) (argoproj#8858)

* chore: remove lint-docs CI task

Signed-off-by: Alexander Matyushentsev <[email protected]>

* chore: remove not longer necessary url-allow-list

Signed-off-by: Alexander Matyushentsev <[email protected]>

Co-authored-by: Alexander Matyushentsev <[email protected]>

* chore: fix imports (argoproj#8859)

Signed-off-by: Michael Crenshaw <[email protected]>

* Bump version to 2.3.2

* Bump version to 2.3.2

* fix: Set QPS and burst rate for resource ops client (argoproj#8915)

* fix: Set QPS and burst rate for resource ops client

Signed-off-by: jannfis <[email protected]>

* fix: prevent excessive repo-server disk usage for large repos (argoproj#8845) (argoproj#8897)

fix: prevent excessive repo-server disk usage for large repos (argoproj#8845) (argoproj#8897)

Signed-off-by: Michael Crenshaw <[email protected]>

* fix: bump gitops engine version to v0.6.2

Signed-off-by: Alexander Matyushentsev <[email protected]>

* docs: update v2.4+ roadmap items (argoproj#8593)

Signed-off-by: ishitasequeira <[email protected]>

* docs: reflect v2.3 release changes in roadmap.md (argoproj#8747)

docs: reflect v2.3 release changes in roadmap.md (argoproj#8747)

Signed-off-by: Alexander Matyushentsev <[email protected]>

* Bump version to 2.3.3

* Bump version to 2.3.3

* fix: Fix docs build error (argoproj#8895)

* work with specific jinja version

Signed-off-by: pashavictorovich <[email protected]>

* fix: fix broken monaco editor collapse icons (argoproj#8709)

Signed-off-by: Alexander Matyushentsev <[email protected]>

* chore: upgrade to go 1.17.8 (argoproj#8866) (argoproj#9004)

* chore: upgrade to go 1.17.8

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: use 1.17 so it's always latest in the series

Signed-off-by: Michael Crenshaw <[email protected]>

* fix: allow cli/ui to follow logs (argoproj#8987) (argoproj#9065)

Signed-off-by: Daniel Helfand <[email protected]>

* Merge pull request from GHSA-xmg8-99r8-jc2j

Signed-off-by: Michael Crenshaw <[email protected]>

Co-authored-by: Michael Crenshaw <[email protected]>

* Merge pull request from GHSA-6gcg-hp2x-q54h

* fix: do not allow symlinks from directory-type applications

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: add new util file

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: lint

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: use t.TempDir for simpler tests

Signed-off-by: Michael Crenshaw <[email protected]>

* address comments

Signed-off-by: Michael Crenshaw <[email protected]>

* Merge pull request from GHSA-r642-gv9p-2wjj

Signed-off-by: jannfis <[email protected]>

Co-authored-by: Michael Crenshaw <[email protected]>

Co-authored-by: Michael Crenshaw <[email protected]>

* Bump version to 2.3.4

* Bump version to 2.3.4

* test: fix ErrorContains (argoproj#9445)

Signed-off-by: Michael Crenshaw <[email protected]>

* fix: missing Helm params (argoproj#9565) (argoproj#9566)

* fix: missing Helm params

Signed-off-by: Michael Crenshaw <[email protected]>

* use absolute paths, fix tests

Signed-off-by: Michael Crenshaw <[email protected]>

* fix race in test

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: upgrade golangci-lint to v1.46.2 (argoproj#9448)

* chore: upgrade golangci-lint to v1.46.2

Because:

* Installation of golangci-lint v1.45.2 is currently broken and fails
  silently due to a redacted dependency
  (blizzy78/varnamelen#13)

This commit:

* Upgrades golangci-lint to v1.46.2

Signed-off-by: Tommaso Sardelli <[email protected]>

* fix: lint

Signed-off-by: Michael Crenshaw <[email protected]>

* fix: lint

Signed-off-by: Tommaso Sardelli <[email protected]>

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>

* fix: test race (argoproj#9469)

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: lint issues

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: update golangci-lint (argoproj#8988)

* chore: update golangci-lint

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: remove obsolete repo-server unit test (argoproj#9559)

Signed-off-by: Alexander Matyushentsev <[email protected]>

* chore: Make unit tests run on platforms other than amd64 (argoproj#8995)

Signed-off-by: jannfis <[email protected]>

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>

* chore: eliminate go-mpatch dependency (argoproj#9045)

* chore: eliminate go-mpatch dependency

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: abstract out resource list function

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: don't exit the program in anything but the main function

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: better error messages

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: better error messages

Signed-off-by: Michael Crenshaw <[email protected]>

* test: directory app manifest generation (argoproj#9503)

* test: directory app manifest generation

Signed-off-by: Michael Crenshaw <[email protected]>

* git doesn't support empty dirs

Signed-off-by: Michael Crenshaw <[email protected]>

* Merge pull request from GHSA-h4w9-6x78-8vrj

Signed-off-by: Michael Crenshaw <[email protected]>

* Merge pull request from GHSA-2m7h-86qq-fp4v

Signed-off-by: Michael Crenshaw <[email protected]>

fix references

Signed-off-by: Michael Crenshaw <[email protected]>

use long enough state param for oauth2

Signed-off-by: Michael Crenshaw <[email protected]>

typo

Signed-off-by: Michael Crenshaw <[email protected]>

more entropy

Signed-off-by: Michael Crenshaw <[email protected]>

fix test

Signed-off-by: Michael Crenshaw <[email protected]>

* Merge pull request from GHSA-q4w5-4gq2-98vm

Signed-off-by: Michael Crenshaw <[email protected]>

* Merge pull request from GHSA-jhqp-vf4w-rpwq

Signed-off-by: Michael Crenshaw <[email protected]>

defer instead of multiple close calls

Signed-off-by: Michael Crenshaw <[email protected]>

oops

Signed-off-by: Michael Crenshaw <[email protected]>

don't count jsonnet against max

Signed-off-by: Michael Crenshaw <[email protected]>

fix codegen

Signed-off-by: Michael Crenshaw <[email protected]>

add caveat about 300x ratio

Signed-off-by: Michael Crenshaw <[email protected]>

fix versions

Signed-off-by: Michael Crenshaw <[email protected]>

fix tests/lint

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: fix docs gen

Signed-off-by: Michael Crenshaw <[email protected]>

* Bump version to 2.3.5

* Bump version to 2.3.5

* docs: Changes for v2.3.5

Documented key decision factors to use Argo CD v2.3.5.

Contributes to: automation-saas/automation-saas/native-AWS#1972

Signed-off-by: Sujeily Fonseca <[email protected]>

Co-authored-by: Yuan Tang <[email protected]>
Co-authored-by: Alexander Matyushentsev <[email protected]>
Co-authored-by: Keith Chong <[email protected]>
Co-authored-by: argo-bot <[email protected]>
Co-authored-by: jannfis <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Co-authored-by: Ishita Sequeira <[email protected]>
Co-authored-by: pasha-codefresh <[email protected]>
Co-authored-by: Daniel Helfand <[email protected]>
Co-authored-by: Tommaso Sardelli <[email protected]>
vs49688 added a commit to vs49688/navidrome that referenced this issue Jul 24, 2022
vs49688 added a commit to vs49688/navidrome that referenced this issue Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants