fix(recurring buy): fixes several small design issues related to recurring buy #3467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blockdylanb
requested review from
dsisto-bc,
jjBlockchain,
milan-bc,
pedroapfilho,
plondon,
schnogz,
tbuchann and
TheLeoB
as code owners
schnogz
suggested changes
Aug 13, 2021
| @@ -182,7 +194,7 @@ const getActionText = (action: ActionEnum, date: string | number) => { | |||
| id='scenes.coin.recurringbuy.next_swap_on_date' | |||
| defaultMessage='Next Swap on {date}' | |||
| values={{ | |||
| date: moment(date).format('ddd, MMMM Do') | |||
| date: date.format('ddd, MMMM Do') | |||
There was a problem hiding this comment.
to avoid duplication of formatting strings, do the formatting once at the top of the component after line 139. then just pass as values={{ date }}
There was a problem hiding this comment.
yup makes sense. new commit incoming.
schnogz
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (optional)
Add a concise explanation of the changes.
Testing Steps (optional)
Detail the steps required for the reviewer(s) to verify and test these changes.