refactor: using bitwise operations to save gas #104

[blackbeard002]

• Changes in all the contracts for bitwise refactor done and compiled successfully.
• Fuzzing altered accordingly.
• Unit tests re-written in hardhat.

closes #104

[blackbeard002]

@0xneves Hey, ready for review.

[0xneves]

Thank you a lot @blackbeard002 !! Just a few minor improvements and I will submit the PR, I think the hardest one its the NatSpec, since it need good communication xD

LFG

[0xneves]

Could you provide a NatSpec description for this function explaining how it works?
Since the explanation should stay in the Interface contract, the implementation should be used the reference just like in the rest of the contract e.g.:

  /**
   * @dev See {ISwaplace-getSwap}.
   */

[0xneves]

This line is unnecessary as the 0 can be directly inputted in line 66 in the expiry variable of packData

[0xneves]

The file was commited using tabWidth = 4, but the correct is tabWidth = 2.

The following should follow pattern and should be changed from:

     * - `config` holds two values 'allowed' and 'expiry',packed using bitwise.  
     *       'allowed' address to accept the Swap.
     *       'expiry' date of the Swap.

To:

     * - `config` represents two packed values: 'allowed' for the allowed address 
     * to accept the swap and 'expiry' for the expiration date of the swap.

[0xneves]

Could you provide a NatSpec description for this function explaining how it works

[0xneves]

Avoid using underscores to name variables in the test file, since there is a conflict, the best method would be to rename the variables that don't resemble the contracts, for instance:

• Change _expiry into timestamp
• Keep the config expiry as expiry, since its the same inside the contract implementation

[0xneves]

Changing the expiry into configExpiry is also a go, but the first recommendation suits more the legibility.

[0xneves]

Same recommendation as the TestSwapFactory.test.ts

[blackbeard002]

Hey @0xneves I've made the changes that you requested. Ready for review.

[0xneves]

I'm approving although I had to brute force some fixes to speed up development
The test/TestSwapFactory.test.ts I'll manually fix in another issue as it's lacking legibility