-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add Solid.js support #1886
Feat: Add Solid.js support #1886
Conversation
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Thanks for so much for the PR to add SolidJs support! Any chance you could add a small example here in our examples section? |
@yisacc friendly ping on the above comments. It would be very helpful to have a SolidJS example to go along with this within the web3-onboard repo examples section. |
@yisacc we would love to get this merged - can you take a look at the failing PR checks and add a small boilerplate example to the examples folder when you have a moment? |
sure I will update it |
@Adamj1232 please do review and merge it |
@yisacc does solidjs require node version 18? The requirement in the package.json is causing issues with our build system as our minimum requirement is node v16 |
@yisacc I am still seeing the PR checks fail because of the node versioning. Please see https://github.com/blocknative/web3-onboard/actions/runs/6538139277/job/17753445603?pr=1886 |
@Adamj1232 solved |
@yisacc still seeing errors on the PR check |
@Adamj1232 i am working on it trying to solve the issues |
Now it's solved |
@yisacc thanks for that! I am doing some final testing and will add to our docs site. |
@Adamj1232 i have added example |
Description
Add solidJS support implemented solid package to enable solid reactivity when web3-onboard is used with in a solidjs codebase.
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.json
of the package you have made changes in following semantic versioning and using alpha release taggingyarn check-all
to confirm there are not any associated errorsDocs Checklist
docs/package.json
file (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn dev
to get the project running athttp://localhost:8080/
Tests with demo app (injected)
Tests with demo app (SDK)