chore: update the 'metamask-sdk' package to version '0.26.1' #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Adamj1232
reviewed
Jun 20, 2024
packages/metamask/package.json
Outdated
| @@ -60,7 +60,7 @@ | |||
| "typescript": "^5.2.2" | |||
| }, | |||
| "dependencies": { | |||
| "@metamask/sdk": "^0.20.5", | |||
| "@metamask/sdk": "^0.26.0", | |||
There was a problem hiding this comment.
The package version on line 3 needs an alpha version bump and also needs to be reflected and tested in packages/demo/package.json
There was a problem hiding this comment.
After updating the MetaMask SDK package to version 2.1.3-alpha.1, I encounter an issue when I go to the demo test dapp and try to run yarn after also updating MetaMask there to "@web3-onboard/metamask": "^2.1.3-alpha.1".
What am I missing in my setup? @Adamj1232
omridan159
changed the title
Adamj1232
reviewed
Jun 21, 2024
Adamj1232
reviewed
Jun 21, 2024
This was referenced Jun 24, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the metamask-sdk package to version '0.26.1'
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errorsDocs Checklist
docs/package.jsonfile (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn devto get the project running athttp://localhost:8080/Tests with demo app (injected)
Tests with demo app (SDK)