Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine contributing procedure #1578

Merged
merged 4 commits into from
Mar 18, 2019
Merged

Refine contributing procedure #1578

merged 4 commits into from
Mar 18, 2019

Conversation

vbaranov
Copy link
Member

Motivation

We need to collect all updates into the release. It is hard to collect them at one time, keeping in mind that release can contain tens of PRs. To be sure that all updates are added to the release, it is suggested to update CHANGELOG.md with the description of update and the link to PR for each contribution.

Changelog

  • CHANGELOG.md is added with the description of 1.3.5 release.
  • a step is added in CONTRIBUTING.md, where contributor should update CHANGELOG.md with every PR.

@ghost ghost assigned vbaranov Mar 15, 2019
@ghost ghost added the in progress label Mar 15, 2019
Copy link
Contributor

@ayrat555 ayrat555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build b028a5a4-c5bc-451e-b853-c40aeeb80476

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.79%

Totals Coverage Status
Change from base Build a350e6b0-b457-487d-9c00-af2f075f45ff: 0.0%
Covered Lines: 4285
Relevant Lines: 5114

💛 - Coveralls

@vbaranov vbaranov merged commit 3706c03 into master Mar 18, 2019
@vbaranov vbaranov deleted the contributing-changes branch March 18, 2019 13:26
@ghost ghost removed the in progress label Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants