Modifies filtering in oracle discovery to be case insensitive (but wi…

…ll return original data) (#159)
blockydevs · Jun 26, 2024 · acd2269 · acd2269
1 parent 272c620
commit acd2269
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/packages/apps/human-app/server/src/modules/oracle-discovery/oracle-discovery.service.ts b/packages/apps/human-app/server/src/modules/oracle-discovery/oracle-discovery.service.ts
@@ -81,6 +81,10 @@ export class OracleDiscoveryService {
     oracleJobTypes: string[],
     requiredJobTypes: string[],
   ) {
-    return oracleJobTypes.some((job) => requiredJobTypes.includes(job));
+    return oracleJobTypes.some((job) =>
+      requiredJobTypes
+        .map((requiredJob) => requiredJob.toLowerCase())
+        .includes(job.toLowerCase()),
+    );
   }
 }
diff --git a/packages/apps/human-app/server/src/modules/oracle-discovery/spec/oracle-discovery.fixture.ts b/packages/apps/human-app/server/src/modules/oracle-discovery/spec/oracle-discovery.fixture.ts
@@ -14,7 +14,12 @@ export function generateOracleDiscoveryResponseBody() {
     role: 'role2',
     jobTypes: ['job-type-1', 'job-type-3', 'job-type-4'],
   };
-  return [response1, response2];
+  const response3: OracleDiscoveryResponse = {
+    address: '0xd83422155c058D78e4D5fB5f50E125F06eb39d',
+    role: 'role3',
+    jobTypes: ['Job-Type-2'],
+  }
+  return [response1, response2, response3];
 }
 
 export const filledCommandFixture = {

diff --git a/.../apps/human-app/server/src/modules/oracle-discovery/spec/oracle-discovery.service.spec.ts b/.../apps/human-app/server/src/modules/oracle-discovery/spec/oracle-discovery.service.spec.ts
@@ -121,6 +121,6 @@ describe('OracleDiscoveryService', () => {
     const result =
       await oracleDiscoveryService.processOracleDiscovery(filledCommandFixture);
 
-    expect(result).toEqual([mockData[1]]);
+    expect(result).toEqual([mockData[1], mockData[2]]);
   });
 });