Figma Integration: Support for arcData and rotate around center
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could later expand this to a UI parameter on If/Map cards to define the origin of the rotation.
ChristophLabacher
force-pushed
the
next
branch
from
4e98a48
to
4adfec1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Figma integration gets support for a new "setArc" reaction that can change the
startingAngleandendingAngleon an EllipseNode. Support for setting the innerRadius of the arc is not yet part of this and it further depends on a UI update in blokdots before this becomes available to users.Breaking change:
The "setRotation" reaction gets a new parameter
originwhich is now "center" by default. So instead of rotating around the top left corner, layers will now rotate around the center. No further update to the blokdots UI is needed for this to take effect (as soon as the Figma plugin was updated).Introducing the
originparameter will allow us to figure out a way to set the desired origin corner in the blokdots UI later on, when we figure out the appropriate transformations in Figma. The currentrelativeTransformworks only when the origin is actually in the center, while our old rotation method revolves around the top-left corner.