Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: flaky cypress listing search #4335

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Conversation

emilyjablonski
Copy link
Collaborator

This PR addresses #4334

  • Addresses the issue in full

Description

Adds an additional check to the page load before searching the listings table.

How Can This Be Tested/Reviewed?

I've run the tests a bunch, will continue to keep an eye!

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 107b3bd
🔍 Latest deploy log https://app.netlify.com/sites/partners-bloom-dev/deploys/66e862f285ec5c0008aba4fc
😎 Deploy Preview https://deploy-preview-4335--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 107b3bd
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/66e862f270c676000892fd8f
😎 Deploy Preview https://deploy-preview-4335--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@emilyjablonski emilyjablonski added wip This PR is not ready for review, do not review it's a “Work In Progress” 1 review needed Requires 1 more review before ready to merge and removed wip This PR is not ready for review, do not review it's a “Work In Progress” labels Sep 12, 2024
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥟

@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Sep 16, 2024
@emilyjablonski emilyjablonski merged commit ea6d124 into main Sep 16, 2024
20 checks passed
@emilyjablonski emilyjablonski deleted the flaky-cypress-listing-search branch September 16, 2024 20:09
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Sep 17, 2024
emilyjablonski added a commit to metrotranscom/doorway that referenced this pull request Sep 17, 2024
emilyjablonski added a commit to housingbayarea/bloom that referenced this pull request Sep 17, 2024
emilyjablonski added a commit to metrotranscom/doorway that referenced this pull request Sep 17, 2024
emilyjablonski added a commit to housingbayarea/bloom that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants