Remove binder from transpileDeclaration implementation. #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Titian Cernicova-Dragomir <[email protected]>
dragomirtitian
force-pushed
the
isolated-declaration-reuse-binder
branch
from
f68c7da
to
3188a82
Compare
dragomirtitian
changed the title
dragomirtitian
force-pushed
the
isolated-declaration-reuse-binder
branch
from
1382822
to
a229141
Compare
Signed-off-by: Titian Cernicova-Dragomir <[email protected]>
dragomirtitian
force-pushed
the
isolated-declaration-reuse-binder
branch
from
a229141
to
e1bb300
Compare
dragomirtitian
changed the title
| return name; | ||
| } | ||
|
|
||
| function getDynamicSymbolName(name: ElementAccessExpression | PropertyName) { |
There was a problem hiding this comment.
I wonder if you can use tryGetPropertyAccessOrIdentifierToString or entityNameToString.
There was a problem hiding this comment.
Switched over to entityNameToString
h-joo
approved these changes
Jan 19, 2024
| // @isolatedDeclarations: true | ||
| // @declarationMap: false | ||
| // @target: ESNext | ||
| // @isolatedDeclarationFixedDiffReason: Function declarations are not fixed. |
There was a problem hiding this comment.
I guess better to mention "Expando* functions "
There was a problem hiding this comment.
I guess the changes in this test file is a side effect of having the "vanilla" symbol info?
Signed-off-by: Titian Cernicova-Dragomir <[email protected]>
dragomirtitian
force-pushed
the
isolated-declaration-reuse-binder
branch
from
1eb2132
to
dc1ffe9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses feedback about duplication of the binder.