Add use counter for <param> with a URL parameter

See [1] for context, but there is interest in deprecating the ability to specify an <object> containing a <param> element that specifies the URL (via a name in {"code","data","movie", "src", or "url"}). This CL adds a use counter for that feature. [1] whatwg/html#387 Bug: 572908 Change-Id: I7f152d05d992606224fb895bca6cd65a4bca15ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3139401 Commit-Queue: Mason Freed <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Auto-Submit: Mason Freed <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#918305}
blueboxd · Sep 3, 2021 · 8d40b33 · 8d40b33
1 parent ca16d64
commit 8d40b33
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/third_party/blink/public/mojom/web_feature/web_feature.mojom b/third_party/blink/public/mojom/web_feature/web_feature.mojom
@@ -3318,6 +3318,7 @@ enum WebFeature {
   kCSSCascadeLayers = 4007,
   kCanvasRenderingContext2DConicGradient = 4008,
   kCanvasRenderingContext2DCanvasFilter = 4009,
+  kHTMLParamElementURLParameter = 4010,
 
   // Add new features immediately above this line. Don't change assigned
   // numbers of any item, and don't reuse removed slots.

diff --git a/third_party/blink/renderer/core/html/html_object_element.cc b/third_party/blink/renderer/core/html/html_object_element.cc
@@ -145,6 +145,8 @@ void HTMLObjectElement::ParametersForPlugin(PluginParameters& plugin_params) {
     // to a plugin.
     if (url_.IsEmpty() && !EqualIgnoringASCIICase(name, "data") &&
         HTMLParamElement::IsURLParameter(name)) {
+      UseCounter::Count(GetDocument(),
+                        WebFeature::kHTMLParamElementURLParameter);
       SetUrl(StripLeadingAndTrailingHTMLSpaces(p->Value()));
     }
     // TODO(schenney): crbug.com/572908 serviceType calculation does not belong

diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
@@ -34435,6 +34435,7 @@ Called by update_use_counter_feature_enum.py.-->
   <int value="4007" label="CSSCascadeLayers"/>
   <int value="4008" label="CanvasRenderingContext2DConicGradient"/>
   <int value="4009" label="CanvasRenderingContext2DCanvasFilter"/>
+  <int value="4010" label="HTMLParamElementURLParameter"/>
 </enum>
 
 <enum name="FeaturePolicyAllowlistType">