Any way to automatically update Chromium legacy, or an update check inside the app? #3

LeeBinder · 2020-11-14T22:31:03Z

First of all a big THANK YOU to you, @blueboxd, for your wonderful port - I'm loving it!

The title should be clear, I think. Is there a way?

blueboxd · 2020-11-14T23:21:22Z

Thank you for your request!

Unfortunately, the original Chromium has no updater option too.
Chrome (not Chromium) uses a separate process (KeyStone) to detect a new version and update Chrome.app.
So, someone (of course me) should build some updater instead of Google's KeyStone.

But, this Chromium-legacy is automatically built twice a day (if no build issues occurred) without any test.
Thus, if an automatic updater is running, your Chromium may have no guarantee for launching, proper operation and so.
I think that's a bit risky.
(of course, there is no guarantee now too, but you should check manually at download the new version)

I'll consider building an automatic test process and updater, but priority is not so high.
Sorry for the inconvenience.

LeeBinder · 2020-11-15T00:24:07Z

ah OK, I understand - thanks for explaining. No hurries then 👍

This reverts commit f771327. Reason for revert: The added browser tests appear to be (flakily) crashing on various builders: For example https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/95504 with https://chromium-swarm.appspot.com/task?id=4fef1ab263264c10 [1303/1306] StartupBrowserWithWebAppTest.PRE_PRE_LastUsedProfilesWithWebApp (1571 ms) [ RUN ] StartupBrowserWithWebAppTest.PRE_LastUsedProfilesWithWebApp [11419:11462:1117/050706.931735:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.DBus.Properties.Get: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files [11419:11462:1117/050706.931814:WARNING:property.cc(144)] DaemonVersion: GetAndBlock: failed. [11419:11462:1117/050706.932083:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.UPower.GetDisplayDevice: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files [11419:11462:1117/050706.932300:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.UPower.EnumerateDevices: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x558aecd46cd9 base::debug::CollectStackTrace() #1 0x558aeccb6753 base::debug::StackTrace::StackTrace() #2 0x558aed26b5f6 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f26cd1224c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x558ae929f9a0 StartupBrowserWithWebAppTest_PRE_LastUsedProfilesWithWebApp_Test::RunTestOnMainThread() #5 0x558aed26a407 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #6 0x558aecde10ef ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #7 0x558aecddfed5 ChromeBrowserMainParts::PreMainMessageLoopRun() #8 0x558aeb16da36 content::BrowserMainLoop::PreMainMessageLoopRun() #9 0x558aeb5c3b13 content::StartupTaskRunner::RunAllTasksNow() #10 0x558aeb16ca17 content::BrowserMainLoop::CreateStartupTasks() #11 0x558aeb16f638 content::BrowserMainRunnerImpl::Initialize() #12 0x558aeb16af68 content::BrowserMain() #13 0x558aebc439c3 content::ContentMainRunnerImpl::RunServiceManager() #14 0x558aebc435b6 content::ContentMainRunnerImpl::Run() #15 0x558aebc40a64 content::RunContentProcess() #16 0x558aebc413ec content::ContentMain() #17 0x558aed269f34 content::BrowserTestBase::SetUp() #18 0x558aecca3c51 InProcessBrowserTest::SetUp() #19 0x558aea228198 testing::Test::Run() #20 0x558aea22902f testing::TestInfo::Run() #21 0x558aea229a07 testing::TestSuite::Run() #22 0x558aea237207 testing::internal::UnitTestImpl::RunAllTests() #23 0x558aea236b6f testing::UnitTest::Run() #24 0x558aecd97f74 base::TestSuite::Run() #25 0x558aecc8d252 ChromeTestSuiteRunner::RunTestSuite() #26 0x558aed299357 content::LaunchTests() #27 0x558aecc8d522 LaunchChromeTests() #28 0x558aecc8ac54 main #29 0x7f26cd10d840 __libc_start_main #30 0x558ae864e0aa _start [1304/1306] StartupBrowserWithWebAppTest.PRE_LastUsedProfilesWithWebApp (CRASHED) Similar crash also on https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/110376 (https://chromium-swarm.appspot.com/task?id=4feff52dc4172910) Original change's description: > Fix session restore after launching with PWA. > > The underlying issue is that the kProfilesLastActive pref gets > cleared when Chrome is launched with a specific profile, which > prevents Chrome from iterating over the last active profiles > and calling session restore on each of them. This CL stops > clearing the pref when launched with --app-id, and avoids > restoring sessions for the last active profiles > if launched with --app-id. Also, ignore browser opens and > closes if the browser window is for a web app, in order to prevent > kProfilesLastActive pref from getting overwritten. > > Bug: 1022795 > Change-Id: I350a54eaaf167dabb297b9bda9061fe965f0750e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984710 > Reviewed-by: Greg Thompson <[email protected]> > Reviewed-by: David Roger <[email protected]> > Commit-Queue: David Bienvenu <[email protected]> > Cr-Commit-Position: refs/heads/master@{#827876} [email protected],[email protected],[email protected] Change-Id: Ib48b40d1c39911d9c5b1072fda35703a70be1f5a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1022795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544744 Reviewed-by: Marijn Kruisselbrink <[email protected]> Commit-Queue: Marijn Kruisselbrink <[email protected]> Cr-Commit-Position: refs/heads/master@{#828247}

Wowfunhappy · 2020-11-18T17:56:02Z

Fwiw, this command should always download and extract the latest release from Github:

curl --silent "https://api.github.com/repos/blueboxd/chromium-legacy/releases/latest" | grep '"browser_download_url":' |  sed -E 's/.*"([^"]+)".*/\1/' | xargs curl -JL | tar --directory . -xvf-

It would be quite easy to put this into a launchd script which runs nightly and replaces the app in /Applications/. Whether that's a good idea is another matter...

LeeBinder · 2020-11-18T22:47:41Z

wow, what a command - regular expressions always freaked me out. Thanks for sharing. I just tested it and confirm it working.

I'd say this would come in very handy for voluntary beta-testers.

…m to CDP command `captureScreenshot`." This reverts commit 85d844e. Reason for revert: reland initial commit with disabled flaky test. Original change's description: > Revert "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`." > > This reverts commit 114bc6a. > > Reason for revert: CaptureScreenshotTest.CaptureScreenshotBeyondViewport_InnerScrollbarsAreShown is failing consistently on linux-chromeos-rel: > > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42849 > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42850 > > Original change's description: > > Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`. > > > > 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`. > > 2. Use `WebSettingsImpl::SetMainFrameClipsContent(false)` to force the whole page to be rendered. > > 3. Set `hide_scrollbars` to avoid artificial scrollbars. > > 4. Set `record_whole_document` to force the whole page to be rendered. > > 5. Removed DCHECK from `third_party/blink/renderer/core/frame/visual_viewport.cc`, as soon as it didn't expect to have preferences to be changed "on the flight". > > > > Details: https://bugs.chromium.org/p/chromium/issues/detail?id=1003629#c37 > > > > Screenshots: > > > > - Before: https://i.imgur.com/yt6WZRx.png > > - Patchset #1: https://i.imgur.com/VsocJ3L.png - artificial scrollbars. > > - Patchset #3: > > * https://imgur.com/UVqpzUQ - line breaks are not exactly the same as in original view. > > * https://imgur.com/MXpgHOl > > * https://imgur.com/haxemcr - not aligned with the node. > > * https://imgur.com/RbdlYVT > > - Patchset #18: > > * https://imgur.com/EWUmn0O > > * https://imgur.com/DUrQ1yF > > * https://imgur.com/cT5oBSi - perfectly aligned. > > * https://imgur.com/Jy4UWtf - no artificial scrollbars (because of the view extended). > > > > Bug: 1003629 > > Change-Id: I6bbc85cd0995626a8b1fb748ec9048c9d586200e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470876 > > Commit-Queue: Maksim Sadym <[email protected]> > > Auto-Submit: Maksim Sadym <[email protected]> > > Reviewed-by: Andrey Kosyakov <[email protected]> > > Reviewed-by: Xianzhu Wang <[email protected]> > > Cr-Commit-Position: refs/heads/master@{#827440} > > [email protected],[email protected],[email protected],[email protected],[email protected],[email protected] > > Change-Id: Iaa9b6ee9f5584adbb4a521808e2d201834a6a6dc > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1003629 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538543 > Reviewed-by: Scott Little <[email protected]> > Commit-Queue: Scott Little <[email protected]> > Cr-Commit-Position: refs/heads/master@{#827505} [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1003629 Change-Id: I2d394d77d0235762c61449ff8e90573de4c0c5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545524 Reviewed-by: Xianzhu Wang <[email protected]> Reviewed-by: Andrey Kosyakov <[email protected]> Commit-Queue: Maksim Sadym <[email protected]> Cr-Commit-Position: refs/heads/master@{#829147}

…rt` param to CDP command `captureScreenshot`."" This reverts commit b8a64dc. Reason for revert: CaptureScreenshotTest.CaptureScreenshotBeyondViewport_OutOfView is failing consistently on "Android FYI SkiaRenderer Vulkan (Pixel 2)" https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%20SkiaRenderer%20Vulkan%20%28Pixel%202%29/b8863213321775995088 Original change's description: > Reland "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`." > > This reverts commit 85d844e. > > Reason for revert: reland initial commit with disabled flaky test. > > Original change's description: > > Revert "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`." > > > > This reverts commit 114bc6a. > > > > Reason for revert: CaptureScreenshotTest.CaptureScreenshotBeyondViewport_InnerScrollbarsAreShown is failing consistently on linux-chromeos-rel: > > > > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42849 > > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42850 > > > > Original change's description: > > > Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`. > > > > > > 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`. > > > 2. Use `WebSettingsImpl::SetMainFrameClipsContent(false)` to force the whole page to be rendered. > > > 3. Set `hide_scrollbars` to avoid artificial scrollbars. > > > 4. Set `record_whole_document` to force the whole page to be rendered. > > > 5. Removed DCHECK from `third_party/blink/renderer/core/frame/visual_viewport.cc`, as soon as it didn't expect to have preferences to be changed "on the flight". > > > > > > Details: https://bugs.chromium.org/p/chromium/issues/detail?id=1003629#c37 > > > > > > Screenshots: > > > > > > - Before: https://i.imgur.com/yt6WZRx.png > > > - Patchset #1: https://i.imgur.com/VsocJ3L.png - artificial scrollbars. > > > - Patchset #3: > > > * https://imgur.com/UVqpzUQ - line breaks are not exactly the same as in original view. > > > * https://imgur.com/MXpgHOl > > > * https://imgur.com/haxemcr - not aligned with the node. > > > * https://imgur.com/RbdlYVT > > > - Patchset #18: > > > * https://imgur.com/EWUmn0O > > > * https://imgur.com/DUrQ1yF > > > * https://imgur.com/cT5oBSi - perfectly aligned. > > > * https://imgur.com/Jy4UWtf - no artificial scrollbars (because of the view extended). > > > > > > Bug: 1003629 > > > Change-Id: I6bbc85cd0995626a8b1fb748ec9048c9d586200e > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470876 > > > Commit-Queue: Maksim Sadym <[email protected]> > > > Auto-Submit: Maksim Sadym <[email protected]> > > > Reviewed-by: Andrey Kosyakov <[email protected]> > > > Reviewed-by: Xianzhu Wang <[email protected]> > > > Cr-Commit-Position: refs/heads/master@{#827440} > > > > [email protected],[email protected],[email protected],[email protected],[email protected],[email protected] > > > > Change-Id: Iaa9b6ee9f5584adbb4a521808e2d201834a6a6dc > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1003629 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538543 > > Reviewed-by: Scott Little <[email protected]> > > Commit-Queue: Scott Little <[email protected]> > > Cr-Commit-Position: refs/heads/master@{#827505} > > [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1003629 > Change-Id: I2d394d77d0235762c61449ff8e90573de4c0c5d5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545524 > Reviewed-by: Xianzhu Wang <[email protected]> > Reviewed-by: Andrey Kosyakov <[email protected]> > Commit-Queue: Maksim Sadym <[email protected]> > Cr-Commit-Position: refs/heads/master@{#829147} [email protected],[email protected],[email protected] Change-Id: I2422b2560d10910cd90290c5647eb068743ac682 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1003629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550242 Reviewed-by: Mingjing Zhang <[email protected]> Commit-Queue: Mingjing Zhang <[email protected]> Cr-Commit-Position: refs/heads/master@{#829230}

…rt` param to CDP command `captureScreenshot`."" This reverts commit f01c0ad. Reason for revert: 1. Fixed `CaptureScreenshotBeyondViewport_OutOfView` by proper rounding. 2. Fixed `CaptureScreenshotBeyondViewport_InnerScrollbarsAreShown` on some platform by relaxing color tolerance. Original change's description: > Revert "Reland "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`."" > > This reverts commit b8a64dc. > > Reason for revert: CaptureScreenshotTest.CaptureScreenshotBeyondViewport_OutOfView is failing consistently on "Android FYI SkiaRenderer Vulkan (Pixel 2)" > > https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%20SkiaRenderer%20Vulkan%20%28Pixel%202%29/b8863213321775995088 > > Original change's description: > > Reland "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`." > > > > This reverts commit 85d844e. > > > > Reason for revert: reland initial commit with disabled flaky test. > > > > Original change's description: > > > Revert "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`." > > > > > > This reverts commit 114bc6a. > > > > > > Reason for revert: CaptureScreenshotTest.CaptureScreenshotBeyondViewport_InnerScrollbarsAreShown is failing consistently on linux-chromeos-rel: > > > > > > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42849 > > > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42850 > > > > > > Original change's description: > > > > Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`. > > > > > > > > 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`. > > > > 2. Use `WebSettingsImpl::SetMainFrameClipsContent(false)` to force the whole page to be rendered. > > > > 3. Set `hide_scrollbars` to avoid artificial scrollbars. > > > > 4. Set `record_whole_document` to force the whole page to be rendered. > > > > 5. Removed DCHECK from `third_party/blink/renderer/core/frame/visual_viewport.cc`, as soon as it didn't expect to have preferences to be changed "on the flight". > > > > > > > > Details: https://bugs.chromium.org/p/chromium/issues/detail?id=1003629#c37 > > > > > > > > Screenshots: > > > > > > > > - Before: https://i.imgur.com/yt6WZRx.png > > > > - Patchset #1: https://i.imgur.com/VsocJ3L.png - artificial scrollbars. > > > > - Patchset #3: > > > > * https://imgur.com/UVqpzUQ - line breaks are not exactly the same as in original view. > > > > * https://imgur.com/MXpgHOl > > > > * https://imgur.com/haxemcr - not aligned with the node. > > > > * https://imgur.com/RbdlYVT > > > > - Patchset #18: > > > > * https://imgur.com/EWUmn0O > > > > * https://imgur.com/DUrQ1yF > > > > * https://imgur.com/cT5oBSi - perfectly aligned. > > > > * https://imgur.com/Jy4UWtf - no artificial scrollbars (because of the view extended). > > > > > > > > Bug: 1003629 > > > > Change-Id: I6bbc85cd0995626a8b1fb748ec9048c9d586200e > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470876 > > > > Commit-Queue: Maksim Sadym <[email protected]> > > > > Auto-Submit: Maksim Sadym <[email protected]> > > > > Reviewed-by: Andrey Kosyakov <[email protected]> > > > > Reviewed-by: Xianzhu Wang <[email protected]> > > > > Cr-Commit-Position: refs/heads/master@{#827440} > > > > > > [email protected],[email protected],[email protected],[email protected],[email protected],[email protected] > > > > > > Change-Id: Iaa9b6ee9f5584adbb4a521808e2d201834a6a6dc > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 1003629 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538543 > > > Reviewed-by: Scott Little <[email protected]> > > > Commit-Queue: Scott Little <[email protected]> > > > Cr-Commit-Position: refs/heads/master@{#827505} > > > > [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1003629 > > Change-Id: I2d394d77d0235762c61449ff8e90573de4c0c5d5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545524 > > Reviewed-by: Xianzhu Wang <[email protected]> > > Reviewed-by: Andrey Kosyakov <[email protected]> > > Commit-Queue: Maksim Sadym <[email protected]> > > Cr-Commit-Position: refs/heads/master@{#829147} > > [email protected],[email protected],[email protected] > > Change-Id: I2422b2560d10910cd90290c5647eb068743ac682 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1003629 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550242 > Reviewed-by: Mingjing Zhang <[email protected]> > Commit-Queue: Mingjing Zhang <[email protected]> > Cr-Commit-Position: refs/heads/master@{#829230} [email protected],[email protected],[email protected],[email protected] # Not skipping CQ checks because this is a reland. Bug: 1003629 Change-Id: Ib6e44df890e6707d811fccf2c6a8817983123c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551114 Commit-Queue: Maksim Sadym <[email protected]> Reviewed-by: Xianzhu Wang <[email protected]> Reviewed-by: Andrey Kosyakov <[email protected]> Cr-Commit-Position: refs/heads/master@{#829636}

…_chromium=true This reverts commit 6134a13. Reason for reland: Underlying issue fixed in cbdf4c2 TBR=agrieve # Reland with no changes. Bug: 1120190 Bug: 1145570 Change-Id: I64a8d982453f7deae45b24ec079dae8346303592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528622 Reviewed-by: Andrew Grieve <[email protected]> Commit-Queue: Andrew Grieve <[email protected]> Cr-Commit-Position: refs/heads/master@{#829815}

... until the respective XDG surface is initialized. The current call to WaylandToplevelWindow::InitializeAuraShell() is not effective on Exo. Basically, this method was being called prior to the respective XDG surface got properly initialized on Exo. Problem: 1) Lacros calls aura_surface_set_fullscreen_mode(), and Exo should processes the call like below: #1 exo::ShellSurfaceBase::SetUseImmersiveForFullscreen() #2 exo::Surface::SetUseImmersiveForFullscreen() #3 exo::wayland::AuraSurface::SetFullscreenMode() #4 exo::wayland::(anonymous namespace)::aura_surface_set_fullscreen_mode() 2) However, on frame #2, |exo::Surface::delegate_| was still NIL, and the call got bailed out. 3) |exo::Surface::delegate_| only gets assigned when Exo processes the call to xdg_wm_base_get_xdg_surface(), from the client side. #1 0x5563f0dbb100 exo::Surface::SetSurfaceDelegate() #2 0x5563f0dc1e33 exo::SurfaceTreeHost::SetRootSurface() #3 0x5563f0e02a23 exo::ShellSurfaceBase::ShellSurfaceBase() #4 0x5563f0dfdc65 exo::ShellSurface::ShellSurface() #5 0x5563f0e0f47f exo::XdgShellSurface::XdgShellSurface() #6 0x5563f0d95561 exo::Display::CreateXdgShellSurface() #7 0x5563ecbed19a exo::wayland::(anonymous namespace)::xdg_wm_base_get_xdg_surface() CL fixes this by making the call to InitializeAuraShell() only take place once the respective XDGSurface is initialized. This is a fixup! of https://crrev.com/c/2353116. BUG=1113900 [email protected] Change-Id: I4169d30545238abf2ad46eaef9677a846d58c6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566346 Commit-Queue: Antonio Gomes <[email protected]> Reviewed-by: Maksim Sisov (GMT+2) <[email protected]> Auto-Submit: Antonio Gomes <[email protected]> Cr-Commit-Position: refs/heads/master@{#832825}

This reverts commit 3da5569. Reason for revert: Suspected to be causing widespread failures in PPAPI/Pepper tests on Win and Linux dbg bots: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/87226 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/93584 Sample failure output: [ RUN ] OutOfProcessPPAPITest.Instance_ExecuteScript [18698:18698:1211/141847.386588:INFO:content_main_runner_impl.cc(1027)] Chrome is running in full browser mode. DevTools listening on ws://127.0.0.1:37739/devtools/browser/565ba965-de40-4715-8905-11c22e1cfcca [18698:18811:1211/141848.175888:WARNING:render_message_filter.cc(137)] Could not find tid [18698:18811:1211/141848.265958:WARNING:render_message_filter.cc(137)] Could not find tid [18698:18698:1211/141848.839793:INFO:CONSOLE(1)] "Uncaught Error: plugin exception", source: file:///b/s/w/ir/ppapi/tests/test_case.html?testcase=Instance_ExecuteScript (1) [18698:18698:1211/141848.844552:INFO:CONSOLE(1)] "Uncaught TypeError: document.doesntExist is not a function", source: file:///b/s/w/ir/ppapi/tests/test_case.html?testcase=Instance_ExecuteScript (1) [18698:18698:1211/141848.855716:INFO:CONSOLE(176)] "ExecuteScript finished in 0.073 seconds.", source: file:///b/s/w/ir/ppapi/tests/test_case.html?testcase=Instance_ExecuteScript (176) Received signal 11 <unknown> 000000000000 #0 0x7f89c0dca89f base::debug::CollectStackTrace() #1 0x7f89c0b5409a base::debug::StackTrace::StackTrace() #2 0x7f89c0b54055 base::debug::StackTrace::StackTrace() #3 0x7f89c0dca36b base::debug::(anonymous namespace)::StackDumpSignalHandler() #4 0x7f8993ea2390 (/lib/x86_64-linux-gnu/libpthread-2.23.so+0x1138f) #5 0x7f89b142c419 std::__Cr::default_delete<>::operator()() #6 0x7f89b142c3ea std::__Cr::unique_ptr<>::reset() #7 0x7f89b142c379 std::__Cr::unique_ptr<>::~unique_ptr() #8 0x7f89b142c16d mojo::internal::AssociatedInterfacePtrState<>::~AssociatedInterfacePtrState() #9 0x7f89b142cb95 mojo::AssociatedRemote<>::~AssociatedRemote() #10 0x7f89b142afab content::PepperPluginInstance::~PepperPluginInstance() #11 0x7f89b2587d8e content::PepperPluginInstanceImpl::~PepperPluginInstanceImpl() #12 0x7f89b2587e69 content::PepperPluginInstanceImpl::~PepperPluginInstanceImpl() #13 0x7f89b25350f8 base::RefCounted<>::DeleteInternal<>() #14 0x7f89b25350c5 base::DefaultRefCountedTraits<>::Destruct() #15 0x7f89b25350a3 base::RefCounted<>::Release() #16 0x7f89b2535069 scoped_refptr<>::Release() #17 0x7f89b253020a scoped_refptr<>::~scoped_refptr() #18 0x7f89b25ce3f3 scoped_refptr<>::reset() #19 0x7f89b25cd8dd _ZN13scoped_refptrIN7content24PepperPluginInstanceImplEEaSEDn #20 0x7f89b25cbe83 content::PepperWebPluginImpl::Destroy() #21 0x7f89a7414e41 blink::WebPluginContainerImpl::Dispose() #22 0x7f89a593f32d blink::HTMLFrameOwnerElement::PluginDisposeSuspendScope::PerformDeferredPluginDispose() #23 0x7f89a4f5d292 blink::HTMLFrameOwnerElement::PluginDisposeSuspendScope::~PluginDisposeSuspendScope() #24 0x7f89a4f58862 blink::ContainerNode::RemoveChild() #25 0x7f89a5111cbb blink::Node::removeChild() #26 0x7f89a70daabe blink::(anonymous namespace)::RemoveChildOperationCallback() #27 0x7f899e0c0780 v8::internal::FunctionCallbackArguments::Call() #28 0x7f899e0bedcd v8::internal::(anonymous namespace)::HandleApiCallHelper<>() #29 0x7f899e0bcfe5 v8::internal::Builtin_Impl_HandleApiCall() #30 0x7f899e0bcaa9 v8::internal::Builtin_HandleApiCall() #31 0x7f899dae513f Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_BuiltinExit r8: 00000f84ee181f88 r9: 0000000000000000 r10: 0000000000000259 r11: 00007f8996194690 r12: 00007f89a70da600 r13: 0000132400000000 r14: 00007ffc8c8eef10 r15: 00007ffc8c8eef10 di: 00007f89b3e98918 si: 00007f89b3e98918 bp: 00007ffc8c8ee710 bx: 00007f89c0f52440 dx: 00000f84ee181f90 ax: 00007f89b2587db0 cx: 0000000000000000 sp: 00007ffc8c8ee6f0 ip: 00007f89b142c419 efl: 0000000000010206 cgf: 002b000000000033 erf: 0000000000000000 trp: 000000000000000d msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated. ../../content/public/test/no_renderer_crashes_assertion.cc:101: Failure Failed Unexpected termination of a renderer process; status: 1, exit_code: 256 Stack trace: #0 0x55ec1877d394 content::NoRendererCrashesAssertion::Observe() #1 0x7f3d4cf1ead6 content::NotificationServiceImpl::Notify() #2 0x7f3d4d3a3986 content::RenderProcessHostImpl::ProcessDied() #3 0x7f3d4d3a46be content::RenderProcessHostImpl::OnChannelError() #4 0x7f3d60fa392d IPC::ChannelProxy::Context::OnDispatchError() #5 0x7f3d60fa987f base::internal::FunctorTraits<>::Invoke<>() #6 0x7f3d60fa97c1 base::internal::InvokeHelper<>::MakeItSo<>() #7 0x7f3d60fa9742 _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvvEJ13scoped_refptrIS5_EEEEFvvEE7RunImplIS7_NSt4__Cr5tupleIJS9_EEEJLm0EEEEvOT_OT0_NSE_16integer_sequenceImJXspT1_EEEE #8 0x7f3d60fa96ec base::internal::Invoker<>::RunOnce() #9 0x7f3d5ca3c0d1 _ZNO4base12OnceCallbackIFvvEE3RunEv #10 0x7f3d5cc03df2 base::TaskAnnotator::RunTask() #11 0x7f3d5cc49eba base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #12 0x7f3d5cc49685 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #13 0x7f3d5cc4a119 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #14 0x7f3d5caf69f1 base::MessagePumpGlib::HandleDispatch() #15 0x7f3d5caf7141 base::(anonymous namespace)::WorkSourceDispatch() #16 0x7f3d2f683197 g_main_context_dispatch #17 0x7f3d2f6833f0 (/lib/x86_64-linux-gnu/libglib-2.0.so.0.4800.2+0x4a3ef) #18 0x7f3d2f68349c g_main_context_iteration #19 0x7f3d5caf6b00 base::MessagePumpGlib::Run() #20 0x7f3d5cc4a740 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #21 0x7f3d5cb95d75 base::RunLoop::Run() #22 0x55ec187b836a content::RunThisRunLoop() #23 0x55ec187b831f content::RunMessageLoop() #24 0x55ec18760320 content::JavascriptTestObserver::Run() #25 0x55ec16a8b567 content::PPAPITestBase::RunTestURL() #26 0x55ec16a8b48e content::PPAPITestBase::RunTest() #27 0x55ec16a84f2a content::(anonymous namespace)::OutOfProcessPPAPITest_Instance_ExecuteScript_Test::RunTestOnMainThread() #28 0x55ec18719264 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #29 0x55ec1871cf2a base::internal::FunctorTraits<>::Invoke<>() #30 0x55ec1871cea1 base::internal::InvokeHelper<>::MakeItSo<>() #31 0x55ec1871ce37 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #32 0x55ec1871cddc base::internal::Invoker<>::RunOnce() #33 0x55ec157bbac1 _ZNO4base12OnceCallbackIFvvEE3RunEv #34 0x55ec18a331cc content::ShellBrowserMainParts::PreMainMessageLoopRun() #35 0x7f3d4c5f5282 content::BrowserMainLoop::PreMainMessageLoopRun() chromium#36 0x7f3d4c5ff18a base::internal::FunctorTraits<>::Invoke<>() #37 0x7f3d4c5ff0a1 base::internal::InvokeHelper<>::MakeItSo<>() #38 0x7f3d4c5ff027 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE chromium#39 0x7f3d4c5fefcc base::internal::Invoker<>::RunOnce() #40 0x7f3d4c9d5b31 _ZNO4base12OnceCallbackIFivEE3RunEv #41 0x7f3d4d812b16 content::StartupTaskRunner::RunAllTasksNow() chromium#42 0x7f3d4c5f3b8a content::BrowserMainLoop::CreateStartupTasks() #43 0x7f3d4c602df0 content::BrowserMainRunnerImpl::Initialize() #44 0x7f3d4c5f0d64 content::BrowserMain() #45 0x7f3d4e7bcbc6 content::RunBrowserProcessMain() #46 0x7f3d4e7be1e9 content::ContentMainRunnerImpl::RunBrowser() #47 0x7f3d4e7bdad7 content::ContentMainRunnerImpl::Run() #48 0x7f3d4e7bae05 content::RunContentProcess() #49 0x7f3d4e7bb79d content::ContentMain() #50 0x55ec18718d5a content::BrowserTestBase::SetUp() #51 0x55ec1865a9ac content::ContentBrowserTest::SetUp() #52 0x55ec16a8ba95 content::OutOfProcessPPAPITest::SetUp() #53 0x55ec17363a6b testing::internal::HandleSehExceptionsInMethodIfSupported<>() #54 0x55ec173547f7 testing::internal::HandleExceptionsInMethodIfSupported<>() Note the ~AssociatedRemote from ~PepperPluginInstanceImpl, which I think was introduced in this CL. This also seems to be the only plugin-related change in the blamelist (https://chromium.googlesource.com/chromium/src/+log/6828ef78f2200e4bac3280186c7520ab65b2d7f8%5E..21468f4304510a432e3376d9d72ec67962f39723?pretty=fuller&n=) Original change's description: > Add mojo interfaces for pepper plugins. > > This adds some base plumbing for pepper plugin instance handling. The > pepper renderer code allocates and manages the PepperPluginInstanceImpl, > this creates the correct encapsulation moving code out of RenderFrameImpl. > > On the browser side a PepperPluginInstance is created to handle the > messages and relay them to the WebContentsImpl which use to handle > the processing of Pepper messages. > > BUG=1157519 > > Change-Id: I24941bb7eecef56a90bbf961e6396101c8d3c785 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585627 > Commit-Queue: Dave Tapuska <[email protected]> > Reviewed-by: Arthur Sonzogni <[email protected]> > Reviewed-by: Daniel Cheng <[email protected]> > Reviewed-by: Bill Budge <[email protected]> > Cr-Commit-Position: refs/heads/master@{#836239} [email protected],[email protected],[email protected],[email protected],[email protected] Change-Id: Iddd93694ebe0611abef6c74b57667554b51e26fc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1157519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587769 Reviewed-by: Alex Moshchuk <[email protected]> Commit-Queue: Alex Moshchuk <[email protected]> Cr-Commit-Position: refs/heads/master@{#836330}

…ility bubbles." This reverts commit 7ffd10d. Reason for revert: [Sheriff] Suspected to be causing widespread accessibility test failures on MSAN bots due to use of uninitialized value in code that was added to CreateOrUpdateLayer in this CL (line 73, presumably for `stack_at_top`) Build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21677 Sample failure: [ RUN ] AccessibilityFocusRingControllerTest.FocusRingWorksOnMultipleDisplays 2020-12-11T22:10:55.266324Z 8322331852 ERROR ash_unittests[24691:24691]: [cras_audio_handler.cc(1611)] Failed to retrieve WBS mic deprioritized flag ==24691==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5653d294dffa in ash::AccessibilityLayer::CreateOrUpdateLayer(aura::Window*, char const*, gfx::Rect const&, bool) ./../../ash/accessibility/accessibility_layer.cc:73:7 #1 0x5653d294788e in ash::AccessibilityFocusRingLayer::Set(ash::AccessibilityFocusRing const&) ./../../ash/accessibility/accessibility_focus_ring_layer.cc:116:3 #2 0x5653d29383cb in ash::AccessibilityFocusRingGroup::UpdateFocusRingsFromInfo(ash::AccessibilityLayerDelegate*) ./../../ash/accessibility/accessibility_focus_ring_group.cc:82:25 #3 0x5653d293baa9 in ash::AccessibilityFocusRingGroup::UpdateFocusRing(std::__1::unique_ptr<ash::AccessibilityFocusRingInfo, std::__1::default_delete<ash::AccessibilityFocusRingInfo> >, ash::AccessibilityLayerDelegate*) ./../../ash/accessibility/accessibility_focus_ring_group.cc:152:3 #4 0x5653d2932f04 in ash::AccessibilityFocusRingControllerImpl::SetFocusRing(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::unique_ptr<ash::AccessibilityFocusRingInfo, std::__1::default_delete<ash::AccessibilityFocusRingInfo> >) ./../../ash/accessibility/accessibility_focus_ring_controller_impl.cc:67:25 #5 0x5653cda0dbe2 in ash::AccessibilityFocusRingControllerTest_FocusRingWorksOnMultipleDisplays_Test::TestBody() ./../../ash/accessibility/accessibility_focus_ring_controller_unittest.cc:106:15 #6 0x5653d24cc4a7 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #7 0x5653d24cc4a7 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2689:5 #8 0x5653d24ceb57 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2866:11 #9 0x5653d24d0e64 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3020:28 #10 0x5653d24fb28a in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5730:44 #11 0x5653d24fa26c in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10 #12 0x5653d24fa26c in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5313:10 #13 0x5653d3c13224 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2485:46 #14 0x5653d3c13224 in base::TestSuite::Run() ./../../base/test/test_suite.cc:480:16 #15 0x5653d3c1addf in Run ./../../base/callback.h:101:12 #16 0x5653d3c1addf in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:179:38 #17 0x5653d3c1a853 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:249:10 #18 0x5653cf8bc976 in main ./../../ash/test/ash_unittests.cc:25:10 #19 0x7fe4936dd83f in __libc_start_main ??:0:0 #20 0x5653cd7f7409 in _start ??:0:0 Uninitialized value was created by a heap allocation #0 0x5653cd86a7c9 in operator new(unsigned long) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cpp:45:35 #1 0x5653d2938051 in make_unique<ash::AccessibilityFocusRingLayer, ash::AccessibilityLayerDelegate *&> ./../../buildtools/third_party/libc++/trunk/include/memory:3043:28 #2 0x5653d2938051 in ash::AccessibilityFocusRingGroup::UpdateFocusRingsFromInfo(ash::AccessibilityLayerDelegate*) ./../../ash/accessibility/accessibility_focus_ring_group.cc:69:11 #3 0x5653d293baa9 in ash::AccessibilityFocusRingGroup::UpdateFocusRing(std::__1::unique_ptr<ash::AccessibilityFocusRingInfo, std::__1::default_delete<ash::AccessibilityFocusRingInfo> >, ash::AccessibilityLayerDelegate*) ./../../ash/accessibility/accessibility_focus_ring_group.cc:152:3 #4 0x5653d2932f04 in ash::AccessibilityFocusRingControllerImpl::SetFocusRing(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::unique_ptr<ash::AccessibilityFocusRingInfo, std::__1::default_delete<ash::AccessibilityFocusRingInfo> >) ./../../ash/accessibility/accessibility_focus_ring_controller_impl.cc:67:25 #5 0x5653cda0dbe2 in ash::AccessibilityFocusRingControllerTest_FocusRingWorksOnMultipleDisplays_Test::TestBody() ./../../ash/accessibility/accessibility_focus_ring_controller_unittest.cc:106:15 #6 0x5653d24cc4a7 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #7 0x5653d24cc4a7 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2689:5 #8 0x5653d24ceb57 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2866:11 #9 0x5653d24d0e64 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3020:28 #10 0x5653d24fb28a in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5730:44 #11 0x5653d24fa26c in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10 #12 0x5653d24fa26c in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5313:10 #13 0x5653d3c13224 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2485:46 #14 0x5653d3c13224 in base::TestSuite::Run() ./../../base/test/test_suite.cc:480:16 #15 0x5653d3c1addf in Run ./../../base/callback.h:101:12 #16 0x5653d3c1addf in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:179:38 #17 0x5653d3c1a853 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:249:10 #18 0x5653cf8bc976 in main ./../../ash/test/ash_unittests.cc:25:10 #19 0x7fe4936dd83f in __libc_start_main ??:0:0 SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/s/w/ir/out/Release/ash_unittests+0x65feffa) Original change's description: > Re-land: Move focus rings and highlight layers under accessibility bubbles. > > Original patch: http://crrev.com/c/2568547 > Revert: http://crrev.com/c/2583106 > > Fix for issue where focus ring appears below switch access panel. Now clients can specify if they want their focus ring to appear above or below accessibility bubble panels. STS will specify they appear below, though other clients will (by default) specify they appear above all panels. This fixes an issue with the switch access focus ring didn't appear above the switch access panel. > > Original description: > > Move focus rings and highlight layers under accessibility bubbles. > > Will allow Select-to-speak panel UI to appear above focus ring and highlight layers. This also avoids the need to create more window containers. > > Bug: 1157261, 1143814 > Change-Id: Ibd8dd577ecd4fb5767b628c2eff679a2f6931b9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582997 > Reviewed-by: Dominic Mazzoni <[email protected]> > Reviewed-by: Xiyuan Xia <[email protected]> > Commit-Queue: Joel Riley <[email protected]> > Cr-Commit-Position: refs/heads/master@{#836222} [email protected],[email protected],[email protected],[email protected],[email protected] Change-Id: I08b819849d13fb5d01f67c5bbd3083ed0e445e7e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1157261 Bug: 1143814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587604 Reviewed-by: Alex Moshchuk <[email protected]> Commit-Queue: Alex Moshchuk <[email protected]> Cr-Commit-Position: refs/heads/master@{#836386}

Re-land rolls back SPIRV-Cross before the ANGLE/Metal XFB regression. Original change's description: > Revert "Re-land #2 "Use new vulkan-deps repo for all Vulkan dependencies."" > > This reverts commit fbeb26e. > > Reason for revert: Suspected cause of https://crbug.com/1159974 > > Original change's description: > > Re-land #2 "Use new vulkan-deps repo for all Vulkan dependencies." > > > > Re-land #2 includes update to licenses.py and removes stale files. > > > > Re-land includes missing headers directory. > > > > This replaces several grouped dependencies with one meta-repo. > > The meta-repo will allow us to group multiple inter-dependent > > deps rolls into one single roll. This solves the problem of > > separate rollers breaking because of the inter-dependencies. > > It also allows ANGLE and Chrome to share common bits like the > > README and .gitignore files. > > > > Bug: angleproject:5390 > > Bug: 1153258 > > Change-Id: Ie425e232096a25711dd90e84a6d91bf3324903ab > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595457 > > Commit-Queue: Dirk Pranke <[email protected]> > > Reviewed-by: Dirk Pranke <[email protected]> > > Auto-Submit: Jamie Madill <[email protected]> > > Cr-Commit-Position: refs/heads/master@{#838196} > > [email protected],[email protected],[email protected],[email protected] > > Change-Id: I60ab236419d36f55cf84c294f5a4e69f23c4c9c6 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: angleproject:5390 > Bug: 1153258 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595256 > Reviewed-by: Sean Gilhuly <[email protected]> > Commit-Queue: Sean Gilhuly <[email protected]> > Cr-Commit-Position: refs/heads/master@{#838227} [email protected],[email protected],[email protected],[email protected],[email protected] # Not skipping CQ checks because this is a reland. Bug: angleproject:5390 Bug: 1153258 Change-Id: I41dfbaa676dbc92b5ff5cf30919a20044cf4014a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596071 Commit-Queue: Jamie Madill <[email protected]> Reviewed-by: Jamie Madill <[email protected]> Reviewed-by: Dirk Pranke <[email protected]> Cr-Commit-Position: refs/heads/master@{#838335}

This change enables Chrome OS Chrome builds running on non-cros linux to work with Espeak-ng. On linux builds, dcheck always triggers an error in mojo. Consequently, in TtsService, where the service makes mojo calls on a Remote within the audio thread, a DCHECK was hit: 2021-01-11T22:46:32.666960Z FATAL chrome[2743839:2743847]: [sequence_checker.h(120)] Check failed: checker.CalledOnValidSequence(). #0 0x7f7ee68c681f base::debug::CollectStackTrace() #1 0x7f7ee665fd8a base::debug::StackTrace::StackTrace() #2 0x7f7ee665fd45 base::debug::StackTrace::StackTrace() #3 0x7f7ee66a9057 logging::LogMessage::~LogMessage() #4 0x7f7ee66a9769 logging::LogMessage::~LogMessage() #5 0x7f7ee6620c1b logging::CheckError::~CheckError() #6 0x7f7ee564e09c base::ScopedValidateSequenceChecker::ScopedValidateSequenceChecker() #7 0x7f7ee566c068 mojo::InterfaceEndpointClient::SendMessage() #8 0x7f7ee566c99f mojo::InterfaceEndpointClient::Accept() #9 0x565159b53c29 chromeos::tts::mojom::TtsEventObserverProxy::OnStart() #10 0x56515c4e3a5a chromeos::tts::TtsService::Render() #11 0x7f7ed8648f02 media::AudioOutputDeviceThreadCallback::Process() #12 0x7f7ed861fe9d media::AudioDeviceThread::ThreadMain() #13 0x7f7ee68fb1ab base::(anonymous namespace)::ThreadFunc() #14 0x7f7ea303fea7 start_thread #15 0x7f7ea2baad8f clone Fix this by queueing up already rendered audio buffers and processing them on the main thread's task runner. Test: manually on a linux chromeos build. Verify that web speech produces speech through Espeak. Change-Id: I4b1e5b0a6e72e4e571b5a26fde731acc57936894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621983 Reviewed-by: Katie Dektar <[email protected]> Commit-Queue: David Tseng <[email protected]> Cr-Commit-Position: refs/heads/master@{#842622}

This reverts commit 8aca3b4. Reason for revert: I suspect the CL caused WindowOpenApiTest.PopupBlockingExtension failure https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/22177/overview [ RUN ] WindowOpenApiTest.PopupBlockingExtension 2021-01-13T05:48:40.927570Z INFO browser_tests[28993:28993]: [content_main_runner_impl.cc(1055)] Chrome is running in full browser mode. 2021-01-13T05:48:41.111260Z WARNING browser_tests[28993:28993]: [audio_manager_linux.cc(69)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. 2021-01-13T05:48:41.147293Z ERROR browser_tests[28993:28993]: [cras_audio_handler.cc(1627)] Failed to retrieve WBS mic deprioritized flag 2021-01-13T05:48:41.148942Z WARNING browser_tests[28993:29172]: [statistics_provider.cc(321)] Finished loading statistics. 2021-01-13T05:48:41.786294Z WARNING browser_tests[28993:28993]: [user_policy_manager_builder_chromeos.cc(123)] No policy loaded for known non-enterprise user 2021-01-13T05:48:42.161192Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? 2021-01-13T05:48:42.192143Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:42.205962Z ERROR browser_tests[28993:28993]: [proximity_auth_profile_pref_manager.cc(192)] Failed to find local state prefs for current user. 2021-01-13T05:48:42.726389Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? 2021-01-13T05:48:43.054799Z WARNING browser_tests[28993:28993]: [wallpaper_controller_client.cc(377)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. 2021-01-13T05:48:43.218141Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:43.726830Z WARNING browser_tests[29202:29284]: [http_cache_transaction.cc(1192)] Unable to open or create cache entry 2021-01-13T05:48:44.322210Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:44.376219Z ERROR browser_tests[28993:28993]: [plugin_vm_manager_impl.cc(141)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? 2021-01-13T05:48:44.859368Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(495)] One-time key permissions migration started for token: 0. 2021-01-13T05:48:44.863796Z INFO browser_tests[28993:28993]: [android_sms_pairing_state_tracker_impl.cc(72)] No Pairing cookie found 2021-01-13T05:48:45.010359Z ERROR browser_tests[28993:29140]: [object_proxy.cc(621)] Failed to call method: org.chromium.U2F.IsUvpaa: object_path= /org/chromium/U2F: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.U2F was not provided by any .service files 2021-01-13T05:48:45.018258Z ERROR browser_tests[28993:29172]: [als_reader.cc(47)] Missing num of als 2021-01-13T05:48:45.681453Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:45.682492Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:45.685002Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(520)] One-time key permissions migration succeeded for token: 0. 2021-01-13T05:48:45.768048Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:45.769933Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:46.230042Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:50.078030Z ERROR browser_tests[28993:29172]: [object_proxy.cc(621)] Failed to call method: org.chromium.debugd.GetPerfOutputFd: object_path= /org/chromium/debugd: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.debugd was not provided by any .service files 2021-01-13T05:49:10.763123Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico 2021-01-13T05:49:10.833186Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico ../../chrome/browser/extensions/window_open_apitest.cc:91: Failure Expected equality of these values: num_browsers Which is: 4 chrome::GetBrowserCount(browser->profile()) Which is: 2 Google Test trace: ../../chrome/browser/extensions/window_open_apitest.cc:76: WaitForTabsPopupsApps tabs:5, popups:2, app_popups:1 Stack trace: #0 0x56363e71a458 extensions::WaitForTabsPopupsApps() #1 0x56363e71c5aa extensions::WindowOpenApiTest_PopupBlockingExtension_Test::RunTestOnMainThread() #2 0x563646f1d248 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #3 0x563646f207ca base::internal::FunctorTraits<>::Invoke<>() #4 0x563646f20741 base::internal::InvokeHelper<>::MakeItSo<>() #5 0x563646f206e7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #6 0x563646f2068c base::internal::Invoker<>::RunOnce() #7 0x56363c76ba61 _ZNO4base12OnceCallbackIFvvEE3RunEv #8 0x563645c03021 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #9 0x563645c01fc2 ChromeBrowserMainParts::PreMainMessageLoopRun() #10 0x563640599fc6 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #11 0x7fb5dc82e9e5 content::BrowserMainLoop::PreMainMessageLoopRun() #12 0x7fb5dc8383ca base::internal::FunctorTraits<>::Invoke<>() #13 0x7fb5dc8382e1 base::internal::InvokeHelper<>::MakeItSo<>() #14 0x7fb5dc838267 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #15 0x7fb5dc83820c base::internal::Invoker<>::RunOnce() #16 0x7fb5dcc03581 _ZNO4base12OnceCallbackIFivEE3RunEv #17 0x7fb5dda03df6 content::StartupTaskRunner::RunAllTasksNow() #18 0x7fb5dc82d3ad content::BrowserMainLoop::CreateStartupTasks() #19 0x7fb5dc83bfd3 content::BrowserMainRunnerImpl::Initialize() #20 0x7fb5dc82a804 content::BrowserMain() #21 0x7fb5de9aae56 content::RunBrowserProcessMain() #22 0x7fb5de9ac3c9 content::ContentMainRunnerImpl::RunBrowser() #23 0x7fb5de9abd27 content::ContentMainRunnerImpl::Run() #24 0x7fb5de9a9106 content::RunContentProcess() #25 0x7fb5de9a9a3d content::ContentMain() #26 0x563646f1cb13 content::BrowserTestBase::SetUp() #27 0x563645acb283 InProcessBrowserTest::SetUp() #28 0x563645ab3802 extensions::ExtensionBrowserTest::SetUp() #29 0x56364163b48b testing::internal::HandleSehExceptionsInMethodIfSupported<>() #30 0x56364162ee67 testing::internal::HandleExceptionsInMethodIfSupported<>() Original change's description: > Support multiple receivers for Cros APIs. > > With this CL, most of Cros API starts to support multiple receivers. > AshChromeService and LacrosChromeService are exceptions. > > Bug: 1148448 > Test: Build and run Lacros on a DUT. > Change-Id: I1d1a0be111108ae15657d81ea747750a760bd2f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624323 > Reviewed-by: James Cook <[email protected]> > Commit-Queue: Hidehiko Abe <[email protected]> > Cr-Commit-Position: refs/heads/master@{#842869} [email protected],[email protected],[email protected] Change-Id: Id097eab1934d9a2afca29f249a007de57ef18d90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1148448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626229 Reviewed-by: Maxim Kolosovskiy <[email protected]> Commit-Queue: Maxim Kolosovskiy <[email protected]> Cr-Commit-Position: refs/heads/master@{#842943}

…vice" This reverts commit 85753b0. Reason for revert: I suspect this CL caused failures SubresourceRedirectLoggedInSitesBrowserTest.TestCancelBeforeImageLoadForLoggedInSite https://ci.chromium.org/ui/p/chromium/builders/ci/linux-lacros-tester-rel/6414/overview Fontconfig error: Cannot load default config file: No such file: (null) BrowserTestBase received signal: Terminated. Backtrace: #0 0x5596f4879789 base::debug::CollectStackTrace() #1 0x5596f47e4163 base::debug::StackTrace::StackTrace() #2 0x5596f4dcc0c6 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f128ca544c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x7f12902ec9ff __libc_send #5 0x5596f2a8598f mojo::core::ChannelPosix::WriteNoLock() #6 0x5596f2a854b2 mojo::core::ChannelPosix::Write() #7 0x5596f2a7370e mojo::core::NodeChannel::SendChannelMessage() #8 0x5596f2a7808a mojo::core::NodeController::SendPeerEvent() #9 0x5596f2a78707 mojo::core::NodeController::ForwardEvent() #10 0x5596f6c728d2 mojo::core::ports::Node::SendUserMessageInternal() #11 0x5596f6c72720 mojo::core::ports::Node::SendUserMessage() #12 0x5596f2a768e1 mojo::core::NodeController::SendUserMessage() #13 0x5596f2a71afe mojo::core::MessagePipeDispatcher::WriteMessage() #14 0x5596f2a6744c mojo::core::Core::WriteMessage() #15 0x5596f579b850 mojo::Connector::Accept() #16 0x5596f579d9db mojo::InterfaceEndpointClient::SendMessageWithResponder() #17 0x5596f579dd5f mojo::InterfaceEndpointClient::AcceptWithResponder() #18 0x5596f26f4662 content::mojom::ChildHistogramFetcherProxy::GetChildNonPersistentHistogramData() #19 0x5596f2d9b2aa content::HistogramController::GetHistogramData() #20 0x5596f2d9c905 content::HistogramSynchronizer::RegisterAndNotifyAllProcesses() #21 0x5596f2d9ca56 content::FetchHistogramsAsynchronously() #22 0x5596f4dd4781 content::FetchHistogramsFromChildProcesses() #23 0x5596f52f70fa subresource_redirect::RetryForHistogramUntilCountReached() #24 0x5596f0f9d3d1 subresource_redirect::SubresourceRedirectLoggedInSitesBrowserTest_TestCancelBeforeImageLoadForLoggedInSite_Test::RunTestOnMainThread() #25 0x5596f4dcb6e9 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #26 0x5596f491e0aa ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #27 0x5596f491cea5 ChromeBrowserMainParts::PreMainMessageLoopRun() #28 0x5596f2c33516 content::BrowserMainLoop::PreMainMessageLoopRun() #29 0x5596f30a1833 content::StartupTaskRunner::RunAllTasksNow() #30 0x5596f2c324f9 content::BrowserMainLoop::CreateStartupTasks() #31 0x5596f2c34e78 content::BrowserMainRunnerImpl::Initialize() #32 0x5596f2c30c28 content::BrowserMain() #33 0x5596f373dc93 content::ContentMainRunnerImpl::RunBrowser() #34 0x5596f373d886 content::ContentMainRunnerImpl::Run() #35 0x5596f373ad84 content::RunContentProcess() chromium#36 0x5596f373b70c content::ContentMain() #37 0x5596f4dcac68 content::BrowserTestBase::SetUp() #38 0x5596f47d0edb InProcessBrowserTest::SetUp() chromium#39 0x5596f0f9e065 subresource_redirect::SubresourceRedirectLoggedInSitesBrowserTest::SetUp() #40 0x5596f1cf66e8 testing::Test::Run() #41 0x5596f1cf757f testing::TestInfo::Run() chromium#42 0x5596f1cf7f57 testing::TestSuite::Run() #43 0x5596f1d05777 testing::internal::UnitTestImpl::RunAllTests() #44 0x5596f1d050df testing::UnitTest::Run() #45 0x5596f48d0724 base::TestSuite::Run() #46 0x5596f47b935f ChromeTestSuiteRunner::RunTestSuite() #47 0x5596f4dfaab7 content::LaunchTests() #48 0x5596f47b9632 LaunchChromeTests() #49 0x5596f47b6df4 main #50 0x7f128ca3f840 __libc_start_main #51 0x5596f008526a _start [ RUN ] SubresourceRedirectLoggedInSitesBrowserTest.TestCancelBeforeImageLoadForLoggedInSite Original change's description: > [Safe Browsing] Abstract signin dep from RealTimeUrlLookupService > > This CL continues with the abstraction of dependencies on signin and > sync from //components/safe_browsing's access token fetching flow in > order to enable reuse by WebLayer. The concrete step taken here is to > abstract the dependencies on > //components/safe_browsing/core/browser/sync from > RealTimeUrlLookupService, passing these dependencies in via the > constructor. There are no behavioral changes in this CL: > - //chrome and //ios/chrome's factories glue the relevant parameters > from //components/safe_browsing/core/browser/sync > - //weblayer's factory passes in values for the parameters such that > access token fetching for URL lookups continues to be disabled in > WebLayer > > Followup work will bring up support for access token fetching in > WebLayer. > > Bug: 1080748 > Change-Id: I69fca4b2d04118088bb48596eb192beab7bafb4f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621301 > Reviewed-by: Sylvain Defresne <[email protected]> > Reviewed-by: Xinghui Lu <[email protected]> > Commit-Queue: Colin Blundell <[email protected]> > Cr-Commit-Position: refs/heads/master@{#842942} [email protected],[email protected],[email protected],[email protected] Change-Id: I9aa193871848c7e07353bb2bb428a2a39ba5cb00 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1080748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627391 Reviewed-by: Maxim Kolosovskiy <[email protected]> Commit-Queue: Maxim Kolosovskiy <[email protected]> Cr-Commit-Position: refs/heads/master@{#842980}

Queue updateDynamicRules and updateSessionRules API calls to ensure: 1. They only execute once the initial rulesets are loaded from disk. 2. Successive API calls for the same extension execute in a FIFO order. 3. Only one of these calls for an extension executes at a time. Requirement #3 is needed to implement a shared rules limit for session and dynamic rules. The first requirement is needed for only dynamic rules to ensure the initial state for dynamic rules is first loaded up. This replaces the existing base::OneShot mechanism for fulfilling requirement #1. To ensure consistency, we also do the same for updateEnabledRulesets API calls. Doc=https://docs.google.com/document/d/1FZuuQkG8Tl4ee_K3Ls37iFhjynqStfDjApPvB1N8qsw/edit?usp=sharing&resourcekey=0-kZHQzo1D3pIDAFgYoTSV5g BUG=1043200 Change-Id: I4efef10c6d917c600f90f985c105164aa141610b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579716 Commit-Queue: Karan Bhatia <[email protected]> Reviewed-by: Devlin <[email protected]> Cr-Commit-Position: refs/heads/master@{#843232}

This reverts commit 640009e. Reason for revert: The original CL looks wrongly identified as a cause of test breakage. Even without this CL, the test is flaky. Original change's description: > Revert "Support multiple receivers for Cros APIs." > > This reverts commit 8aca3b4. > > Reason for revert: I suspect the CL caused WindowOpenApiTest.PopupBlockingExtension failure > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/22177/overview > > [ RUN ] WindowOpenApiTest.PopupBlockingExtension > 2021-01-13T05:48:40.927570Z INFO browser_tests[28993:28993]: [content_main_runner_impl.cc(1055)] Chrome is running in full browser mode. > 2021-01-13T05:48:41.111260Z WARNING browser_tests[28993:28993]: [audio_manager_linux.cc(69)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. > 2021-01-13T05:48:41.147293Z ERROR browser_tests[28993:28993]: [cras_audio_handler.cc(1627)] Failed to retrieve WBS mic deprioritized flag > 2021-01-13T05:48:41.148942Z WARNING browser_tests[28993:29172]: [statistics_provider.cc(321)] Finished loading statistics. > 2021-01-13T05:48:41.786294Z WARNING browser_tests[28993:28993]: [user_policy_manager_builder_chromeos.cc(123)] No policy loaded for known non-enterprise user > 2021-01-13T05:48:42.161192Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? > 2021-01-13T05:48:42.192143Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:42.205962Z ERROR browser_tests[28993:28993]: [proximity_auth_profile_pref_manager.cc(192)] Failed to find local state prefs for current user. > 2021-01-13T05:48:42.726389Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? > 2021-01-13T05:48:43.054799Z WARNING browser_tests[28993:28993]: [wallpaper_controller_client.cc(377)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. > 2021-01-13T05:48:43.218141Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:43.726830Z WARNING browser_tests[29202:29284]: [http_cache_transaction.cc(1192)] Unable to open or create cache entry > 2021-01-13T05:48:44.322210Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:44.376219Z ERROR browser_tests[28993:28993]: [plugin_vm_manager_impl.cc(141)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? > 2021-01-13T05:48:44.859368Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(495)] One-time key permissions migration started for token: 0. > 2021-01-13T05:48:44.863796Z INFO browser_tests[28993:28993]: [android_sms_pairing_state_tracker_impl.cc(72)] No Pairing cookie found > 2021-01-13T05:48:45.010359Z ERROR browser_tests[28993:29140]: [object_proxy.cc(621)] Failed to call method: org.chromium.U2F.IsUvpaa: object_path= /org/chromium/U2F: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.U2F was not provided by any .service files > 2021-01-13T05:48:45.018258Z ERROR browser_tests[28993:29172]: [als_reader.cc(47)] Missing num of als > 2021-01-13T05:48:45.681453Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:45.682492Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:45.685002Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(520)] One-time key permissions migration succeeded for token: 0. > 2021-01-13T05:48:45.768048Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:45.769933Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:46.230042Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:50.078030Z ERROR browser_tests[28993:29172]: [object_proxy.cc(621)] Failed to call method: org.chromium.debugd.GetPerfOutputFd: object_path= /org/chromium/debugd: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.debugd was not provided by any .service files > 2021-01-13T05:49:10.763123Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico > 2021-01-13T05:49:10.833186Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico > ../../chrome/browser/extensions/window_open_apitest.cc:91: Failure > Expected equality of these values: > num_browsers > Which is: 4 > chrome::GetBrowserCount(browser->profile()) > Which is: 2 > Google Test trace: > ../../chrome/browser/extensions/window_open_apitest.cc:76: WaitForTabsPopupsApps tabs:5, popups:2, app_popups:1 > Stack trace: > #0 0x56363e71a458 extensions::WaitForTabsPopupsApps() > #1 0x56363e71c5aa extensions::WindowOpenApiTest_PopupBlockingExtension_Test::RunTestOnMainThread() > #2 0x563646f1d248 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > #3 0x563646f207ca base::internal::FunctorTraits<>::Invoke<>() > #4 0x563646f20741 base::internal::InvokeHelper<>::MakeItSo<>() > #5 0x563646f206e7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE > #6 0x563646f2068c base::internal::Invoker<>::RunOnce() > #7 0x56363c76ba61 _ZNO4base12OnceCallbackIFvvEE3RunEv > #8 0x563645c03021 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > #9 0x563645c01fc2 ChromeBrowserMainParts::PreMainMessageLoopRun() > #10 0x563640599fc6 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > #11 0x7fb5dc82e9e5 content::BrowserMainLoop::PreMainMessageLoopRun() > #12 0x7fb5dc8383ca base::internal::FunctorTraits<>::Invoke<>() > #13 0x7fb5dc8382e1 base::internal::InvokeHelper<>::MakeItSo<>() > #14 0x7fb5dc838267 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE > #15 0x7fb5dc83820c base::internal::Invoker<>::RunOnce() > #16 0x7fb5dcc03581 _ZNO4base12OnceCallbackIFivEE3RunEv > #17 0x7fb5dda03df6 content::StartupTaskRunner::RunAllTasksNow() > #18 0x7fb5dc82d3ad content::BrowserMainLoop::CreateStartupTasks() > #19 0x7fb5dc83bfd3 content::BrowserMainRunnerImpl::Initialize() > #20 0x7fb5dc82a804 content::BrowserMain() > #21 0x7fb5de9aae56 content::RunBrowserProcessMain() > #22 0x7fb5de9ac3c9 content::ContentMainRunnerImpl::RunBrowser() > #23 0x7fb5de9abd27 content::ContentMainRunnerImpl::Run() > #24 0x7fb5de9a9106 content::RunContentProcess() > #25 0x7fb5de9a9a3d content::ContentMain() > #26 0x563646f1cb13 content::BrowserTestBase::SetUp() > #27 0x563645acb283 InProcessBrowserTest::SetUp() > #28 0x563645ab3802 extensions::ExtensionBrowserTest::SetUp() > #29 0x56364163b48b testing::internal::HandleSehExceptionsInMethodIfSupported<>() > #30 0x56364162ee67 testing::internal::HandleExceptionsInMethodIfSupported<>() > > > > Original change's description: > > Support multiple receivers for Cros APIs. > > > > With this CL, most of Cros API starts to support multiple receivers. > > AshChromeService and LacrosChromeService are exceptions. > > > > Bug: 1148448 > > Test: Build and run Lacros on a DUT. > > Change-Id: I1d1a0be111108ae15657d81ea747750a760bd2f8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624323 > > Reviewed-by: James Cook <[email protected]> > > Commit-Queue: Hidehiko Abe <[email protected]> > > Cr-Commit-Position: refs/heads/master@{#842869} > > [email protected],[email protected],[email protected] > > Change-Id: Id097eab1934d9a2afca29f249a007de57ef18d90 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1148448 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626229 > Reviewed-by: Maxim Kolosovskiy <[email protected]> > Commit-Queue: Maxim Kolosovskiy <[email protected]> > Cr-Commit-Position: refs/heads/master@{#842943} [email protected],[email protected],[email protected],[email protected] # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1148448 Change-Id: Ic2ec65fa476b9b67a705497aad1cf3f1bffa0da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633482 Reviewed-by: James Cook <[email protected]> Reviewed-by: Maxim Kolosovskiy <[email protected]> Commit-Queue: Hidehiko Abe <[email protected]> Cr-Commit-Position: refs/heads/master@{#844778}

This reverts commit d2adbc5. Reason for revert: causing ~600 html failures on tests Example stack trace STDERR: Received signal 11 SEGV_MAPERR 000000000099 STDERR: #0 0x56419ad17d39 base::debug::CollectStackTrace() STDERR: #1 0x56419ac8fc63 base::debug::StackTrace::StackTrace() STDERR: #2 0x56419ad178e1 base::debug::(anonymous namespace)::StackDumpSignalHandler() STDERR: #3 0x7f96ed01d390 (/lib/x86_64-linux-gnu/libpthread-2.23.so+0x1138f) STDERR: #4 0x56419c8a9228 WTF::StaticSingleton<>::StaticSingleton<>() STDERR: #5 0x56419c8a90cc blink::CounterStyleMap::GetUACounterStyleMap() STDERR: #6 0x56419c8da407 blink::StyleEngine::FindCounterStyleAcrossScopes() STDERR: #7 0x56419ce564a7 blink::ListMarker::GetCounterStyle() STDERR: #8 0x56419ce5640e blink::ListMarker::GetListStyleCategory() STDERR: #9 0x56419ce56d3e blink::ListMarker::InlineMarginsForInside() STDERR: #10 0x56419c8846ae blink::StyleAdjuster::AdjustComputedStyle() STDERR: #11 0x56419c877f3c blink::StyleResolver::PseudoStyleForElement() STDERR: #12 0x56419c964063 blink::Element::StyleForPseudoElement() STDERR: #13 0x56419c9a6bd9 blink::PseudoElement::CustomStyleForLayoutObject() STDERR: #14 0x56419c95b52f blink::Element::StyleForLayoutObject() etc see e.g. https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20Leak/22892/test-results Original change's description: > Refactor counter style updates > > Currently, counter style updates is a phase in UpdateActiveStyles. This > patch moves it out as a standalone phase of UpdateStyleAndLayoutTree, > so that we update counter styles only when needed. > > This patch also adds MarkCounterStylesNeedUpdate() to indicate whether > counter style updates are needed. > > Note: After refactoring, the framework of counter style updates looks > almost identical to font updates. This is intentional. We will try to > unify them in the future. > > Bug: 687225 > Change-Id: If07de2878ae5faa6800644a967029a569bef566a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639535 > Reviewed-by: Rune Lillesveen <[email protected]> > Reviewed-by: Anders Hartvoll Ruud <[email protected]> > Commit-Queue: Xiaocheng Hu <[email protected]> > Cr-Commit-Position: refs/heads/master@{#846203} [email protected],[email protected],[email protected],[email protected] Change-Id: I3c1e09dce14cd4edb366b911d3aaf5da66b2b100 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 687225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644742 Reviewed-by: Nina Satragno <[email protected]> Commit-Queue: Nina Satragno <[email protected]> Cr-Commit-Position: refs/heads/master@{#846262}

This reverts commit 0eb6b1e. Reason for revert: Suspect causing ash_unittests failure on linux-chromeos-dbg Builder: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg First build failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/22344 Sample stacktrace: [1/5610] AcceleratorCommandsTest.ToggleMinimized (1848 ms) [ RUN ] AcceleratorCommandsTest.ToggleMaximized [capture_mode_controller.cc(307)] Check failed: !message_center::MessageViewFactory::HasCustomNotificationViewFactory( kScreenCaptureNotificationType). #0 0x7f29bf492bbf base::debug::CollectStackTrace() #1 0x7f29bf22770a base::debug::StackTrace::StackTrace() #2 0x7f29bf2276c5 base::debug::StackTrace::StackTrace() #3 0x7f29bf270d17 logging::LogMessage::~LogMessage() #4 0x7f29bf271419 logging::LogMessage::~LogMessage() #5 0x7f29bf1e80bb logging::CheckError::~CheckError() #6 0x7f29c3a68b49 ash::CaptureModeController::CaptureModeController() #7 0x7f29c3e2eceb std::__Cr::make_unique<>() #8 0x7f29c3e1fa8b ash::Shell::Init() #9 0x7f29c3e1f5de ash::Shell::CreateInstance() #10 0x55fa098eea0e ash::AshTestHelper::SetUp() #11 0x55fa098ebdc8 ash::AshTestBase::SetUp() #12 0x55fa098ebc0e ash::AshTestBase::SetUp() Original change's description: > capture mode: implement customized image capture notification. > > Bug: 1159111 > Change-Id: I5a96480a929a05a7782f51ae6baea8ddc7c9df10 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632390 > Reviewed-by: Evan Stade <[email protected]> > Reviewed-by: Ahmed Fakhry <[email protected]> > Commit-Queue: Xiaoqian Dai <[email protected]> > Cr-Commit-Position: refs/heads/master@{#846957} [email protected],[email protected],[email protected],[email protected] Change-Id: Id535618e328a75dbc829d8b662c8dc99dfe25f21 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1159111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2648987 Reviewed-by: Takashi Sakamoto <[email protected]> Reviewed-by: Ahmed Fakhry <[email protected]> Commit-Queue: Ahmed Fakhry <[email protected]> Cr-Commit-Position: refs/heads/master@{#847060}

Use SequenceChecker::EnableStackLogging() to enable this logging. When DCHECK() fails for a ThreadChecker or SequenceChecker, if the error is not at the site of checking, it takes a great amount of knowledge and persistence to figure out where the erroroneous thread/sequence- attachment occurred. This is especially fun for a WeakPtr, which if checked on the wrong thread becomes bound to the thread. Then if the WeakPtrFactory is invalidated later, it's difficult to determine why it believes it is on the wrong thread. This adds a copy of the StackTrace in SequenceChecker and ThreadChecker that is set whenever they are bound to a thread/sequence. Then on failure the DCHECK() callers will get back a copy of the StackTrace and include it in the log message. WeakPtr calls the SequenceChecker manually instead of using the macros, since it has an additional condition so we also add the StackTrace to the message there. The StackTrace logging slows things down a bit, enough that we'd slow bots down without good reason, so the logging is optional. You may use SequenceChecker::EnableStackLogging() to enable this logging, or the equivalent alias ThreadChecker::EnableStackLogging(). Example output with stack logging enabled: [890744:1:1201/174351.878197:FATAL:weak_ptr.cc(23)] Check failed: sequence_checker_.CalledOnValidSequence(&bound_at) || HasOneRef(). WeakPtrs must be invalidated on the same sequenced thread as where they are bound. This was bound at: #0 0x7fd813c8d369 base::debug::CollectStackTrace() #1 0x7fd813b94103 base::debug::StackTrace::StackTrace() #2 0x7fd813c70aef base::ThreadCheckerImpl::ThreadCheckerImpl() #3 0x7fd813c02155 base::SequenceCheckerImpl::CalledOnValidSequence() #4 0x7fd813ba4f55 base::ScopedValidateSequenceChecker::ScopedValidateSequenceChecker() #5 0x7fd813bbfa4f base::internal::WeakReference::IsValid() #6 0x7fd80acd0f36 blink::FrameWidgetInputHandlerImpl::FrameWidgetInputHandlerImpl() [...] Check failed at: #0 0x7fd813c8d369 base::debug::CollectStackTrace() #1 0x7fd813b94103 base::debug::StackTrace::StackTrace() #2 0x7fd813bb3c53 logging::LogMessage::~LogMessage() #3 0x7fd813bb45ae logging::LogMessage::~LogMessage() #4 0x7fd813bbf91c base::internal::WeakReference::Flag::Invalidate() #5 0x7fd813bbfc8c base::internal::WeakReferenceOwner::Invalidate() #6 0x7fd80ca6eda7 blink::WebFrameWidgetImpl::Close() #7 0x7fd80ff22359 content::RenderWidget::Close() #8 0x7fd80ff21eff content::RenderWidget::CloseForFrame() [...] [email protected] Change-Id: Id89c12eaedfba9788b3cd2624447c6a1616f0afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568446 Commit-Queue: danakj <[email protected]> Reviewed-by: Gabriel Charette <[email protected]> Reviewed-by: Nico Weber <[email protected]> Cr-Commit-Position: refs/heads/master@{#847805}

…by default" This reverts commit ba96414. Reason for revert: failing unit_tests on linux-chromeos-chrome with NOTREACHED(). Failing tests: MediaToolbarButtonControllerTest.DoesNotDisableButtonIfDialogIsOpen MediaToolbarButtonControllerTest.DoesNotHideIfMediaStartsPlayingWithinTimeout MediaToolbarButtonControllerTest.HidesAfterTimeoutAndShowsAgainOnPlay Example: RUN ] MediaToolbarButtonControllerTest.HidesAfterTimeoutAndShowsAgainOnPlay 2021-02-03T04:04:47.546579Z 564170770 ERROR unit_tests[2535:2535]: [pref_change_registrar.cc(40)] NOTREACHED() hit. Received signal 11 SEGV_MAPERR 000000000038 #0 0x5611b0dbfe29 base::debug::CollectStackTrace() #1 0x5611b0d2f4d3 base::debug::StackTrace::StackTrace() #2 0x5611b0dbf9d1 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7f9eb128f390 (/lib/x86_64-linux-gnu/libpthread-2.23.so+0x1138f) #4 0x5611ac59c5fe std::__1::__hash_table<>::find<>() #5 0x5611b1c25762 PrefService::FindPreference() #6 0x5611b11a2169 media_router::GetCastAllowAllIPsPref() #7 0x5611b2fd159b media_router::CastMediaSinkService::CreateImpl() #8 0x5611b2fd138f media_router::CastMediaSinkService::Start() #9 0x5611b2fad704 media_router::DualMediaSinkService::DualMediaSinkService() #10 0x5611b2fad539 media_router::DualMediaSinkService::GetInstance() #11 0x5611b2f93b44 media_router::MediaRouterDesktop::MediaRouterDesktop() #12 0x5611b2f93030 media_router::ChromeMediaRouterFactory::BuildServiceInstanceFor() #13 0x5611b2bdb30f BrowserContextKeyedServiceFactory::BuildServiceInstanceFor() #14 0x5611b1cd2837 KeyedServiceFactory::GetServiceForContext() #15 0x5611b37297b6 CastMediaNotificationProvider::CastMediaNotificationProvider() #16 0x5611b372c274 MediaNotificationService::MediaNotificationService() #17 0x5611abdba814 MediaToolbarButtonControllerTest::SetUp() first failing build: https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/11825/overview Original change's description: > Enable GlobalMediaControlsForCast and CastMediaRouteProvider by default > > The features were enabled via a config change in M87 (CastMRP on CrOS > will soon be enabled in M88). This change enables them by default. > > Bug: 1042330, 869214 > Change-Id: I111bd1f6d13bf70cf7557004205e7de1dc3e23ec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631191 > Reviewed-by: Peter Kasting <[email protected]> > Reviewed-by: John Williams <[email protected]> > Reviewed-by: Mounir Lamouri <[email protected]> > Commit-Queue: Takumi Fujimoto <[email protected]> > Cr-Commit-Position: refs/heads/master@{#849910} [email protected],[email protected],[email protected],[email protected],[email protected] Change-Id: I215a231257e91dd81348577221892fb6b297677d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1042330 Bug: 869214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2671781 Reviewed-by: Olga Sharonova <[email protected]> Commit-Queue: Olga Sharonova <[email protected]> Cr-Commit-Position: refs/heads/master@{#850027}

Wowfunhappy · 2021-02-06T19:50:47Z

Hello again!

Now that I've switched to Chromium Legacy as my primary browser, I needed an easy way to keep it updated, and to automatically apply some customizations I like. I ended up writing an Applescript, which I then turned into a Preference Pane, because System Preferences seemed like the least-obnoxious place for it to live.

You will be provided with the option to download the latest 15 builds, and downloads are cached for a time in OS X's temporary directory, to make it easy to revert to an older version if a newer build does not work.

Note that in addition to downloading Chromium, this preference pane will:

Change the icon to better fit the old Aqua UI.
Add the --no-proxy flag for compatibility with Squid, which I use to fix older apps without modern https support.
Change some defaults (policies) which I find obnoxious, such as hiding full URLs in the address bar. These can always be switched back in Chromium's settings.
In 10.9 only, apply a set of workarounds to prevent Chromium from crashing. I plan to remove this whenever the problems are fixed officially.

The whole thing is just shell commands and Applescript, so feel free to make edits as desired! (Right click the .prefpane and use "Show Package Contents", then navigate to Contents > Resources).

Enjoy!

https://jonathanalland.com/downloads/chromium-legacy-downloader.zip

LeeBinder · 2021-02-06T21:06:08Z

Very neat, thank you, Jonathan. It's working perfectly on my main rig (64bit, naturally) but not on my older backup MacBook with Lion which runs in x86 mode. The script runs but only via AppleScript Editor -> run, neither saved as an app nor as a script bundle, not even after I copied the entire content from inside the pref pane incl. the required libs folder over into their respective locations: Can't get item 1 of {} (-1728).

Would it be complicated for you to also export it from Xcode as 32bit Pref Pane?

Wowfunhappy · 2021-02-06T21:14:19Z

I should be able to compile the Prefpane with 32bit support, but, does Chromium Legacy itself work on 32bit Macs? It looks like it's a 64 bit binary.

LeeBinder · 2021-02-06T21:18:05Z

That MacBook has a 64bit CPU so even though Lion itself runs in 32bit mode because the chipset is 32bit and can only address 3GB of RAM, 64bit apps run just fine. I upgraded it with a super-fast SSD and I'm very happy with it as a 2ndary MacBook with a still quite accentuated 17" matte screen & working sound, all for $40 :)

Wowfunhappy · 2021-02-06T21:23:27Z

Got it! Okay, I'll look at it a bit later, feel free to ping me in a few days if I forget. I'm a little nervous because I recall reading something in Apple's documentation about how 32bit Preference Panes actually use a different style of memory management or something like that, but then, it's also literally < 10 lines of code...

LeeBinder · 2021-02-06T21:26:22Z

Awesome, that would be neat 👍 - fingers crossed!

Wowfunhappy · 2021-02-06T22:39:19Z

Okay @LeeBinder, want to try it again? Same link.

Fixes HTTPTransport tests that fail with: Uninitialized bytes in __interceptor_fopen64 at offset 0 inside [0x70200001ce60, 25) ==3342==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x7f115b1ef5d9 in BIO_new_file ??:0:0 #1 0x7f115b22117d in COMP_CTX_get_type ??:? #2 0x7f115b22278c in CONF_modules_load_file ??:0:0 #3 0x7f115b222a4f in OPENSSL_config ??:? #4 0x7f115b2b94f3 in HMAC_CTX_get_md ??:? #5 0x7f115ed084de in __pthread_once_slow ??:0:0 #6 0x7f115b324aac in CRYPTO_THREAD_run_once ??:0:0 #7 0x7f115b2b9b77 in OPENSSL_init_crypto ??:0:0 #8 0x7f115dfa3574 in OPENSSL_init_ssl ??:0:0 R=thestig Change-Id: Ie6aa3223df4d50dedcc59c2f757de62ff35ac1aa Bug: 1260217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3993372 Reviewed-by: Lei Zhang <[email protected]> Commit-Queue: Thomas Anderson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1065765}

On newer systems (Ubuntu 18.04 and gLinux), the default user config in ~/.pki/nssdb/pkcs11.txt contains: library=/usr/lib/x86_64-linux-gnu/nss/libnssckbi.so library=/usr/lib/x86_64-linux-gnu/onepin-opensc-pkcs11.so While the instrumented libraries have instrumented versions of these, NSS will dlopen() the libraries specified in the user config by absolute pathname. Mixing this MSAN and non-MSAN code leads to a crash: Uninitialized bytes in __interceptor_strcasecmp at offset 0 inside [0x7010000b99a0, 4) ==3981110==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x7f84ad162eb1 in scconf_find_blocks (/lib/x86_64-linux-gnu/libopensc.so.8+0x162eb1) (BuildId: 4de1f962c7a7a52686a1c7baa36e97f4b2c6508e) #1 0x7f84ad021b4c in sc_context_create (/lib/x86_64-linux-gnu/libopensc.so.8+0x21b4c) (BuildId: 4de1f962c7a7a52686a1c7baa36e97f4b2c6508e) #2 0x7f84ad8e152b in C_Initialize (/usr/lib/x86_64-linux-gnu/onepin-opensc-pkcs11.so+0xd52b) (BuildId: 54feb2432ce37108157601eefdf786df9d11236b) #3 0x7f85946aba8b in secmod_ModuleInit /home/dev/chromium_official/src/out/Instrumented-msan-chained-origins/gen/third_party/instrumented_libraries/focal/nss/nss-3.49.1/nss/lib/pk11wrap/pk11load.c:244:11 To workaround this, initialize NSS without cert DBs. Bug: 1260217 Change-Id: Iabccaf741d92c5a9bd8f9453bd57eeb7983494bd Cq-Include-Trybots: luci.chromium.try:linux_chromium_chromeos_msan_rel_ng,linux_chromium_msan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3991395 Reviewed-by: Matt Mueller <[email protected]> Commit-Queue: Thomas Anderson <[email protected]> Reviewed-by: David Benjamin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1067387}

This class removes the friend classes of ProfileDestroyer as they were calling internal methods that bypassed the creation of ProfileDestroyer objects and called DestroyOffTheRecordProfileNow directly, which has led to crashes in the past (https://crbug.com/1337388#c11). Note: This CL changes the behavior of ProfileDestroyer when destroying an off-the-record profile immediately via ProfileDestroyer::DestroyOTRProfileImmediately(). With the new implementation, the CHECK in ~ProfileDestroyer() will trigger and we may see an increase of crashes with this signature. Before this CL, the app will still crash, but in a different code location (see test), with the stack trace below: [456919:456919:FATAL:dependency_manager.cc(173)] Check failed: false. Attempted to access a context that was ShutDown(). This is most likely a heap smasher in progress. After KeyedService::Shutdown() completes, your service MUST NOT refer to depended services again. #0 0x7fe99bc08932 base::debug::CollectStackTrace() #1 0x7fe99bb348a3 base::debug::StackTrace::StackTrace() #2 0x7fe99bb4fff3 logging::LogMessage::~LogMessage() #3 0x7fe99bb50e9e logging::LogMessage::~LogMessage() #4 0x7fe9992b7396 DependencyManager::AssertContextWasntDestroyed() #5 0x7fe996fe7e32 BrowserContextKeyedServiceFactory::GetContextToUse() #6 0x7fe9992b79af KeyedServiceFactory::GetServiceForContext() #7 0x55c217195682 extensions::ChromeContentBrowserClientExtensionsPart::SiteInstanceDeleting() #8 0x55c2162f1f9d ChromeContentBrowserClient::SiteInstanceDeleting() #9 0x7fe99a5bc5af content::SiteInstanceImpl::~SiteInstanceImpl() #10 0x7fe99a5bc6de content::SiteInstanceImpl::~SiteInstanceImpl() #11 0x55c21327864f ProfileDestroyerTest::~ProfileDestroyerTest() Bug: 1378254 Change-Id: Ib144ffe8d2344dc7efc7cd22360e8fce0b2beb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3978432 Reviewed-by: Alex Ilin <[email protected]> Auto-Submit: Mihai Sardarescu <[email protected]> Commit-Queue: Mihai Sardarescu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1067599}

This CL fixes the below MSAN error. This issue is not triggered on the bots because they run on an older release of Ubuntu (Xenial) which lacks loadable vulkan modules (eg libvulkan_radeon.so and libvulkan_intel.so) which are present on newer systems like Ubuntu Focal and gLinux. The system modules cause the error because they are not instrumented with MSAN. Uninitialized bytes in __interceptor_strcmp at offset 0 inside [0x7fffffffa380, 8) [Detaching after fork from child process 2199490] #0 0x7fffee94014c in wsi_unsupported_instance_extension wsi.c #1 0x7fffee8c15f0 in loader_add_instance_extensions loader.c #2 0x7fffee8c0c77 in loader_get_icd_loader_instance_extensions third_party/vulkan-deps/vulkan-loader/src/loader/loader.c:1116:15 #3 0x7fffee8fbe2c in vkCreateInstance third_party/vulkan-deps/vulkan-loader/src/loader/trampoline.c:556:11 ... Change-Id: I2cfbd9404a0d31032b1c9b62929215eaf6b4ca26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4007275 Commit-Queue: Ben Pastene <[email protected]> Reviewed-by: Ben Pastene <[email protected]> Auto-Submit: Thomas Anderson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1068202}

In View::HandleAccessibleAction, accessibility sends both a press and release mouse event to the view instance. Unfortunately, if the view deletes itself immediately after receiving the mouse press event, the subsequent mouse release event causes a UAF. e.g. for illustrative purposes, here's the flow: bool HandleAccessibleAction(...) { view->OnEvent(mouse_press); // |view| is now deleted. view->OnEvent(mouse_release); // UAF. } Fix this by overriding HandleAccessibleAction in the self-deleting view. Notes: The deletion stack for the WindowCycleItemView is #3 0x560338183db8 in operator() buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:49:5 #4 0x560338183db8 in reset buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:281:7 #5 0x560338183db8 in ~unique_ptr buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:247:75 #6 0x560338183db8 in views::View::DoRemoveChildView(views::View*, bool, bool, views::View*) ui/views/view.cc:2739:1 #7 0x560338183fe4 in views::View::RemoveAllChildViews() ui/views/view.cc:341:5 #8 0x560333f50cbb in ash::WindowCycleView::DestroyContents() ash/wm/window_cycle/window_cycle_view.cc:379:3 #9 0x560333f4b3e7 in ash::WindowCycleList::~WindowCycleList() ash/wm/window_cycle/window_cycle_list.cc:139:18 #10 0x560333f4b747 in ash::WindowCycleList::~WindowCycleList() ash/wm/window_cycle/window_cycle_list.cc:117:37 #11 0x560333f475e8 in operator() buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:49:5 #12 0x560333f475e8 in reset buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:281:7 #13 0x560333f475e8 in ash::WindowCycleController::StopCycling() ash/wm/window_cycle/window_cycle_controller.cc:421:22 #14 0x560333f5944c in ash::WindowCycleItemView::OnMousePressed(ui::MouseEvent const&) ash/wm/window_cycle/window_cycle_item_view.cc:53:44 #15 0x560338193ae2 in views::View::ProcessMousePressed(ui::MouseEvent const&) ui/views/view.cc:3109:23 #16 0x56033819362d in views::View::OnMouseEvent(ui::MouseEvent*) ui/views/view.cc:1492:11 Bug: 1380602 Change-Id: I2533dc299c0f5f5bb32efa130e6d564cb70d4613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4046647 Commit-Queue: David Tseng <[email protected]> Reviewed-by: Xiaoqian Dai <[email protected]> Cr-Commit-Position: refs/heads/main@{#1076637}

Change-Id: I893e2d71c9b52290d8961b147ae103b9ae4b32af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4072704 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5359_71@{#3} Cr-Branched-From: 1e0e386-refs/branch-heads/5359@{#1016} Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}

The current event de-duping mechanism walks through the vector of events each time an event is added. Another benefit is that this fixes some broken tests for the upcoming CL:4062111, which implements stable ids for AXObjects. In that CL, events were deduped when they shouldn't be, after an object was destroyed and recreated but had the same id, causing unintended code paths. Specifics of this change: 1. Keeps de-duping for dirty object serialization, via the already_serialized_ids_ mechanism. Note that over time we are removing a11y events from Blink and just marking objects dirty instead. 2. Does no processing on events where de-duping is unnecessary, e.g. Event::kExpanded or Event::kChecked. 3. Adds specialized event deduping mechanisms for the events that make sense: kLocationChanged, kLayoutComplete, kValueChanged. 4. Allows duplicate events where it is deemed harmless: kActiveDescendantChanged, kAriaAttributeChanged, kCheckedStateChanged, kClicked, kDocumentSelectionChanged, kDocumentTitleChanged, kBlur, kFocus, kHide, kShow, kHitTestResult, kLoadComplete, kLoadStart, kMenuListValueChanged, kRowCountChanged, kScrolledToAnchor, kSelectedChildrenChanged. These plus the events in bullet #3 were the only events where duplicates were detected when testing with NOTREACHED. Bug: none Change-Id: I726da94892e7af557fad45e6ef052b3b6ea587e5 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4060563 Reviewed-by: David Tseng <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: Aaron Leventhal <[email protected]> Auto-Submit: Aaron Leventhal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1078296}

…ols\unit\soft-context-menu.js This is the 1st of 3 CLs to update DevTools soft context default focus behavior: CL #1: disable test third_party\blink\web_tests\http\tests\devtools\unit\soft-context-menu.js in chromium.src repo (current CL) CL #2: update DevTools soft context menu default focus behavior in chromium.devtools-frontend repo (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4066166). CL #3: update and re-enable test third_party\blink\web_tests\http\tests\devtools\unit\soft-context-menu.js in chromium.src repo (https://chromium-review.googlesource.com/c/chromium/src/+/4071205). Bug: 1394898 Change-Id: Ic488a0c24efdc239938868c82b3756a2330910b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4066995 Commit-Queue: Guangyue Xu <[email protected]> Reviewed-by: Alex Rudenko <[email protected]> Cr-Commit-Position: refs/heads/main@{#1078471}

update test results for third_party\blink\web_tests\http\tests\devtools\unit\soft-context-menu.js This is the 3rd of 3 CLs to update DevTools soft context default focus behavior: CL #1: disable test third_party\blink\web_tests\http\tests\devtools\unit\soft-context-menu.js in chromium.src repo (https://chromium-review.googlesource.com/c/chromium/src/+/4066995) CL #2: update DevTools soft context menu default focus behavior in chromium.devtools-frontend repo (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4066166). CL #3: update and re-enable test third_party\blink\web_tests\http\tests\devtools\unit\soft-context-menu.js in chromium.src repo (current CL). Bug: 1394898 Change-Id: If311f9d71c5575a84e75533ed25ae88309a8b86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4071205 Reviewed-by: Alex Rudenko <[email protected]> Commit-Queue: Guangyue Xu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1078661}

This CL transforms Read Anything's WebUI into an AT, meaning it: 1. Keeps a copy of one AXTree per tab. 2. Observes accessibility events from Chrome and updates its AXTree copy to match. 3. When one of its AXTree copies changes, updates its view. To accomplish the above, this CL does the following: 1. Enable WebContentsOnlyAXMode on each web contents. In a follow-up, only enable the ReadAnything AXMode. 2. Introduce ReadAnythingWebContentsObserver in the browser which observes each web contents as a user data. Create one per tab. 3. ReadAnythingWebContentsObserver observes accessibility events and passes them to ReadAnythingAppController in the renderer process via ReadAnythingController --> ReadAnythingModel --> ReadAnythingPageHandler --> ReadAnythingAppController. In a follow- up, remove some of these steps. 4. When ReadAnythingAppController receives an accessibility event, it merges and unserializes the updates. 5. When the tab changes, ReadAnythingController sends ReadAnythingAppController the AXTreeID of the main RFH from the active web contents via the same pathway as #3. 6. When ReadAnythingAppController receives an updated AXTreeID, it stores it and distills the currently active AXTree. 7. The ReadAnythingAppController is an AXTreeObserver. When the active AXTree changes, re-distills and/or re-draws the AXTree depending on what changed. See go/read-anything-as-at for more information. Bug: 1266555 Change-Id: Id8a0b0c826b9f747478e68cb902a67602773934b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4090829 Reviewed-by: David Tseng <[email protected]> Commit-Queue: Abigail Klein <[email protected]> Reviewed-by: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1091558}

This CL will update lacros version in //chrome/LACROS_QA_QUALIFIED_VERSION. This file will be used in Upreving the RootFS-Lacros in the CROS image. If this CL caused regressions, please revert and pause the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-qa-qualified-tracking-roller Also please file a bug to OS>LaCrOS>Partner, and CC [email protected], [email protected]. [email protected] Change-Id: I8059efa0a984b4055e1658bf075165921a158085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4113661 Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Auto-Submit: lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com <lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5481@{#3} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}

Note: we might need to rethink how we handle non-element nodes detected here as it might influence accuracy, but that needs to happen after broader testing when we have more concrete examples to work on. (cherry picked from commit 5509ed5) (cherry picked from commit c40ad60) Bug: 1406346 Change-Id: I8c44eaaa038fa6483ca3e9bcb1604a097d03fe47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4149723 Commit-Queue: Yue Zhang <[email protected]> Reviewed-by: Wei-Yin Chen <[email protected]> Cr-Original-Original-Commit-Position: refs/heads/main@{#1091102} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4157873 Reviewed-by: Prudhvikumar Bommana <[email protected]> Owners-Override: Prudhvikumar Bommana <[email protected]> Auto-Submit: Yue Zhang <[email protected]> Commit-Queue: Prudhvikumar Bommana <[email protected]> Cr-Original-Commit-Position: refs/branch-heads/5532@{#3} Cr-Original-Branched-From: 055a5ee-refs/heads/main@{#1091039} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4178591 Commit-Queue: Wei-Yin Chen <[email protected]> Cr-Commit-Position: refs/branch-heads/5481@{#441} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}

Deeper levels of the system in Blink determine the file type based on the display name, and so if extensions are omitted, they fail. (cherry picked from commit a3d2de2) Fixed: 1412205 Change-Id: I6a9ab49c5d053e90d9da54d1beadf79797c6c078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4215355 Auto-Submit: Avi Drissman <[email protected]> Commit-Queue: Leonard Grey <[email protected]> Reviewed-by: Leonard Grey <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1100431} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4240384 Reviewed-by: Bo Liu <[email protected]> Commit-Queue: Avi Drissman <[email protected]> Cr-Commit-Position: refs/branch-heads/5481_77@{#3} Cr-Branched-From: 65ed616-refs/branch-heads/5481@{#839} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}

RJVB · 2023-02-25T21:59:34Z

FWIW, I just used the prefpane updater and all my Finder windows were closed for some reason?

Wowfunhappy · 2023-02-26T00:26:22Z

FWIW, I just used the prefpane updater and all my Finder windows were closed for some reason?

Did you select to install Widevine? The PrefPane needs to download the official Chrome DMG and mount it to extract the Widevine libraries. During this process, the PrefPane quits Finder to prevent the mounted Google Chrome DMG window from popping up. This used to confuse a lot of users.

RJVB · 2023-02-26T11:27:55Z

On Saturday February 25 2023 16:26:32 Jonathan wrote: > FWIW, I just used the prefpane updater and all my Finder windows were closed for some reason? Did you select to install Widevine? The PrefPane needs to download the official Chrome DMG and mount it to extract the Widevine libraries. During this process, the PrefPane quits Finder to prevent the mounted Google Chrome DMG window from popping up. This used to confuse a lot of users.

I didn't see/notice an option to install Widevine or not. It certainly looked like the Finder was quit but normally it reopens all open windows when it is restarted. That didn't happen here. Note that MacPorts also has the logic in "base" to install things from official DMGs, and those are mounted without anything showing in the Finder and without the Finder being quit.

This migrates TaskQueueBase sub classes to the location and traits-based API, enabling WebRTC traces with location information in Perfetto. Bug: 1416199 Change-Id: I9cd6a78fa38271a38c901713026b5b19825df272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4254390 Reviewed-by: Henrik Boström <[email protected]> Reviewed-by: Mirko Bonadei <[email protected]> Commit-Queue: Markus Handell <[email protected]> Cr-Commit-Position: refs/heads/main@{#1110897}

Change-Id: I438dad8f7dfcda55aab503c3e80376e5b6b694a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4198157 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5563@{#3} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}

This CL will update lacros version in //chrome/LACROS_QA_QUALIFIED_VERSION. This file will be used in Upreving the RootFS-Lacros in the CROS image. If this CL caused regressions, please revert and pause the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-qa-qualified-tracking-roller Also please file a bug to OS>LaCrOS>Partner, and CC [email protected]. [email protected] Change-Id: I0121116894598362675cdcf965bc135b89f48fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4289374 Auto-Submit: lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com <lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5615@{#3} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}

https://chromium.googlesource.com/v8/v8.git/+log/96fed67922e5..cbae4e69312c 2023-03-31 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 11.2.214.10 2023-03-31 [email protected] Merged: [compiler] Prevent constant folding of TypeGuard If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/v8-chromium-release-1 Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in v8 11.2: https://bugs.chromium.org/p/v8/issues/entry To file a bug in Chromium m112: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md (cherry picked from commit 79ae5fb) Bug: chromium:1427388 Tbr: [email protected] Change-Id: Ie688de565b41868d0163081b81fcf1425d3870cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4388354 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Original-Commit-Position: refs/branch-heads/5615@{#999} Cr-Original-Branched-From: 9c6408e-refs/heads/main@{#1109224} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4425049 Owners-Override: Prudhvikumar Bommana <[email protected]> Reviewed-by: Prudhvikumar Bommana <[email protected]> Commit-Queue: Prudhvikumar Bommana <[email protected]> Cr-Commit-Position: refs/branch-heads/5615_51@{#3} Cr-Branched-From: 86d49da-refs/branch-heads/5615@{#938} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}

This CL will update lacros version in //chrome/LACROS_QA_QUALIFIED_VERSION. This file will be used in Upreving the RootFS-Lacros in the CROS image. If this CL caused regressions, please revert and pause the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-qa-qualified-tracking-roller Also please file a bug to OS>LaCrOS>Partner, and CC [email protected]. [email protected] Change-Id: I964ab4b6b11bdd10ab1821bfbad179fb11033a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4369214 Auto-Submit: lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com <lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5672@{#3} Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}

Change-Id: I7ca16136f4164786c65c979113ab8bbe487e63ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4503351 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5672_63@{#3} Cr-Branched-From: 0e1a447-refs/branch-heads/5672@{#912} Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}

This CL will update lacros version in //chrome/LACROS_QA_QUALIFIED_VERSION. This file will be used in Upreving the RootFS-Lacros in the CROS image. If this CL caused regressions, please revert and pause the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-qa-qualified-tracking-roller Also please file a bug to OS>LaCrOS>Partner, and CC [email protected]. [email protected] Change-Id: Ia84a1f6d33e5e5d1be6e35c783ffd560e453a518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4477247 Commit-Queue: Rubber Stamper <[email protected]> Auto-Submit: lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com <lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{#3} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}

There are some credit card details retrieval flows like local cards, and VCN green path in which the user is not presented with any form of authentication challenge. With the Mandatory Reauth project, we change this, and give users the option to opt-in to be presented with the device authentication challenge in such cases. This change is a part of CLs that implement showing this prompt on a bottom sheet. Change #3: Add the UI in the layout file. Binary size increase: The icons added have been optimized by following https://chromium.googlesource.com/chromium/src/+/HEAD/chrome/app/theme/README.md. The increase in Chromium Binary Size is unavoidable as new image resources are added. Mock: https://www.figma.com/file/kmgEJXiKvgJNmVcDyiR6mK/Configurable-Re-Auth?type=design&node-id=458-29612&t=zvKOwslkP9h9PMe1-4 Screenshot: https://screenshot.googleplex.com/F4JG7mhLfjoJ6fj Implementation doc: http://shortn/_FNEm7HUEaa Binary-Size: See commit description. Bug: 1444556 Change-Id: I8782ab851ad2c4d400d62f5590ffceac3e3890dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4525055 Reviewed-by: Friedrich Horschig <[email protected]> Code-Coverage: Findit <[email protected]> Reviewed-by: Colin Blundell <[email protected]> Commit-Queue: Vishwas Uppoor <[email protected]> Cr-Commit-Position: refs/heads/main@{#1154431}

https://chromium.googlesource.com/v8/v8.git/+log/5e7531112fa5..56e5481171da 2023-06-02 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 11.4.183.19 2023-06-02 [email protected] Merged: [ic] Fix store handler selection for arguments objects If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/v8-11-4-chromium-m114 Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in v8 11.4: https://bugs.chromium.org/p/v8/issues/entry To file a bug in Chromium m114: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1450481 Tbr: [email protected] Change-Id: I346de47c99560a25d16aaade40aee42608365c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582626 Owners-Override: Srinivas Sista <[email protected]> Commit-Queue: Krishna Govind <[email protected]> Reviewed-by: Srinivas Sista <[email protected]> Cr-Commit-Position: refs/branch-heads/5735_90@{#3} Cr-Branched-From: 386bc09-refs/branch-heads/5735@{#1052} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}

The fix for b/280058471 mistakenly removed the access token adding logic from the paste path, this CL just puts it with small tweaks due to conflicts with crrev.com/c/4605787. (cherry picked from commit 5f4fca3) (cherry picked from commit 8738d6f) Bug: b/289225582, 1464689 Change-Id: I79e46580ea1db029687032294812527ae7c29c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4655032 Reviewed-by: Daniel Rubery <[email protected]> Code-Coverage: Findit <[email protected]> Commit-Queue: Dominique Fauteux-Chapleau <[email protected]> Cr-Original-Original-Commit-Position: refs/heads/main@{#1164181} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4685072 Cr-Original-Commit-Position: refs/branch-heads/5790@{#1658} Cr-Original-Branched-From: 1d71a33-refs/heads/main@{#1148114} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4685413 Owners-Override: Prudhvikumar Bommana <[email protected]> Reviewed-by: Prudhvikumar Bommana <[email protected]> Commit-Queue: Prudhvikumar Bommana <[email protected]> Cr-Commit-Position: refs/branch-heads/5790_90@{#3} Cr-Branched-From: 86fb9d0-refs/branch-heads/5790@{#1583} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}

Cherry-picked from crrev.com/c/4771880, with merge conflicts fixed. In late June the source indexing step on Windows builds went from taking about 15 minutes to taking several hours. This is because a rust toolchain directory was added and its files are not mapped in as a git repo. Therefore every one of these files that was referenced in the source information had "git log" run on it, and this command is slow, especially on non-existent files. Source indexing of chrome.dll went from 45 seconds to 4,500 s - 100x slower. Source indexing of gaia1_0.dll was similarly slowed. Nothing else seemed to be affected. The output and C++ toolchain directories are already excluded from source indexing because of this issue, so all we need to do is add another excluded directory. This time I'm adding a --excluded-dirs switch to make it generic and more obvious. I'm also making other changes: 1) The toolchain and output directories used to have to be specified as absolute paths. Passing a relative path would make the script take hours longer. The script should make them absolute, and should fail if the specified directory does not exist. 2) The lack of an encoding passed to subprocess was causing various decode exceptions that presumably caused information to be lost, and also cluttered the output. 3) Some Python 2/3 compatibility hacks can now be removed. 4) Since calling git log when a file doesn't exist is expensive this change adds a message whenever this happens. In my tests this message is never hit. If it starts showing up thousands of times then the cause of the slowdown will be obvious next time. While this CL does make this script handle relative paths, and does fix encoding exceptions, it does not by itself fix the performance issue. For that a change in how this script is called will be needed, after this CL lands. Test commands: #1: reproduce the problem and make sure no exclusion-dirs is handled: vpython3 tools/symsrc/source_index.py out\official_test\chrome.dll.pdb --build-dir=out\official_test --toolchain-dir=third_party\depot_tools\win_toolchain\vs_files\27370823e7 #2: use exclusion-dirs to get a 100x speedup: vpython3 tools/symsrc/source_index.py out\official_test\chrome.dll.pdb --build-dir=out\official_test --toolchain-dir=third_party\depot_tools\win_toolchain\vs_files\27370823e7 --exclusion-dirs=third_party\rust-toolchain #3: use exclusion-dirs with semi-colon separation to replace using --build-dir (still fast): vpython3 tools/symsrc/source_index.py out\official_test\chrome.dll.pdb --toolchain-dir=third_party\depot_tools\win_toolchain\vs_files\27370823e7 --exclusion-dirs=third_party\rust-toolchain;out\official_test A clean copy of chrome.dll.pdb is needed for each test. The freshly built DLL was copied elsewhere and then copied back before each test. See README.chromium for more testing ideas. (cherry picked from commit 139fc68) Bug: 1471723 Change-Id: I9d28a44ba2bed9d52258c42961e14ddf432ac4bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4771880 Reviewed-by: Sébastien Marchand <[email protected]> Commit-Queue: Bruce Dawson <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1182418} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4794968 Reviewed-by: Xinan Lin <[email protected]> Cr-Commit-Position: refs/branch-heads/5938@{#286} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}

It appears that, contrary to the documentation on MSDN, IsEnclaveTypeSupported is not exported from all versions of Windows 10 kernel32.dll - most certainly 10.0.10240 but also potentially others. This causes a catastrophic DLL resolution failure during bootstrap of the chrome.exe process. This CL resolves this dependency dynamically so as to correctly support these older operating systems. BUG=1482250 Change-Id: I36efcb52ffd39a8edb8755833a7a0a4a5babe166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4863505 Reviewed-by: Srinivas Sista <[email protected]> Commit-Queue: Prudhvikumar Bommana <[email protected]> Owners-Override: Srinivas Sista <[email protected]> Cr-Commit-Position: refs/branch-heads/5938_62@{#3} Cr-Branched-From: 25a7172-refs/branch-heads/5938@{#1146} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}

This feature's release is going to be delayed. This CL turns the reporting attestations changes into its own feature flag to prevent blocking the release of the other 2 features wrapped into the M120 feature flag. (cherry picked from commit b73d29d) Change-Id: I47cd860132f39a55e58e7773b9a8a119e331fa14 Bug: 1505572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5063592 Commit-Queue: Garrett Tanzer <[email protected]> Reviewed-by: Garrett Tanzer <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1229606} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5075023 Owners-Override: Srinivas Sista <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Srinivas Sista <[email protected]> Cr-Commit-Position: refs/branch-heads/6099_56@{#3} Cr-Branched-From: 6c113a6-refs/branch-heads/6099@{#1192} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}

Roll src/v8 from c6b8b43c3042 to ac8da461a202 Commits rolled: https://chromium.googlesource.com/v8/v8.git/+log/c6b8b43c3042..ac8da461a202 Generated by: http://go/bbid/8748321227209147585 Change-Id: I40d4309cafbca9da6d480459f1b2a42f53944ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526282 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6367_201@{#3} Cr-Branched-From: 46cf136-refs/branch-heads/6367@{#1130} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}

blueboxd added the enhancement New feature or request label Nov 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Any way to automatically update Chromium legacy, or an update check inside the app? #3

Any way to automatically update Chromium legacy, or an update check inside the app? #3

LeeBinder commented Nov 14, 2020

blueboxd commented Nov 14, 2020

LeeBinder commented Nov 15, 2020

Wowfunhappy commented Nov 18, 2020 •

edited

Loading

LeeBinder commented Nov 18, 2020

Wowfunhappy commented Feb 6, 2021

LeeBinder commented Feb 6, 2021 •

edited

Loading

Wowfunhappy commented Feb 6, 2021

LeeBinder commented Feb 6, 2021 •

edited

Loading

Wowfunhappy commented Feb 6, 2021

LeeBinder commented Feb 6, 2021

Wowfunhappy commented Feb 6, 2021

RJVB commented Feb 25, 2023

Wowfunhappy commented Feb 26, 2023

RJVB commented Feb 26, 2023 via email

Any way to automatically update Chromium legacy, or an update check inside the app? #3

Any way to automatically update Chromium legacy, or an update check inside the app? #3

Comments

LeeBinder commented Nov 14, 2020

blueboxd commented Nov 14, 2020

LeeBinder commented Nov 15, 2020

Wowfunhappy commented Nov 18, 2020 • edited Loading

LeeBinder commented Nov 18, 2020

Wowfunhappy commented Feb 6, 2021

LeeBinder commented Feb 6, 2021 • edited Loading

Wowfunhappy commented Feb 6, 2021

LeeBinder commented Feb 6, 2021 • edited Loading

Wowfunhappy commented Feb 6, 2021

LeeBinder commented Feb 6, 2021

Wowfunhappy commented Feb 6, 2021

RJVB commented Feb 25, 2023

Wowfunhappy commented Feb 26, 2023

RJVB commented Feb 26, 2023 via email

Wowfunhappy commented Nov 18, 2020 •

edited

Loading

LeeBinder commented Feb 6, 2021 •

edited

Loading

LeeBinder commented Feb 6, 2021 •

edited

Loading