Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support github-actions-workflow language #9

Merged
merged 2 commits into from
May 13, 2024

Conversation

kachick
Copy link
Contributor

@kachick kachick commented May 3, 2024

This is a restriction from another extension, please see github/vscode-github-actions#195 for further detail.


GitHub provides useful extension for GitHub Actions workflow, but it marks the YAML files as another language.

If enabling both their extension and this formatter requires switching the language mode from the VScode UI and switching again to use their extension.

After this pull request, the following config enables this formatter while keeping the language ID for GitHub Actions workflows.

{
  "[yaml]": {
    "editor.defaultFormatter": "bluebrown.yamlfmt"
  },
  "[github-actions-workflow]": {
    "editor.defaultFormatter": "bluebrown.yamlfmt"
  }
}

I don't think this is a beautiful solution, this means one extension depends on another extension.
If you know a better way, please close this PR 🙏

@bluebrown
Copy link
Owner

I think the test is failing because of some other issues. Like described here https://github.com/bluebrown/vscode-extension-yamlfmt/blob/main/MAINTAINER.md#tests. The workflow already runs it twice because the first run would always fail.

Perhaps bumping dependencies, would resolve it.

@kachick
Copy link
Contributor Author

kachick commented May 4, 2024

Thanks for your reviewing! I'll check the CI result and attempt to update it in another day. 💪

@kachick
Copy link
Contributor Author

kachick commented May 10, 2024

I think the test is failing because of some other issues.

Perhaps bumping dependencies, would resolve it.

Updated in #8.

@bluebrown
Copy link
Owner

Hi @kachick , thanks alot for all the PRs. I think you have to rebase your branch onto latest main, now.

@kachick
Copy link
Contributor Author

kachick commented May 12, 2024

Thank you for reviewing and merging, I have merged current main into this PR. 🙏

@bluebrown bluebrown merged commit e67d7e2 into bluebrown:main May 13, 2024
3 checks passed
@kachick
Copy link
Contributor Author

kachick commented May 13, 2024

Thank you!

@kachick kachick deleted the support-github-action-language branch May 13, 2024 13:56
@bluebrown
Copy link
Owner

I still need to release it, my token is expired. I will get to it in the next few days. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants