-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support github-actions-workflow
language
#9
feat: support github-actions-workflow
language
#9
Conversation
I think the test is failing because of some other issues. Like described here https://github.com/bluebrown/vscode-extension-yamlfmt/blob/main/MAINTAINER.md#tests. The workflow already runs it twice because the first run would always fail. Perhaps bumping dependencies, would resolve it. |
Thanks for your reviewing! I'll check the CI result and attempt to update it in another day. 💪 |
Updated in #8. |
Hi @kachick , thanks alot for all the PRs. I think you have to rebase your branch onto latest main, now. |
Thank you for reviewing and merging, I have merged current main into this PR. 🙏 |
Thank you! |
I still need to release it, my token is expired. I will get to it in the next few days. Sorry for the delay. |
This is a restriction from another extension, please see github/vscode-github-actions#195 for further detail.
GitHub provides useful extension for GitHub Actions workflow, but it marks the YAML files as another language.
If enabling both their extension and this formatter requires switching the language mode from the VScode UI and switching again to use their extension.
After this pull request, the following config enables this formatter while keeping the language ID for GitHub Actions workflows.
I don't think this is a beautiful solution, this means one extension depends on another extension.
If you know a better way, please close this PR 🙏