Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This maintenance change introduces compatibility with the current stable releases of React, React DOM, and a number of other smaller libraries. We upgrade the libraries and provide bugfixes for several warnings and library behavior changes that were found during testing.
After the initial upgrade the observed test failures were as follows:
React DOM: Upgrade from 16.8.6 to 16.13
At the time of this pull request, the
master
branch of design-system-reactis locked in package-lock.json to [email protected] and [email protected]. Unit
tests are succeeding in
master
.React DOM version 16.9 introduces two deprecation warnings that cause the
design-system-react test suite to fail after the
react-dom
dependency isupgraded:
React DOM
UNSAFE_*
lifecycle methods. (Enabled warnAboutDeprecatedLifecycles flag by default facebook/react#15186 and unify deprecated/unsafe lifecycle warnings, pass tests facebook/react#16103)javascript:
URLs as a common attack surface. (Warn for javascript: URLs in DOM sinks facebook/react#15047)React: Upgrade from 16.9.0 to 16.13
To keep up-to-date with new React releases, this pull request bumps to the
latest stable version. Notable changes between the old and new version are:
React
React.createFactory()
(Add React.createFactory() deprecation warning facebook/react#17878)Other Upgrades
We use this opportunity to upgrade a few other dependencies that include
small bug fixes and other seemingly useful improvements.
prop-types: Upgrade from 15.6.0 to 15.7.2
https://github.com/facebook/prop-types/blob/master/CHANGELOG.md
react-contenteditable: Upgrade from 3.3.1 to 3.3.4
lovasoa/react-contenteditable@3.3.1...v3.3.4
shortid: Upgrade from 2.2.14 to 2.2.15
dylang/shortid@2.2.14...2.2.15
CONTRIBUTOR checklist (do not remove)
Please complete for every pull request
npm run lint:fix
has been run and linting passes.components/component-docs.json
CI tests pass (npm test
).REVIEWER checklist (do not remove)
components/component-docs.json
tests.Required only if there are markup / UX changes
last-slds-markup-review
inpackage.json
and push.last-accessibility-review
, topackage.json
and push.npm run local-update
within locally cloned site repo to confirm the site will function correctly at the next release.