Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): add setBalance (#58) #1282

Merged
merged 7 commits into from
Oct 21, 2022
Merged

feat(web): add setBalance (#58) #1282

merged 7 commits into from
Oct 21, 2022

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Sep 23, 2022 •
edited
Loading

Co-authored-by: Andrew Novikov [email protected]

Description

See #58

Template:
https://mdn.github.io/webaudio-examples/stereo-panner-node/

  • validate why p.crossOrigin = 'anonymous' is needed.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

See #1248

@Gustl22 Gustl22 marked this pull request as ready for review October 8, 2022 17:54
@Gustl22 Gustl22 requested a review from spydon October 18, 2022 08:49
@Gustl22 Gustl22 merged commit 782fc9d into main Oct 21, 2022
@Gustl22 Gustl22 deleted the balance-web branch October 21, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gustl22 @spydon